carp if _member_constructor is called with one package

diff --git a/Debbugs/Collection/Package.pm b/Debbugs/Collection/Package.pm
index 1675c498e1a3df9ef62a23d5ebf9187d2abbefba..8caf906faaa084cbac1354d47ebea9e7ecfc6c6f 100644 (file)
--- a/Debbugs/Collection/Package.pm
+++ b/Debbugs/Collection/Package.pm
@@ -69,6 +69,9 @@ sub _member_constructor {
     }
     my @return;
     if (defined $schema) {
+        if (not ref($args{packages}) or @{$args{packages}} == 1) {
+            carp("Likely inefficiency; member_constructor called with one argument");
+        }
         my $packages =
             Debbugs::Package::_get_valid_version_info_from_db(packages => $args{packages},
                                                               schema => $schema,