From: Don Armstrong <don@donarmstrong.com>
Date: Fri, 8 Jun 2018 20:34:41 +0000 (-0700)
Subject: carp if _member_constructor is called with one package
X-Git-Url: https://git.donarmstrong.com/?p=debbugs.git;a=commitdiff_plain;h=8862b4b5fef5ec2001f8cb77e94cf0728968191c

carp if _member_constructor is called with one package
---

diff --git a/Debbugs/Collection/Package.pm b/Debbugs/Collection/Package.pm
index 1675c49..8caf906 100644
--- a/Debbugs/Collection/Package.pm
+++ b/Debbugs/Collection/Package.pm
@@ -69,6 +69,9 @@ sub _member_constructor {
     }
     my @return;
     if (defined $schema) {
+        if (not ref($args{packages}) or @{$args{packages}} == 1) {
+            carp("Likely inefficiency; member_constructor called with one argument");
+        }
         my $packages =
             Debbugs::Package::_get_valid_version_info_from_db(packages => $args{packages},
                                                               schema => $schema,