From 8862b4b5fef5ec2001f8cb77e94cf0728968191c Mon Sep 17 00:00:00 2001 From: Don Armstrong Date: Fri, 8 Jun 2018 13:34:41 -0700 Subject: [PATCH] carp if _member_constructor is called with one package --- Debbugs/Collection/Package.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Debbugs/Collection/Package.pm b/Debbugs/Collection/Package.pm index 1675c49..8caf906 100644 --- a/Debbugs/Collection/Package.pm +++ b/Debbugs/Collection/Package.pm @@ -69,6 +69,9 @@ sub _member_constructor { } my @return; if (defined $schema) { + if (not ref($args{packages}) or @{$args{packages}} == 1) { + carp("Likely inefficiency; member_constructor called with one argument"); + } my $packages = Debbugs::Package::_get_valid_version_info_from_db(packages => $args{packages}, schema => $schema, -- 2.39.2