use IO::Dir and my appropriately

[bugscan.git] / scanlib.pm

diff --git a/scanlib.pm b/scanlib.pm
index 03347cf076d1a4f94d74f77009353de25cd2fe5b..6ed7cce85390860ab9661beaa7d67e79dad155ad 100644 (file)
--- a/scanlib.pm
+++ b/scanlib.pm
@@ -10,6 +10,9 @@
 #   %section        - map from packagename to section in the FTP-site
 #   %packagelist    - map from packagename to bugreports
 
+use warnings;
+use strict;
+
 use lib qw(/org/bugs.debian.org/perl);
 use LWP::UserAgent;
 use Debbugs::MIME qw(decode_rfc1522 encode_rfc1522);
@@ -17,9 +20,11 @@ use Debbugs::Packages;
 use Debbugs::Versions;
 use Debbugs::Status;
 use Fcntl qw(O_RDONLY);
-use strict;
-use warnings;
-require bugcfg;
+
+use File::Basename;
+use lib dirname(__FILE__);
+use bugcfg;
+
 package scanlib;
 
 our (%maintainer,%section,%packagelist,%debbugssection,%bugs);
@@ -46,14 +51,10 @@ sub readmaintainers() {
 }
 
 
-sub readsources() {
-       my $root;                                       # Root of archive we are scanning
-       my $archive;                            # Name of archive we are scanning
-       my $sect;                                       # Name of current section
+sub readsources {
+    my ($root,$archive) = @_;
 
-       $root=shift;
-       $archive=shift;
-       for $sect (@bugcfg::sections) {
+       for my $sect (@bugcfg::sections) {
                open(P, "zcat $root/$sect/source/Sources.gz|")
                        or die open "open: $sect sourcelist: $!\n";
                while (<P>) {
@@ -96,12 +97,9 @@ sub readpackages {
     }
 }
 
-sub readdebbugssources() {
-       my $file;
-       my $archive;
+sub readdebbugssources {
+    my ($file,$archive) = @_;
 
-       $file=shift;
-       $archive=shift;
        open(P, $file)
                or die "open: $file: $!\n";
        while (<P>) {
@@ -142,24 +140,22 @@ sub scanspool() {
 }
 
 sub scanspooldir {
-       my ($dir)               = @_;
-       my $f;                  # While we're currently processing
-       my @list;               # List of files to process
+       my ($dir,$bugs) = @_;
        my $skip;               # Flow control
        my $walk;               # index variable
        my $taginfo;    # Tag info
                                        
        my @archs_with_source = ( @bugcfg::architectures, 'source' );
 
-       chdir($dir) or die "chdir $dir: $!\n";
+#      chdir($dir) or die "chdir $dir: $!\n";
 
-       opendir(DIR, $dir) or die "opendir $dir: $!\n";
-       @list = grep { s/\.summary$// }
-                       grep { m/^\d+\.summary$/ } 
-                       readdir(DIR);
-       closedir(DIR);
+       my $d = IO::Dir->new($dir) or die "Unable to opendir: $dir $!\n";
+       my @list = grep { s/\.summary$// }
+        grep { m/^\d+\.summary$/ }
+        $d->read;
+       $d->close;
 
-       for $f (@list) {
+       for my $f (@list) {
                my $bug = Debbugs::Status::read_bug(summary => "$f.summary");
                next if (!defined($bug));