Check that a package is really present in a distribution before putting
[bugscan.git] / scanlib.pm
index 3680b10..65adb63 100644 (file)
@@ -6,66 +6,33 @@
 # which was based on an unknown other script.
 #
 # Global variables:
-#   %comments       - map from bugnumber to bug description
 #   %premature      - list of prematurely closed bugreports
 #   %exclude        - list of bugreports to exclude from the report
 #   %maintainer     - map from packagename to maintainer
 #   %section        - map from packagename to section in the FTP-site
 #   %packagelist    - map from packagename to bugreports
-#   %NMU            - map with NMU information
 
-use lib qw(/org/bugs.debian.org/perl/);
+use lib qw(/org/bugs.debian.org/perl);
 use LWP::UserAgent;
 use Debbugs::MIME qw(decode_rfc1522 encode_rfc1522);
 use Debbugs::Packages;
 use Debbugs::Versions;
 use Debbugs::Status;
 use Fcntl qw(O_RDONLY);
+use strict;
+use warnings;
 require bugcfg;
+package scanlib;
 
-sub readcomments() {
-# Read bug commentary 
-# It is in paragraph format, with the first line of each paragraph being
-# the bug number or package name to which the comment applies.
-# Prefix a bug number with a * to force it to be listed even if it's closed.
-# (This deals with prematurely closed bugs)
-
-       local($index);                                  # Bug-number for current comment
-       local($file);                                   # Name of comments-file
-
-       %comments = ();                                 # Initialize our data
-       %premature = ();
-       %exclude = ();
-       $file=shift;
-       open(C, $file) or die "open $file: $!\n";
-       while (<C>) {
-               chomp;
-               if (m/^\s*$/) {                         # Check for paragraph-breaks
-                       undef $index;
-               } elsif (defined $index) {
-                       $comments{$index} .= $_ . "\n";
-               } else {
-                       if (s/^\*//) {                  # Test & remove initial *
-                               $premature{$_} = 1;
-                       }
-                       if (s/\s+EXCLUDE\s*//) {        # Test & remove EXCLUDE
-                               $exclude{$_} = 1;
-                               next;
-                       }
-                       $index = $_;
-                       $comments{$index} = ''; # New comment, initialize data
-               }
-       }
-       close(C);
-}
+our (%premature,%exclude,%maintainer,%section,%packagelist,%debbugssection,%bugs);
 
 
 # Read the list of maintainer 
 sub readmaintainers() {
-       local ($pkg);                                   # Name of package
-       local ($mnt);                                   # Maintainer name & email
+       my $pkg;                                        # Name of package
+       my $mnt;                                        # Maintainer name & email
 
-       open(M, $maintainerlist) or die "open $maintainerlist: $!\n";
+       open(M, $bugcfg::maintainerlist) or die "open $bugcfg::maintainerlist: $!\n";
        while (<M>) {
                chomp;
                m/^(\S+)\s+(\S.*\S)\s*$/ or die "Maintainers: $_ ?";
@@ -82,15 +49,15 @@ sub readmaintainers() {
 
 
 sub readsources() {
-       local($root);                                   # Root of archive we are scanning
-       local($archive);                                # Name of archive we are scanning
-       local($sect);                                   # Name of current section
+       my $root;                                       # Root of archive we are scanning
+       my $archive;                            # Name of archive we are scanning
+       my $sect;                                       # Name of current section
 
        $root=shift;
        $archive=shift;
-       for $sect ( @sections) {
+       for $sect (@bugcfg::sections) {
                open(P, "zcat $root/$sect/source/Sources.gz|")
-                       or die open "open: $sect / $arch sourcelist: $!\n";
+                       or die open "open: $sect sourcelist: $!\n";
                while (<P>) {
                        chomp;
                        next unless m/^Package:\s/;
@@ -102,15 +69,15 @@ sub readsources() {
 }
 
 sub readpackages() {
-       local($root);                                   # Root of archive we are scanning
-       local($archive);                                # Name of archive we are scanning
-       local($sect);                                   # Name of current section
-       local($arch);                                   # Name of current architecture
+       my $root;                                       # Root of archive we are scanning
+       my $archive;                            # Name of archive we are scanning
+       my $sect;                                       # Name of current section
+       my $arch;                                       # Name of current architecture
 
        $root=shift;
        $archive=shift;
-       for $arch ( @architectures ) {
-               for $sect ( @sections) {
+       for $arch ( @bugcfg::architectures ) {
+               for $sect ( @bugcfg::sections) {
                        open(P, "zcat $root/$sect/binary-$arch/Packages.gz|")
                                or die "open: $root/$sect/binary-$arch/Packages.gz: $!\n";
                        while (<P>) {
@@ -125,8 +92,8 @@ sub readpackages() {
 }
 
 sub readdebbugssources() {
-       local($file);
-       local($archive);
+       my $file;
+       my $archive;
 
        $file=shift;
        $archive=shift;
@@ -143,7 +110,7 @@ sub readdebbugssources() {
 }
 
 sub readpseudopackages() {
-       open(P, $pseudolist) or die("open $pseudolist: $!\n");
+       open(P, $bugcfg::pseudolist) or die("open $bugcfg::pseudolist: $!\n");
        while (<P>) {
                chomp;
                s/\s.*//;
@@ -154,28 +121,28 @@ sub readpseudopackages() {
 
 
 sub scanspool() {
-       local(@dirs);
-       local($dir);
+       my @dirs;
+       my $dir;
 
-       chdir($spooldir) or die "chdir $spooldir: $!\n";
+       chdir($bugcfg::spooldir) or die "chdir $bugcfg::spooldir: $!\n";
 
-       opendir(DIR, $spooldir) or die "opendir $spooldir: $!\n";
+       opendir(DIR, $bugcfg::spooldir) or die "opendir $bugcfg::spooldir: $!\n";
        @dirs=grep(m/^\d+$/,readdir(DIR));
        closedir(DIR);
 
        for $dir (@dirs) {
-               scanspooldir("$spooldir/$dir");
+               scanspooldir("$bugcfg::spooldir/$dir");
        }
 
 }
 
 sub scanspooldir() {
-       local($dir)             = @_;
-       local($f);                      # While we're currently processing
-       local(@list);           # List of files to process
-       local($skip);           # Flow control
-       local($walk);           # index variable
-       local($taginfo);        # Tag info
+       my ($dir)               = @_;
+       my $f;                  # While we're currently processing
+       my @list;               # List of files to process
+       my $skip;               # Flow control
+       my $walk;               # index variable
+       my $taginfo;    # Tag info
 
        chdir($dir) or die "chdir $dir: $!\n";
 
@@ -192,47 +159,78 @@ sub scanspooldir() {
                next if (!defined($bug));
                
                $skip=1;
-               for $walk (@priorities) {
+               for $walk (@bugcfg::priorities) {
                        $skip=0 if $walk eq $bug->{'severity'};
                }
 
                my @tags = split(' ', $bug->{'keywords'});
-               for $tag (@tags) {
-                       for $s (@skiptags) {
+               for my $tag (@tags) {
+                       for my $s (@bugcfg::skiptags) {
                                $skip=1 if $tag eq $s;
                        }
                }
                next if $skip==1;
-               
-               my $oldstable_tag    = grep(/^woody$/, @tags);
-               my $stable_tag       = grep(/^sarge$/, @tags);
-               my $testing_tag      = grep(/^etch$/, @tags);
-               my $unstable_tag     = grep(/^sid$/, @tags);
-               my $experimental_tag = grep(/^experimental$/, @tags);
-
+       
+               my %disttags = ();      
+               $disttags{'oldstable'}    = grep(/^woody$/, @tags);
+               $disttags{'stable'}       = grep(/^sarge$/, @tags);
+               $disttags{'testing'}      = grep(/^etch$/, @tags);
+               $disttags{'unstable'}     = grep(/^sid$/, @tags);
+               $disttags{'experimental'} = grep(/^experimental$/, @tags);
+                       
                # default according to dondelelcaro 2006-11-11
-               if (!$oldstable_tag && !$stable_tag && !$testing_tag && !$unstable_tag && !$experimental_tag) {
-                       $testing_tag = 1;
-                       $unstable_tag = 1;
-                       $experimental_tag = 1;
+               if (!$disttags{'oldstable'} && !$disttags{'stable'} && !$disttags{'testing'} && !$disttags{'unstable'} && !$disttags{'experimental'}) {
+                       $disttags{'testing'} = 1;
+                       $disttags{'unstable'} = 1;
+                       $disttags{'experimental'} = 1;
                }
-
-               # only bother to check the versioning status for the distributions indicated by the tags 
-               $status_oldstable    = get_status($f, $bug, 'oldstable')    if ($oldstable_tag);
-               $status_stable       = get_status($f, $bug, 'stable')       if ($stable_tag);
-               $status_testing      = get_status($f, $bug, 'testing')      if ($testing_tag);
-               $status_unstable     = get_status($f, $bug, 'unstable')     if ($unstable_tag);
-               $status_experimental = get_status($f, $bug, 'experimental') if ($experimental_tag);
-
-               $relinfo = "";
-               $relinfo .= (($oldstable_tag    && $status_oldstable->{'pending'}    eq 'pending') ? "O" : "");
-               $relinfo .= (($stable_tag       && $status_stable->{'pending'}       eq 'pending') ? "S" : "");
-               $relinfo .= (($testing_tag      && $status_testing->{'pending'}      eq 'pending') ? "T" : "");
-               $relinfo .= (($unstable_tag     && $status_unstable->{'pending'}     eq 'pending') ? "U" : "");
-               $relinfo .= (($experimental_tag && $status_experimental->{'pending'} eq 'pending') ? "E" : "");
                
-               next if $relinfo eq '' and not $premature{$f};
-               $premature{$f}++ if $relinfo eq '';
+               my $relinfo = "";
+               if (defined($section{$bug->{'package'}}) && $section{$bug->{'package'}} eq 'pseudo') {
+                       # versioning information makes no sense for pseudo packages,
+                       # just use the tags
+                       for my $dist qw(oldstable stable testing unstable experimental) {
+                               $relinfo .= uc(substr($dist, 0, 1)) if $disttags{$dist};
+                       }
+                       next if (length($bug->{'done'}));
+               } else {
+                       # only bother to check the versioning status for the distributions indicated by the tags 
+                       for my $dist qw(oldstable stable testing unstable experimental) {
+                               local $SIG{__WARN__} = sub {};
+
+                               next if (!$disttags{$dist});
+
+                               # This is needed for now
+                               my $exists = 0;
+                               for my $arch (@bugcfg::architectures) {
+                                       for my $pkg (split /[,\s]+/, $bug->{'package'}) {
+                                               my @versions = Debbugs::Packages::getversions($pkg, $dist, $arch);
+                                               $exists = 1 if (scalar @versions > 0);
+                                       }
+                                       last if $exists;
+                               }
+
+                               next if !$exists;
+
+                               my $presence = Debbugs::Status::bug_presence(
+                                       bug => $f, 
+                                       status => $bug, 
+                                       dist => $dist, 
+                                       arch => \@bugcfg::architectures
+                               );
+
+                               # ignore bugs that are absent/fixed in this distribution, include everything
+                               # else (that is, "found" which says that the bug is present, and undef, which
+                               # indicates that no versioning information is present and it's not closed
+                               # unversioned)
+                               if (!defined($presence) || ($presence ne 'absent' && $presence ne 'fixed')) {
+                                       $relinfo .= uc(substr($dist, 0, 1));
+                               }
+                       }
+                       
+                       next if $relinfo eq '' and not $premature{$f};
+                       $premature{$f}++ if $relinfo eq '';
+               }
 
                $taginfo = "[";
                $taginfo .= ($bug->{'keywords'} =~ /\bpending\b/        ? "P" : " ");
@@ -250,7 +248,7 @@ sub scanspooldir() {
                        next if ($merged[0] < $f);
                }
 
-               for $package (split /[,\s]+/, $bug->{'package'}) {
+               for my $package (split /[,\s]+/, $bug->{'package'}) {
                        $_= $package; y/A-Z/a-z/; $_= $` if m/[^-+._a-z0-9]/;
                        if (not defined $section{$_}) {
                                if (defined $debbugssection{$_}) {
@@ -260,7 +258,7 @@ sub scanspooldir() {
                                }
                        }
 
-                       $packagelist{$_} .= " $f";
+                       push @{$packagelist{$_}}, $f;
                }
 
                if ($relinfo eq "") { # or $relinfo eq "U" # confuses e.g. #210306
@@ -275,12 +273,12 @@ sub scanspooldir() {
 
 
 sub readstatus() {
-       local ($bug);           # Number of current bug
-       local ($subject);       # Subject for current bug
-       local ($pkg);           # Name of current package
-       local ($file);          # Name of statusfile
-       local ($sect);          # Section of current package
-       local ($mnt);           # Maintainer of current package
+       my $bug;                # Number of current bug
+       my $subject;    # Subject for current bug
+       my $pkg;                # Name of current package
+       my $file;               # Name of statusfile
+       my $sect;               # Section of current package
+       my $mnt;                # Maintainer of current package
 
        $file=shift;
        open(P, $file) or die "open $file: $!";
@@ -289,9 +287,10 @@ sub readstatus() {
                if (m/^[0-9]+ \[/) {
                        ($bug,$subject)=split(/ /, $_, 2);
                        $bugs{$bug}=$subject;
-                       $packagelist{$pkg} .= "$bug ";
+                       push @{$packagelist{$pkg}}, $bug;
                } else {
                        ($pkg,$sect, $mnt)=split(/ /, $_, 3);
+                       next if (!defined($pkg));
                        $section{$pkg}=$sect;
                        $maintainer{$pkg}=$mnt;
                }
@@ -300,39 +299,6 @@ sub readstatus() {
 }
 
 
-sub readNMUstatus() {
-       local ($bug);       # Number of current bug
-       local ($source);    # Source upload which closes this bug.
-       local ($version);   # Version where this bug was closed.
-       local ($flag);      # Whether this paragraph has been processed.
-       local ($field, $value);
-
-       for (split /\n/, LWP::UserAgent->new->request(HTTP::Request->new(GET => shift))->content) {
-               chomp;
-               if (m/^$/) {
-                       $NMU{$bug} = 1;
-                       $NMU{$bug, "source"} = $source;
-                       $NMU{$bug, "version"} = $version;
-#                      $comments{$bug} .= "[FIXED] Fixed package $source is in Incoming\n";
-                       $flag = 0;
-               } else {
-                       ($field, $value) = split(/: /, $_, 2);
-                       $bug = $value if($field =~ /bug/i);
-                       $source = $value if($field =~ /source/i);
-                       $version = $value if($field =~ /version/i);
-                       $flag = 1;
-               }
-       }
-       if ($flag) {
-               $NMU{$bug} = 1;
-               $NMU{$bug, "source"} = $source;
-               $NMU{$bug, "version"} = $version;
-#              $comments{$bug} .= "[FIXED] Fixed package $source in in Incoming\n";
-       }
-       close P;
-}
-
-
 sub urlsanit {
        my $url = shift;
        $url =~ s/%/%25/g;
@@ -350,36 +316,17 @@ sub htmlsanit {
 }
 
 sub wwwnumber() {
-       local ($number) = shift;                # Number of bug to html-ize
-#      local ($section);                               # Section for the bug
+       my $number = shift;             # Number of bug to html-ize
 
        "<A HREF=\"http://bugs.debian.org/cgi-bin/bugreport.cgi?archive=no&amp;bug=" .
                urlsanit($number) . '">' . htmlsanit($number) . '</A>';
-#      ($section=$number) =~ s/([0-9]{2}).*/$1/;
-#      "<A HREF=\"${btsURL}/db/$section/$number.html\">$number</A>";
 }
 
 sub wwwname() {
-       local ($name) = shift;                  # Name of package
+       my $name = shift;                       # Name of package
 
        "<A HREF=\"http://bugs.debian.org/cgi-bin/pkgreport.cgi?archive=no&amp;pkg=" .
                urlsanit($name) . '">' . htmlsanit($name) . '</A>';
-#      "<A HREF=\"${btsURL}/db/pa/l$name.html\">$name</A>";
-}
-
-my $_version_cache = {};
-sub get_status() {
-       my ($bugnr, $bug, $dist) = @_;
-
-       my @versions = Debbugs::Status::getversions($bug->{'package'}, $dist, undef);
-       my @sourceversions = Debbugs::Status::makesourceversions($bug->{'package'}, $dist, @versions);
-
-       return Debbugs::Status::max_buggy(bug => $bugnr,
-                        sourceversions => \@sourceversions,
-                        found => $bug->{'found_versions'},
-                        fixed => $bug->{'fixed_versions'},
-                        version_cache => $_version_cache,
-                        package => $bug->{'package'});
 }
 
 sub check_worry {
@@ -387,8 +334,10 @@ sub check_worry {
 
        if ($status =~ m/^\[[^]]*I/ or
            $status =~ m/ \[[^]]*X/ or
-            ($status =~ m/ \[[^]]*[OSUE]/ and $status !~ m/ \[[^]]*T/)) {
+            $status !~ m/ \[[^]]*T/) {
                return 0;
        }
        return 1;
 }
+
+1;