Neil Puttock [Tue, 7 Dec 2010 23:39:05 +0000 (23:39 +0000)]
Fix #1427.
The copy constructor for Book assumes the list of objects to clone are
scores, which is unsafe since a \book(part) block can also contain markup and
page markers.
* input/regression (book-identifier-markup.ly):
new regtest
* lily/book.cc (copy constructor):
treat entries in scores_ separately, cloning Score and Page_marker objects
James Lowe [Mon, 6 Dec 2010 19:19:52 +0000 (19:19 +0000)]
Doc: Added @seealso to Ancient.itely in NR
As part of Tracker issue 1287
First step is to get the sectioning in line with CG Doc Policy. No other
corrections (incuding Typos or @lilypond example) will be made nor no
new text added.
Once the sectioning has been completed then we can look at improving the
content and/or examples.
Added @seealso sections in line with CG Doc Policy
This commit
- extends the parser to accept the following syntax:
\tempo numA ~ numB
- changes the 'tempoUnitCount property to accept either
a number or a pair (in which case tempoWholesPerMinutes
will be set by averaging the two numbers)
- adapts the format-metronome-markup translation function
to print the tempo range properly
- adds a metronome-range.ly regtest
- adds relevant display-lily methods, and updates this
regtest as well.
PartCombine: part-combine texts on first real note rather than rests
-) If the context property partCombineTextsOnNote is set, the part-combine
texts are not printed immediately if there is a rest or skip, but on
the next following note. If the voice contains a note, they are printed
immediately.
This is needed if one voice has a full measure rest and the other e.g.
r2 r4 c4.
-) The event triggering the part-combine text is cached in that case
and the Part_combine_engraver now also listens to note events. The
texts are then created at the first moment when a note is encountered.
Do not silently clear a tie attempt, but notify the user that a tie
could not be created (typically either due to a typo or due to a missing
tieWaitForNote)
In a chord, a tie is only unterminated if none of the notes of the
chord create a tie. All other notes of that chord are possible
candidates for a tie start, but not neccesary. For this, I simply
suppress the warning if a note from the same moment already caused
a tie.
E.g. in <c e g>~ g, the g will create a tie, but the c and e should
not trigger a warning!
FiguredBass: Extenders for figs of different width should stop at same position
FB extenders use the extent of the hidden figure grob, so extenders
of different figures might stop at different positions. Ideally, the
note of the associated staff should be retrieved and used as the
position to stop the extender. However, FB can also exist standalone
without any attached staff.
So, as a workaround, this patch simply sets the text of all hidden
figures to 0, so they all have the same extent and all extenders will
stop at the same position.
Doc: cleanup @file{}, take 2: remove all @/ escaping sequences.
For now, remove all @/ sequences from @file references.
New line-breaks will be introduced later with an automatic
rulein order to make the syntax more consistent.
PartCombine: part-combine texts on first real note rather than rests
-) If the context property partCombineTextsOnNote is set, the part-combine
texts are not printed immediately if there is a rest or skip, but on
the next following note. If the voice contains a note, they are printed
immediately.
This is needed if one voice has a full measure rest and the other e.g.
r2 r4 c4.
-) The event triggering the part-combine text is cached in that case
and the Part_combine_engraver now also listens to note events. The
texts are then created at the first moment when a note is encountered.
Do not silently clear a tie attempt, but notify the user that a tie
could not be created (typically either due to a typo or due to a missing
tieWaitForNote)
In a chord, a tie is only unterminated if none of the notes of the
chord create a tie. All other notes of that chord are possible
candidates for a tie start, but not neccesary. For this, I simply
suppress the warning if a note from the same moment already caused
a tie.
E.g. in <c e g>~ g, the g will create a tie, but the c and e should
not trigger a warning!
FiguredBass: Extenders for figs of different width should stop at same position
FB extenders use the extent of the hidden figure grob, so extenders
of different figures might stop at different positions. Ideally, the
note of the associated staff should be retrieved and used as the
position to stop the extender. However, FB can also exist standalone
without any attached staff.
So, as a workaround, this patch simply sets the text of all hidden
figures to 0, so they all have the same extent and all extenders will
stop at the same position.