]> git.donarmstrong.com Git - lilypond.git/blobdiff - lily/slur-engraver.cc
Fix some bugs in the dynamic engraver and PostScript backend
[lilypond.git] / lily / slur-engraver.cc
index c3c48152530745e2c255ac8c1197e550c6d9bc4e..0e649fe566165944aad7131a8f9edb4eacff558a 100644 (file)
@@ -1,41 +1,50 @@
 /*
   slur-engraver.cc -- implement Slur_engraver
 
-  (c) 1997--2004 Han-Wen Nienhuys <hanwen@cs.uu.nl>
-*/
+  source file of the GNU LilyPond music typesetter
 
-#include "event.hh"
-#include "new-slur.hh"
-#include "warn.hh"
-#include "note-column.hh"
-#include "context.hh"
+  (c) 1997--2006 Han-Wen Nienhuys <hanwen@xs4all.nl>
+*/
 
 #include "engraver.hh"
+
+#include "context.hh"
+#include "directional-element-interface.hh"
+#include "international.hh"
+#include "note-column.hh"
+#include "slur.hh"
 #include "spanner.hh"
+#include "warn.hh"
 
 /*
   It is possible that a slur starts and ends on the same note.  At
   least, it is for phrasing slurs: a note can be both beginning and
   ending of a phrase.
- */
-
+*/
 class Slur_engraver : public Engraver
 {
   Drul_array<Music *> events_;
-  Music * running_slur_start_;
-  Grob * slur_;
-  Grob * end_slur_;
-
-  Moment last_start_;
+  Music *running_slur_start_;
+  vector<Grob*> slurs_;
+  vector<Grob*> end_slurs_;
 
   void set_melisma (bool);
 
 protected:
-  virtual bool try_music (Music*);
-  virtual void acknowledge_grob (Grob_info);
-  virtual void stop_translation_timestep ();
+  virtual bool try_music (Music *);
+
+  DECLARE_ACKNOWLEDGER (accidental);
+  DECLARE_ACKNOWLEDGER (dynamic_line_spanner);
+  DECLARE_ACKNOWLEDGER (fingering);
+  DECLARE_ACKNOWLEDGER (note_column);
+  DECLARE_ACKNOWLEDGER (script);
+  DECLARE_ACKNOWLEDGER (text_script);
+  DECLARE_ACKNOWLEDGER (tie);
+  DECLARE_ACKNOWLEDGER (tuplet_number);
+  void acknowledge_extra_object (Grob_info);
+  void stop_translation_timestep ();
   virtual void finalize ();
-  virtual void process_music ();
+  void process_music ();
 
 public:
   TRANSLATOR_DECLARATIONS (Slur_engraver);
@@ -43,9 +52,7 @@ public:
 
 Slur_engraver::Slur_engraver ()
 {
-  events_[START] =events_[STOP] = 0;
-  end_slur_ = slur_ = 0;
-  last_start_ = Moment (-1);
+  events_[START] = events_[STOP] = 0;
 }
 
 bool
@@ -53,23 +60,14 @@ Slur_engraver::try_music (Music *m)
 {
   if (m->is_mus_type ("slur-event"))
     {
-      /*
-       Let's not start more than one slur per moment.
-      */
       Direction d = to_dir (m->get_property ("span-direction"));
       if (d == START)
        {
-         if (slur_)
-           return false;
-         
          events_[START] = m;
          return true;
        }
       else if (d == STOP)
        {
-         if (!slur_)
-           return false;
-         
          events_[STOP] = m;
          return true;
        }
@@ -80,34 +78,74 @@ Slur_engraver::try_music (Music *m)
 void
 Slur_engraver::set_melisma (bool m)
 {
-  context ()->set_property ("slurMelismaBusy", m ? SCM_BOOL_T :SCM_BOOL_F);
+  context ()->set_property ("slurMelismaBusy", m ? SCM_BOOL_T : SCM_BOOL_F);
 }
 
 void
-Slur_engraver::acknowledge_grob (Grob_info info)
+Slur_engraver::acknowledge_note_column (Grob_info info)
 {
-  Grob *e =info.grob_;
-  if (Note_column::has_interface (info.grob_))
-    {
-      if (slur_)
-       New_slur::add_column (slur_, e);
-      if (end_slur_)
-       New_slur::add_column (end_slur_, e);
-    }
-  else
-    {
-      if (slur_)
-       New_slur::add_extra_encompass (slur_, e);
-      if (end_slur_)
-       New_slur::add_extra_encompass (end_slur_, e);
-    }
+  Grob *e = info.grob ();
+  for (vsize i = slurs_.size (); i--;)
+    Slur::add_column (slurs_[i], e);
+  for (vsize i = end_slurs_.size (); i--;)
+    Slur::add_column (end_slurs_[i], e);
+}
+
+void
+Slur_engraver::acknowledge_extra_object (Grob_info info)
+{
+  Slur::auxiliary_acknowledge_extra_object (info, slurs_, end_slurs_);
+}
+
+void
+Slur_engraver::acknowledge_accidental (Grob_info info)
+{
+  acknowledge_extra_object (info);
+}
+
+void
+Slur_engraver::acknowledge_dynamic_line_spanner (Grob_info info)
+{
+  acknowledge_extra_object (info);
+}
+
+void
+Slur_engraver::acknowledge_fingering (Grob_info info)
+{
+  acknowledge_extra_object (info);
+}
+
+void
+Slur_engraver::acknowledge_tuplet_number (Grob_info info)
+{
+  acknowledge_extra_object (info);
+}
+
+
+void
+Slur_engraver::acknowledge_script (Grob_info info)
+{
+  if (!info.grob ()->internal_has_interface (ly_symbol2scm ("dynamic-interface")))
+    acknowledge_extra_object (info);
+}
+
+void
+Slur_engraver::acknowledge_text_script (Grob_info info)
+{
+  acknowledge_extra_object (info);
+}
+
+void
+Slur_engraver::acknowledge_tie (Grob_info info)
+{
+  acknowledge_extra_object (info);
 }
 
 void
 Slur_engraver::finalize ()
 {
-  if (slur_)
-    slur_->warning (_("unterminated slur"));
+  if (slurs_.size ())
+    slurs_[0]->warning (_ ("unterminated slur"));
 }
 
 void
@@ -115,32 +153,57 @@ Slur_engraver::process_music ()
 {
   if (events_[STOP])
     {
-      end_slur_ = slur_;
-      slur_ = 0;
+      if (slurs_.size () == 0)
+       events_[STOP]->origin ()->warning (_ ("can't end slur"));
+
+      end_slurs_ = slurs_;
+      slurs_.clear ();
     }
-  
-  if (events_[START] && !slur_)
+
+  if (events_[START] && slurs_.empty ())
     {
       Music *ev = events_[START];
-      slur_ = make_spanner ("Slur", events_[START]->self_scm ());
-      if (Direction updown = to_dir (ev->get_property ("direction")))
-       slur_->set_property ("direction", scm_int2num (updown));
-    }
 
-  set_melisma (slur_);
+      bool double_slurs = to_boolean (get_property ("doubleSlurs"));
+
+      Grob *slur = make_spanner ("Slur", events_[START]->self_scm ());
+      Direction updown = to_dir (ev->get_property ("direction"));
+      if (updown && !double_slurs)
+       set_grob_direction (slur, updown);
+
+      slurs_.push_back (slur);
+
+      if (double_slurs)
+       {
+         set_grob_direction (slur, DOWN);
+         slur = make_spanner ("Slur", events_[START]->self_scm ());
+         set_grob_direction (slur, UP);
+         slurs_.push_back (slur);
+       }
+    }
+  set_melisma (slurs_.size ());
 }
 
 void
 Slur_engraver::stop_translation_timestep ()
 {
-  end_slur_ = 0;
+  end_slurs_.clear ();
   events_[START] = events_[STOP] = 0;
 }
 
-ENTER_DESCRIPTION (Slur_engraver,
-/* descr */       "Build slurs grobs from slur events",
-/* creats*/       "Slur",
-/* accepts */     "slur-event",
-/* acks  */      "note-column-interface accidental-interface fingering-interface script-interface",
-/* reads */       "slurMelismaBusy",
-/* write */       "");
+#include "translator.icc"
+
+ADD_ACKNOWLEDGER (Slur_engraver, accidental);
+ADD_ACKNOWLEDGER (Slur_engraver, dynamic_line_spanner);
+ADD_ACKNOWLEDGER (Slur_engraver, fingering);
+ADD_ACKNOWLEDGER (Slur_engraver, note_column);
+ADD_ACKNOWLEDGER (Slur_engraver, script);
+ADD_ACKNOWLEDGER (Slur_engraver, text_script);
+ADD_ACKNOWLEDGER (Slur_engraver, tie);
+ADD_ACKNOWLEDGER (Slur_engraver, tuplet_number);
+ADD_TRANSLATOR (Slur_engraver,
+               /* doc */ "Build slur grobs from slur events",
+               /* create */ "Slur",
+               /* accept */ "slur-event",
+               /* read */ "slurMelismaBusy doubleSlurs",
+               /* write */ "");