/*
This file is part of LilyPond, the GNU music typesetter.
- Copyright (C) 1997--2011 Han-Wen Nienhuys <hanwen@xs4all.nl>
+ Copyright (C) 1997--2012 Han-Wen Nienhuys <hanwen@xs4all.nl>
LilyPond is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
protected:
DECLARE_TRANSLATOR_LISTENER (phrasing_slur);
- DECLARE_ACKNOWLEDGER (accidental);
+ DECLARE_ACKNOWLEDGER (inline_accidental);
DECLARE_ACKNOWLEDGER (fingering);
DECLARE_ACKNOWLEDGER (note_column);
DECLARE_ACKNOWLEDGER (slur);
DECLARE_ACKNOWLEDGER (script);
+ DECLARE_ACKNOWLEDGER (dots);
DECLARE_ACKNOWLEDGER (text_script);
DECLARE_ACKNOWLEDGER (tie);
DECLARE_ACKNOWLEDGER (tuplet_number);
}
void
-Phrasing_slur_engraver::acknowledge_accidental (Grob_info info)
+Phrasing_slur_engraver::acknowledge_inline_accidental (Grob_info info)
+{
+ acknowledge_extra_object (info);
+}
+
+void
+Phrasing_slur_engraver::acknowledge_dots (Grob_info info)
{
acknowledge_extra_object (info);
}
Stream_event *ev = stop_events_[i];
string id = robust_scm2string (ev->get_property ("spanner-id"), "");
- // Find the slur that is ended with this event (by checking the spanner-id)
+ // Find the slurs that are ended with this event (by checking the spanner-id)
bool ended = false;
for (vsize j = slurs_.size (); j--;)
{
slurs_.erase (slurs_.begin () + j);
}
}
- if (!ended)
+ if (ended)
+ {
+ // Ignore redundant stop events for this id
+ for (vsize j = stop_events_.size (); --j > i;)
+ {
+ if (id == robust_scm2string (stop_events_[j]->get_property ("spanner-id"), ""))
+ stop_events_.erase (stop_events_.begin() + j);
+ }
+ }
+ else
ev->origin ()->warning (_ ("cannot end phrasing slur"));
}
- for (vsize i = 0; i < start_events_.size (); i++)
+ vsize old_slurs = slurs_.size ();
+ for (vsize i = start_events_.size (); i--;)
{
Stream_event *ev = start_events_[i];
string id = robust_scm2string (ev->get_property ("spanner-id"), "");
- bool have_slur = false;
- // Check if we already have a slur with the same spanner-id.
- // In that case, don't create a new slur, but print a warning
- for (vsize i = 0; i < slurs_.size (); i++)
- have_slur = have_slur || (id == robust_scm2string (slurs_[i]->get_property ("spanner-id"), ""));
-
- if (have_slur)
- ev->origin ()->warning (_ ("already have phrasing slur"));
- else
+ Direction updown = to_dir (ev->get_property ("direction"));
+
+ bool completed;
+ for (vsize j = 0; !(completed = (j == slurs_.size ())); j++)
+ {
+ // Check if we already have a slur with the same spanner-id.
+ if (id == robust_scm2string (slurs_[j]->get_property ("spanner-id"), ""))
+ {
+ if (j < old_slurs)
+ {
+ // We already have an old slur, so give a warning
+ // and completely ignore the new slur.
+ ev->origin ()->warning (_ ("already have phrasing slur"));
+ start_events_.erase (start_events_.begin () + i);
+ break;
+ }
+
+ // If this slur event has no direction, it will not
+ // contribute anything new to the existing slur(s), so
+ // we can ignore it. This is not entirely accurate:
+ // tweaks or context properties like those set with
+ // \slurUp can still override a neutral direction, so
+ // when encountering a slur event with "opposite"
+ // direction first, then one with neutral direction, we
+ // only let the "opposite" direction remain, while if
+ // the order is the other way round, a double slur
+ // results since the direction of the first slur is no
+ // longer attributable to a "neutral" slur event. A
+ // mixture of neutral and directed events is nothing
+ // that the partcombiner should crank out, and it would
+ // be decidedly strange for manual input.
+
+ if (!updown)
+ break;
+
+ // If the existing slur does not have a direction yet,
+ // give it ours
+
+ Direction slur_dir = to_dir (slurs_[j]->get_property ("direction"));
+
+ if (!slur_dir)
+ {
+ set_grob_direction (slurs_[j], updown);
+ break;
+ }
+
+ // If the existing slur has the same direction as ours, drop ours
+
+ if (slur_dir == updown)
+ break;
+ }
+ }
+ // If the loop completed, our slur is new
+ if (completed)
{
Grob *slur = make_spanner ("PhrasingSlur", ev->self_scm ());
- Direction updown = to_dir (ev->get_property ("direction"));
slur->set_property ("spanner-id", ly_string2scm (id));
if (updown)
set_grob_direction (slur, updown);
objects_to_acknowledge_.clear ();
}
-ADD_ACKNOWLEDGER (Phrasing_slur_engraver, accidental);
+ADD_ACKNOWLEDGER (Phrasing_slur_engraver, inline_accidental);
ADD_ACKNOWLEDGER (Phrasing_slur_engraver, fingering)
ADD_ACKNOWLEDGER (Phrasing_slur_engraver, note_column);
ADD_ACKNOWLEDGER (Phrasing_slur_engraver, slur);
ADD_ACKNOWLEDGER (Phrasing_slur_engraver, script);
+ADD_ACKNOWLEDGER (Phrasing_slur_engraver, dots);
ADD_ACKNOWLEDGER (Phrasing_slur_engraver, text_script);
ADD_ACKNOWLEDGER (Phrasing_slur_engraver, tie);
ADD_ACKNOWLEDGER (Phrasing_slur_engraver, tuplet_number);
projects / lilypond.git / blobdiff