* Documentation/topdocs/NEWS.tely (Top): add entry for percent

[lilypond.git] / lily / paper-column.cc

diff --git a/lily/paper-column.cc b/lily/paper-column.cc
index 14de60d2dcebd156f0607748ea43beb23c8364e7..ce29a2011a1ce3539f9ec8360087ff8e777c3e23 100644 (file)
--- a/lily/paper-column.cc
+++ b/lily/paper-column.cc
@@ -13,10 +13,12 @@
 #include "warn.hh"
 #include "axis-group-interface.hh"
 #include "spaceable-grob.hh"
-#include "text-item.hh"
+#include "text-interface.hh"
 #include "lookup.hh"
 #include "font-interface.hh"
 #include "output-def.hh"
+#include "pointer-group-interface.hh"
+#include "grob-array.hh"
 
 Grob *
 Paper_column::clone (int count) const
@@ -25,20 +27,27 @@ Paper_column::clone (int count) const
 }
 
 ADD_INTERFACE (Paper_column, "paper-column-interface",
-              "@code{Paper_column} objects form the top-most X-parents for items. "
+              "@code{Paper_column} objects form the top-most X-parents for items."
               "  The are two types of columns: musical columns, where are attached to, and "
               "  non-musical columns, where bar-lines, clefs etc. are attached to. "
               "  The spacing engine determines the X-positions of these objects."
+              
               "\n\n"
               "They are\n"
               "  numbered, the first (leftmost) is column 0. Numbering happens before\n"
               "  line-breaking, and columns are not renumbered after line breaking.\n"
               "  Since many columns go unused, you should only use the rank field to\n"
               "  get ordering information.  Two adjacent columns may have\n"
-              "  non-adjacent numbers.\n"
-              "\n",
-              "between-cols when bounded-by-me "
-              "page-penalty shortest-playing-duration shortest-starter-duration");
+              "  non-adjacent numbers.\n",
+              
+              
+              "between-cols "
+              "bounded-by-me "
+              "page-penalty "
+              "shortest-playing-duration "
+              "shortest-starter-duration "
+              "used "
+              "when ");
 
 void
 Paper_column::do_break_processing ()
@@ -94,17 +103,27 @@ Paper_column::is_musical (Grob *me)
   SCM m = me->get_property ("shortest-starter-duration");
   Moment s (0);
   if (unsmob_moment (m))
-    {
-      s = *unsmob_moment (m);
-    }
+    s = *unsmob_moment (m);
   return s != Moment (0);
 }
 
 bool
 Paper_column::is_used (Grob *me)
 {
-  return scm_is_pair (me->get_property ("elements")) || Item::is_breakable (me)
-    || scm_is_pair (me->get_property ("bounded-by-me"));
+  extract_grob_set (me, "elements", elts);
+  if (elts.size ())
+    return true;
+
+  extract_grob_set (me, "bounded-by-me", bbm);
+  if (bbm.size ())
+    return true;
+  
+  if (Item::is_breakable (me))
+    return true;
+
+  if (to_boolean (me->get_property ("used")))
+    return true;
+  return false;
 }
 
 /*
@@ -118,12 +137,20 @@ Paper_column::print (SCM p)
   Grob *me = unsmob_grob (p);
 
   String r = to_string (Paper_column::get_rank (me));
+
+  Moment *mom = unsmob_moment (me->get_property ("when"));
+  String when = mom ? mom->to_string () : "?/?";
+
   SCM properties = Font_interface::text_font_alist_chain (me);
 
   SCM scm_mol = Text_interface::interpret_markup (me->get_layout ()->self_scm (),
                                                  properties,
                                                  scm_makfrom0str (r.to_str0 ()));
+  SCM when_mol = Text_interface::interpret_markup (me->get_layout ()->self_scm (),
+                                                  properties,
+                                                  scm_makfrom0str (when.to_str0 ()));
   Stencil t = *unsmob_stencil (scm_mol);
+  t.add_at_edge (Y_AXIS, DOWN, *unsmob_stencil (when_mol), 0.1, 0.1);
   t.align_to (X_AXIS, CENTER);
   t.align_to (Y_AXIS, DOWN);
 
@@ -137,7 +164,8 @@ Paper_column::print (SCM p)
 /*
   This is all too hairy. We use bounded-by-me to make sure that some
   columns are kept "alive". Unfortunately, when spanners are suicided,
-  this falls apart again. (sigh.)
+  this falls apart again, because suicided spanners are still in
+  bounded-by-me
 
   THIS IS BROKEN KLUDGE. WE SHOULD INVENT SOMETHING BETTER.
 */
@@ -147,23 +175,22 @@ Paper_column::before_line_breaking (SCM grob)
 {
   Grob *me = unsmob_grob (grob);
 
-  SCM c = me->get_property ("bounded-by-me");
-  SCM *ptrptr = &c;
+  SCM bbm = me->get_object ("bounded-by-me");
+  Grob_array *ga = unsmob_grob_array (bbm);
+  if (!ga)
+    return SCM_UNSPECIFIED;
+
+  Link_array<Grob> &array (ga->array_reference ());
 
-  while (scm_is_pair (*ptrptr))
+  for (int i = array.size (); i--;)
     {
-      Grob *g = unsmob_grob (scm_car (*ptrptr));
+      Grob *g = array[i];
 
       if (!g || !g->is_live ())
-       {
-         *ptrptr = scm_cdr (*ptrptr);
-       }
-      else
-       {
-         ptrptr = SCM_CDRLOC (*ptrptr);
+       {                       // UGH . potentially quadratic.
+         array.del (i);
        }
     }
 
-  me->set_property ("bounded-by-me", c);
   return SCM_UNSPECIFIED;
 }