-
/*
collision.cc -- implement Collision
source file of the GNU LilyPond music typesetter
- (c) 1997--2002 Han-Wen Nienhuys <hanwen@cs.uu.nl>
+ (c) 1997--2004 Han-Wen Nienhuys <hanwen@cs.uu.nl>
*/
-#include "debug.hh"
+#include "warn.hh"
#include "note-collision.hh"
#include "note-column.hh"
#include "note-head.hh"
#include "axis-group-interface.hh"
#include "item.hh"
#include "stem.hh"
+#include "side-position-interface.hh"
+#include "dot-column.hh"
MAKE_SCHEME_CALLBACK (Note_collision_interface,force_shift_callback,2);
me = me->get_parent (a);
- if (! to_boolean (me->get_grob_property ("collision-done")))
+ if (! to_boolean (me->get_grob_property ("positioning-done")))
{
- me->set_grob_property ("collision-done", SCM_BOOL_T);
+ me->set_grob_property ("positioning-done", SCM_BOOL_T);
do_shifts (me);
}
void
-check_meshing_chords (Grob*me,
+check_meshing_chords (Grob *me,
Drul_array< Array < Real > > *offsets,
Drul_array< Array < Slice > > const &extents,
Drul_array<Link_array<Grob> > const &clash_groups)
{
if (!extents[UP].size () || ! extents[DOWN].size ())
- return ;
+ return;
+ Grob *cu = clash_groups[UP][0];
+ Grob *cd = clash_groups[DOWN][0];
+
+ /* Every note column should have a stem, but avoid a crash. */
+ if (!Note_column::get_stem (cu) || !Note_column::get_stem (cd))
+ return;
+
+ Grob *nu = Note_column::first_head (cu);
+ Grob *nd = Note_column::first_head (cd);
+
+ Array<int> ups = Stem::note_head_positions (Note_column::get_stem (cu));
+ Array<int> dps = Stem::note_head_positions (Note_column::get_stem (cd));
+
+ /* Too far apart to collide. */
+ if (ups[0] > dps.top () + 1)
+ return;
+
+ // FIXME: what's this?
+ bool merge_possible = (ups[0] >= dps[0]) && (ups.top () >= dps.top ());
+
+ int upball_type = Note_head::get_balltype (nu);
+ int dnball_type = Note_head::get_balltype (nd);
- Grob *cu =clash_groups[UP][0];
- Grob *cd =clash_groups[DOWN][0];
+ /* Do not merge whole notes (or longer, like breve, longa, maxima). */
+ if (merge_possible && (upball_type <= 0 || dnball_type <= 0))
+ merge_possible = false;
+
+ if (merge_possible
+ && Rhythmic_head::dot_count (nu) != Rhythmic_head::dot_count (nd)
+ && !to_boolean (me->get_grob_property ("merge-differently-dotted")))
+ merge_possible = false;
+
+ /* Can only merge different heads if merge-differently-headed is
+ set. */
+ if (merge_possible
+ && upball_type != dnball_type
+ && !to_boolean (me->get_grob_property ("merge-differently-headed")))
+ merge_possible = false;
+
+ /* Should never merge quarter and half notes, as this would make
+ them indistinguishable. */
+ if (merge_possible
+ && ((Rhythmic_head::duration_log (nu) == 1
+ && Rhythmic_head::duration_log (nd) == 2)
+ || (Rhythmic_head::duration_log (nu) == 2
+ && Rhythmic_head::duration_log (nd) == 1)))
+ merge_possible = false;
- Grob * nu_l= Note_column::first_head (cu);
- Grob * nd_l = Note_column::first_head (cd);
-
-
/*
this case (distant half collide),
*/
- bool close_half_collide = false;
- bool distant_half_collide = false;
- bool full_collide = false;
-
- /*
- TODO:
-
- filter out the 'o's in this configuration, since they're no part
- in the collision.
+ /* TODO: filter out the 'o's in this configuration, since they're no
+ part in the collision.
|
x|o
x|o
x
-
-
- */
- Array<int> ups = Stem::note_head_positions (Note_column::stem_l (cu));
- Array<int> dps = Stem::note_head_positions (Note_column::stem_l (cd));
-
- /*
- they're too far apart to collide.
*/
-
- if (ups[0] > dps.top () + 1)
- return ;
-
- bool touch = (ups[0] - dps.top () >= 0);
- bool merge_possible = (ups[0] >= dps[0]) && (ups.top () >= dps.top ());
-
- /*
- don't merge whole notes (or longer, like breve, longa, maxima)
- */
-
- int upball_type = Note_head::balltype_i (nu_l);
- int dnball_type = Note_head::balltype_i (nd_l);
-
- merge_possible = merge_possible && (upball_type > 0);
-
- if (!to_boolean (me->get_grob_property ("merge-differently-dotted")))
- merge_possible = merge_possible && Rhythmic_head::dot_count (nu_l) == Rhythmic_head::dot_count (nd_l);
-
-
- if (!to_boolean (me->get_grob_property ("merge-differently-headed")))
- merge_possible = merge_possible &&
- upball_type == dnball_type;
- else
- /*
- Can't merge quarter and half notes.
- */
- merge_possible = merge_possible &&
- !((Rhythmic_head::duration_log (nu_l) == 1
- && Rhythmic_head::duration_log (nd_l) == 2)
- ||(Rhythmic_head::duration_log (nu_l) == 2
- && Rhythmic_head::duration_log (nd_l) == 1));
+ bool close_half_collide = false;
+ bool distant_half_collide = false;
+ bool full_collide = false;
int i = 0, j=0;
while (i < ups.size () && j < dps.size ())
Real shift_amount = 1;
+ bool touch = (ups[0] - dps.top () >= 0);
if (touch)
shift_amount *= -1;
- /*
- for full collisions, the right hand head may obscure dots, so
- make sure the dotted heads go to the right.
- */
- if ((Rhythmic_head::dot_count (nu_l) > Rhythmic_head::dot_count (nd_l)
- && full_collide))
+ /* For full collisions, the right hand head may obscure dots, so
+ make sure the dotted heads go to the right. */
+ if (Rhythmic_head::dot_count (nu) > Rhythmic_head::dot_count (nd)
+ && full_collide)
shift_amount = 1;
- /*
- TODO: these numbers are magic; should devise a set of grob props
- to tune this behavior. */
-
if (merge_possible)
{
- shift_amount *= 0.0;
- Grob *wipe_ball = 0;
+ shift_amount = 0;
+
+ /* Wipe shortest head, or head with smallest amount of dots.
+ Note: when merging different heads, dots on shortest
+ disappear. */
- if (upball_type < dnball_type)
- wipe_ball = nd_l;
- else if (upball_type > dnball_type)
- wipe_ball = nu_l;
+ Grob *wipe_ball = nu;
+
+ if (upball_type == dnball_type)
+ {
+ if (Rhythmic_head::dot_count (nd) < Rhythmic_head::dot_count (nu))
+ wipe_ball = nd;
+ }
+ else if (dnball_type > upball_type)
+ wipe_ball = nd;
- if (wipe_ball)
+ if (wipe_ball->live ())
{
wipe_ball->set_grob_property ("transparent", SCM_BOOL_T);
- wipe_ball->set_grob_property ("molecule", SCM_EOL);
+ wipe_ball->set_grob_property ("molecule", SCM_EOL);
+
+ if (Grob *d = unsmob_grob (wipe_ball->get_grob_property ("dot")))
+ d->suicide ();
}
}
+ /* TODO: these numbers are magic; should devise a set of grob props
+ to tune this behavior. */
else if (close_half_collide && !touch)
shift_amount *= 0.52;
else if (distant_half_collide && !touch)
else if (distant_half_collide || close_half_collide || full_collide)
shift_amount *= 0.5;
- /*
- we're meshing.
- */
- else if (Rhythmic_head::dot_count (nu_l) || Rhythmic_head::dot_count (nd_l))
+ /* we're meshing. */
+ else if (Rhythmic_head::dot_count (nu) || Rhythmic_head::dot_count (nd))
shift_amount *= 0.1;
else
shift_amount *= 0.25;
+ /* For full or close half collisions, the right hand head may
+ obscure dots. Move dots to the right. */
+ if (abs (shift_amount) > 1e-6
+ && Rhythmic_head::dot_count (nd) > Rhythmic_head::dot_count (nu)
+ && (full_collide || close_half_collide))
+ {
+ Grob *d = unsmob_grob (nd->get_grob_property ("dot"));
+ Grob *parent = d->get_parent (X_AXIS);
+ if (Dot_column::has_interface (parent))
+ Side_position_interface::add_support (parent, nu);
+ }
+
Direction d = UP;
do
{
Grob * s = unsmob_grob (ly_caar (autos));
Real amount = gh_scm2double (ly_cdar (autos));
- if (!done.find_l (s))
+ if (!done.find (s))
s->translate_axis (amount * wid, X_AXIS);
}
}
{
if (shift[i-1] == shift[i])
{
- me->warning (_ ("Too many clashing notecolumns. Ignoring them."));
+ clashes[0]->warning (_ ("Too many clashing notecolumns. Ignoring them."));
return tups;
}
}
do
{
for (int i=0; i < clash_groups[d].size (); i++)
- tups = gh_cons (gh_cons (clash_groups[d][i]->self_scm (), gh_double2scm (offsets[d][i])),
- tups);
+ tups = gh_cons (gh_cons (clash_groups[d][i]->self_scm (),
+ gh_double2scm (offsets[d][i])),
+ tups);
}
while (flip (&d) != UP);
return tups;
{
Grob * se = unsmob_grob (ly_car (s));
- SCM force = se->remove_grob_property ("force-hshift");
+ SCM force = se->get_grob_property ("force-hshift");
if (gh_number_p (force))
{
tups = gh_cons (gh_cons (se->self_scm (), force),
}
void
-Note_collision_interface::add_column (Grob*me,Grob* ncol_l)
+Note_collision_interface::add_column (Grob*me,Grob* ncol)
{
- ncol_l->add_offset_callback (Note_collision_interface::force_shift_callback_proc, X_AXIS);
- Axis_group_interface::add_element (me, ncol_l);
- me->add_dependency (ncol_l);
+ ncol->add_offset_callback (Note_collision_interface::force_shift_callback_proc, X_AXIS);
+ Axis_group_interface::add_element (me, ncol);
+ me->add_dependency (ncol);
}
ADD_INTERFACE (Note_collision_interface, "note-collision-interface",
- "An object that handles collisions between notes with different stem
-directions and horizontal shifts. Most of the interesting properties
-are to be set in @ref{note-column-interface}: these are
-@code{force-hshift} and @code{horizontal-shift}.
-",
- "merge-differently-dotted merge-differently-headed collision-done");
+ "An object that handles collisions between notes with different stem "
+"directions and horizontal shifts. Most of the interesting properties "
+"are to be set in @ref{note-column-interface}: these are "
+"@code{force-hshift} and @code{horizontal-shift}. ",
+ "merge-differently-dotted merge-differently-headed positioning-done");