(warning): better robustness fix.

[lilypond.git] / lily / grob.cc

diff --git a/lily/grob.cc b/lily/grob.cc
index 883b0ce04608286df841a3881668b3cb7dfe44b3..f11e52a4fc588bbc6e94a0059870508b6907acdf 100644 (file)
--- a/lily/grob.cc
+++ b/lily/grob.cc
@@ -45,7 +45,7 @@ Grob::Grob (SCM basicprops)
   /*
     fixme: default should be no callback.
    */
-
+  self_scm_ = SCM_EOL;
   pscore_=0;
   status_ = 0;
   original_ = 0;
@@ -122,6 +122,8 @@ Grob::Grob (Grob const&s)
    : dim_cache_ (s.dim_cache_)
 {
   original_ = (Grob*) &s;
+  self_scm_ = SCM_EOL;
+
   immutable_property_alist_ = s.immutable_property_alist_;
 
   mutable_property_alist_ = SCM_EOL;
@@ -238,8 +240,11 @@ Grob::get_molecule ()  const
 
   mol =  get_uncached_molecule ();
   
-  Grob *me = (Grob*)this;
-  me->set_grob_property ("molecule", mol);
+  if (live ())
+    {
+      Grob *me = (Grob*)this;
+      me->set_grob_property ("molecule", mol);
+    }
   
   return unsmob_molecule (mol);  
 }
@@ -252,7 +257,6 @@ Grob::get_uncached_molecule ()const
   SCM  mol = SCM_EOL;
   if (gh_procedure_p (proc)) 
     mol = gh_apply (proc, scm_list_n (this->self_scm (), SCM_UNDEFINED));
-
   
   Molecule *m = unsmob_molecule (mol);
   
@@ -260,14 +264,15 @@ Grob::get_uncached_molecule ()const
     {
       SCM origin = ly_symbol2scm ("no-origin");
       
-      if (store_locations_global_b){
-       SCM cause = get_grob_property ("cause");
-       if (Music*m = unsmob_music (cause))
-         {
-           SCM music_origin = m->get_mus_property ("origin");
-           if (unsmob_input (music_origin))
-             origin = music_origin;
-         }
+      if (store_locations_global_b)
+       {
+         SCM cause = get_grob_property ("cause");
+         if (Music*m = unsmob_music (cause))
+           {
+             SCM music_origin = m->get_mus_property ("origin");
+             if (unsmob_input (music_origin))
+               origin = music_origin;
+           }
       }
 
       // ugr.
@@ -319,30 +324,28 @@ Grob::add_dependency (Grob*e)
 void
 Grob::handle_broken_dependencies ()
 {
-  Spanner * s= dynamic_cast<Spanner*> (this);
-  if (original_ && s)
+  Spanner * sp = dynamic_cast<Spanner*> (this);
+  if (original_ && sp)
     return;
 
-  if (s)
+  if (sp)
     {
-      for (int i = 0;  i< s->broken_intos_ .size (); i++)
+      for (SCM s = mutable_property_alist_; gh_pair_p(s);
+          s = gh_cdr(s))
        {
-         Grob * sc = s->broken_intos_[i];
-         System * l = sc->get_system ();
-
-         sc->substitute_mutable_properties (l ? l->self_scm () : SCM_UNDEFINED,
-                                  mutable_property_alist_);
+         sp->substitute_one_mutable_property (gh_caar (s),
+                                             gh_cdar (s));
+         
        }
     }
 
-
   System *system = get_system ();
 
   if (live ()
       && system && common_refpoint (system, X_AXIS) && common_refpoint (system, Y_AXIS))
     {
       substitute_mutable_properties (system ? system->self_scm () : SCM_UNDEFINED,
-                              mutable_property_alist_);
+                                    mutable_property_alist_);
     }
   else if (dynamic_cast <System*> (this))
     {
@@ -371,6 +374,13 @@ Grob::handle_broken_dependencies ()
 void
 Grob::suicide ()
 {
+  if (!live ())
+    return; 
+
+#if 0 // see below. 
+   String nm = name();
+#endif
+  
   mutable_property_alist_ = SCM_EOL;
   immutable_property_alist_ = SCM_EOL;
 
@@ -382,6 +392,19 @@ Grob::suicide ()
       dim_cache_[a].offset_callbacks_ = SCM_EOL;
       dim_cache_[a].offsets_left_ = 0;
     }
+
+#if 0
+  /*
+    This can make debugging a little easier: we can still know what
+    the object used to be. However, since all its links have been
+    broken, it's usually more convenient to set a conditional
+    breakpoint in GDB before the property lists are wiped.
+   */
+  mutable_property_alist_ = scm_acons (ly_symbol2scm ("name"),
+                                      scm_makfrom0str (nm.to_str0()),
+                                      mutable_property_alist_
+                                      );
+#endif
 }
 
 void
@@ -677,9 +700,8 @@ void
 Grob::warning (String s)const
 {
   SCM cause = self_scm();
-  while (cause != SCM_EOL && !unsmob_music (cause))
+  while (Grob * g = unsmob_grob (cause))
     {
-      Grob * g = unsmob_grob (cause);
       cause = g->get_grob_property ("cause");
     }
 
@@ -752,7 +774,7 @@ Grob::print_smob (SCM s, SCM port, scm_print_state *)
 }
 
 SCM
-Grob::do_derived_mark ()
+Grob::do_derived_mark () const
 {
   return SCM_EOL;
 }
@@ -801,7 +823,7 @@ ly_grobs2scm (Link_array<Grob> a)
 }
 
 
-IMPLEMENT_TYPE_P (Grob, "ly-grob?");
+IMPLEMENT_TYPE_P (Grob, "ly:grob?");
 
 ADD_INTERFACE (Grob, "grob-interface",
   "In music notation, lots of symbols are related in some way.  You can