(try_music): add moments for

[lilypond.git] / lily / fingering-engraver.cc

diff --git a/lily/fingering-engraver.cc b/lily/fingering-engraver.cc
index 07df23d08b41b3efb76c422a6b638dd60c52f022..8dbc974b6f0e7d0929bc0ac09f899b44a87554c8 100644 (file)
--- a/lily/fingering-engraver.cc
+++ b/lily/fingering-engraver.cc
@@ -3,7 +3,7 @@
   
   source file of the GNU LilyPond music typesetter
   
-  (c) 1998--2003 Han-Wen Nienhuys <hanwen@cs.uu.nl>
+  (c) 1998--2004 Han-Wen Nienhuys <hanwen@cs.uu.nl>
   
  */
 
@@ -22,7 +22,7 @@ class Fingering_engraver : public Engraver
   Link_array<Item> fingerings_;
 
 public:
-  TRANSLATOR_DECLARATIONS(Fingering_engraver);
+  TRANSLATOR_DECLARATIONS (Fingering_engraver);
 protected:
   virtual bool try_music (Music* m);
   virtual void stop_translation_timestep ();
@@ -30,7 +30,8 @@ protected:
   virtual void process_music ();
   virtual void acknowledge_grob (Grob_info);
 
-  void make_script (Direction, Music*,Axis, int);
+private:
+  void make_script (Direction, Music*, int);
 };
 
 bool
@@ -51,7 +52,7 @@ Fingering_engraver::acknowledge_grob (Grob_info inf)
     {
       for (int i=0; i < fingerings_.size (); i++)
        {
-         Side_position_interface::add_support (fingerings_[i],inf.grob_);
+         Side_position_interface::add_support (fingerings_[i], inf.grob_);
        }
     }
   else if (Rhythmic_head::has_interface (inf.grob_))
@@ -61,7 +62,7 @@ Fingering_engraver::acknowledge_grob (Grob_info inf)
          Grob*t = fingerings_[i];
          Side_position_interface::add_support (t,inf.grob_);
          if (!t->get_parent (X_AXIS))
-               t->set_parent (inf.grob_, X_AXIS);
+           t->set_parent (inf.grob_, X_AXIS);
        }
     }
 }
@@ -69,53 +70,61 @@ Fingering_engraver::acknowledge_grob (Grob_info inf)
 void
 Fingering_engraver::process_music ()
 {
-  for (int i= reqs_.size(); i--;)
+  for (int i= reqs_.size (); i--;)
     {
-      SCM dir = reqs_[i]->get_mus_property ("direction");
-      make_script (to_dir (dir), reqs_[i], Y_AXIS, i);
+      SCM dir = reqs_[i]->get_property ("direction");
+      make_script (to_dir (dir), reqs_[i], i);
     }
 }
 
+
 void
-Fingering_engraver::make_script (Direction d, Music *r,Axis a,  int i)
+Fingering_engraver::make_script (Direction d, Music *r, int i)
 {
-  Item *fingering = new Item (get_property ("Fingering"));
-
+  Item *fingering = make_item ("Fingering", r->self_scm ());
+  Axis a = Y_AXIS;
   Axis other = other_axis (a);
 
-  SCM pitch = r->get_mus_property ("pitch");
+  /*
+    Huh, what's this for? --hwn.
+
+    junkme.
+   */
+  SCM pitch = r->get_property ("pitch");
   if (unsmob_pitch (pitch))
-    fingering->set_grob_property ("pitch", pitch);
-  
+    fingering->set_property ("pitch", pitch);
+
+  /*
+    We can't fold these definitions into define-grobs since
+    fingerings for chords need different settings. 
+  */
   Side_position_interface::set_axis (fingering, a);
-      
   fingering->add_offset_callback (Self_alignment_interface::aligned_on_self_proc, other);
   fingering->add_offset_callback (Self_alignment_interface::centered_on_parent_proc, other);
 
   // Hmm
   int priority = 200;
-  SCM s = fingering->get_grob_property ("script-priority");
-  if (gh_number_p (s))
-    priority = gh_scm2int (s);
+  SCM s = fingering->get_property ("script-priority");
+  if (ly_c_number_p (s))
+    priority = ly_scm2int (s);
   
   /* See script-engraver.cc */
   priority += i;
 
-  fingering->set_grob_property ("script-priority", gh_int2scm (priority));
+  fingering->set_property ("script-priority", scm_int2num (priority));
 
 
-  if (!is_direction (fingering->get_grob_property ("direction")))
+  if (!is_direction (fingering->get_property ("direction")))
     {
       if (d)
-       fingering->set_grob_property ("direction", gh_int2scm (d));
+       fingering->set_property ("direction", scm_int2num (d));
       else
-       fingering->set_grob_property ("direction",  gh_int2scm (RIGHT));
+       fingering->set_property ("direction",  scm_int2num (RIGHT));
     }
 
-  SCM dig =  r->get_mus_property ("digit");
-  fingering->set_grob_property ("text", scm_number_to_string (dig, gh_int2scm (10)));
+  SCM dig =  r->get_property ("digit");
+  fingering->set_property ("text", scm_number_to_string (dig, scm_int2num (10)));
 
-  announce_grob (fingering, r->self_scm());
   fingerings_.push (fingering);
 }
 
@@ -125,12 +134,6 @@ Fingering_engraver::stop_translation_timestep ()
   if (!fingerings_.size ())
     return;
   
-  for (int i=0; i < fingerings_.size (); i++)
-    {
-      Item *ti = fingerings_[i];
-      Side_position_interface::add_staff_support (ti);
-      typeset_grob (ti);
-    }
   fingerings_.clear ();
 }
 
@@ -140,12 +143,12 @@ Fingering_engraver::start_translation_timestep ()
   reqs_.clear ();
 }
 
-Fingering_engraver::Fingering_engraver()
+Fingering_engraver::Fingering_engraver ()
 {
 
 }
 
-ENTER_DESCRIPTION(Fingering_engraver,
+ENTER_DESCRIPTION (Fingering_engraver,
 /* descr */       "Create fingering-scripts",
 /* creats*/       "Fingering",
 /* accepts */     "fingering-event",