2003 -> 2004

[lilypond.git] / lily / chord-tremolo-engraver.cc

diff --git a/lily/chord-tremolo-engraver.cc b/lily/chord-tremolo-engraver.cc
index 8d5f7489403838a9fc0a350312850d93f148c82e..49d62e12de9edcd0d9f0c35577296423be4906c8 100644 (file)
--- a/lily/chord-tremolo-engraver.cc
+++ b/lily/chord-tremolo-engraver.cc
@@ -3,7 +3,7 @@
   
   source file of the GNU LilyPond music typesetter
   
-  (c) 2000--2003 Han-Wen Nienhuys <hanwen@cs.uu.nl>
+  (c) 2000--2004 Han-Wen Nienhuys <hanwen@cs.uu.nl>
   
  */
 
@@ -25,6 +25,7 @@
 #include "math.h"           // ceil
 
 /**
+
   This acknowledges repeated music with "tremolo" style.  It typesets
   a beam.
 
@@ -35,13 +36,13 @@
 
   - create dots if appropriate.
 
-  - create  TremoloBeam iso Beam?
- */
+  - create TremoloBeam iso Beam?
 
+*/
 class Chord_tremolo_engraver : public Engraver
 {
   void typeset_beam ();
-TRANSLATOR_DECLARATIONS(Chord_tremolo_engraver);
+  TRANSLATOR_DECLARATIONS(Chord_tremolo_engraver);
 protected:
   Repeated_music * repeat_;
 
@@ -49,6 +50,8 @@ protected:
   Moment start_mom_;
   Moment stop_mom_;
   int flags_ ;
+  int total_duration_flags_;
+  
   /// location  within measure where beam started.
   Moment beam_start_location_;
 
@@ -92,7 +95,7 @@ Chord_tremolo_engraver::try_music (Music * m)
 
       int elt_count = seq ? scm_ilength (seq-> music_list ()) : 1;
 
-      if (elt_count != 2)
+      if (seq && elt_count != 2)
        {
          rp->origin ()->warning (_f ("Chord tremolo with %d elements. Must have two elements.", elt_count));
        }
@@ -103,15 +106,8 @@ Chord_tremolo_engraver::try_music (Music * m)
       Rational total_dur = l.main_part_;
       Rational note_dur = total_dur / Rational (elt_count * repeat_->repeat_count ());
 
-      if (total_dur < Rational (1,4))
-       {
-         /*
-           This would require beams between flagged (8th) notes.
-         */
-         rp->origin ()->warning ("Chord tremolo is too short to denote properly.");
-       }
+      total_duration_flags_ = 0 >? (intlog2 (total_dur.den ()) - 2);
       
-      Rational written_note_dur = total_dur / Rational (elt_count);
       flags_ = intlog2 (note_dur.den ()) -2 ;
       
       return true;
@@ -127,7 +123,7 @@ Chord_tremolo_engraver::process_music ()
     {
       if (sequential_body_b_ && !beam_)
        {
-         beam_ = new Spanner (get_property ("Beam"));
+         beam_ = make_spanner ("Beam");
          beam_->set_grob_property ("chord-tremolo", SCM_BOOL_T);
 
          SCM smp = get_property ("measurePosition");
@@ -140,7 +136,7 @@ Chord_tremolo_engraver::process_music ()
        {
          if (flags_)
            {
-             stem_tremolo_ = new Item (get_property ("StemTremolo"));
+             stem_tremolo_ = make_item ("StemTremolo");
              announce_grob(stem_tremolo_, repeat_->self_scm());
              stem_tremolo_->set_grob_property ("flag-count",
                                                scm_int2num (flags_));
@@ -169,7 +165,6 @@ Chord_tremolo_engraver::typeset_beam ()
     }
 }
 
-
 void
 Chord_tremolo_engraver::acknowledge_grob (Grob_info info)
 {
@@ -182,12 +177,10 @@ Chord_tremolo_engraver::acknowledge_grob (Grob_info info)
       else
        Stem::set_beaming (s, flags_, LEFT);
          
-      SCM d = s->get_grob_property ("direction");
       if (Stem::duration_log (s) != 1)
        {
-         beam_->set_grob_property ("gap", gh_double2scm (0.8));
+         beam_->set_grob_property ("gap-count", gh_int2scm (flags_ - total_duration_flags_));
        }
-      s->set_grob_property ("direction", d);
 
       if (info.music_cause ()->is_mus_type ("rhythmic-event"))
        {
@@ -216,7 +209,6 @@ Chord_tremolo_engraver::start_translation_timestep ()
   if (beam_ && stop_mom_ == now_mom ())
     {
       finished_beam_ = beam_;
-
       repeat_ = 0;
       beam_ = 0;
     }
@@ -233,7 +225,6 @@ Chord_tremolo_engraver::stop_translation_timestep ()
       typeset_grob (stem_tremolo_);
       stem_tremolo_ = 0;
     }
-  
 }