move print_format out from the list code

diff --git a/bin/wanna-build b/bin/wanna-build
index cd77851dd3520322fad9410cf71c4ad549f4d555..da14a7d0be2c522bc78298cdce2f2dc3e42dc7af 100755 (executable)
--- a/bin/wanna-build
+++ b/bin/wanna-build
@@ -1857,6 +1857,55 @@ sub calculate_prio {
 }
 
 
+sub print_format {
+    my $printfmt = shift;
+    my $pkg = shift;
+    my $var = shift;
+=pod
+Within an format string, the following values are allowed (need to be preceded by %).
+This can be combined to e.g.
+wanna-build --format='wanna-build -A %a --give-back %p_%v' -A mipsel --list=failed
+
+p Package name
+a Architecture
+s Time in this state in full seconds since epoch
+v Package version
+S Package state
+u Builder (e.g. buildd_mipsel-rem)
+X the string normally between [], e.g. optional:out-of-date:calprio{61}:days{25}
+c section (e.g. libs or utils)
+P previous state
+E in case of Dep-Wait the packages being waited on, in case of Needs-Build the number in the queue
+D in case of BD-Uninstallable the reason for the uninstallability
+
+=cut
+    return stringf($printfmt, (
+        'p' => $pkg->{'package'},
+        'a' => $arch,
+        's' => sub { return floor(str2time($pkg->{'state_change'})); },
+        'v' => $pkg->{'version'},
+        'S' => $pkg->{'state'},
+        'u' => $pkg->{'builder'} || "",
+        'X' => sub {
+            my $c = "$pkg->{'priority'}:$pkg->{'notes'}";
+            $c .= ":PREV-FAILED" if $pkg->{'previous_state'} =~ /^Failed/;
+            $c .= ":bp{" . $pkg->{'buildpri'} . "}" if defined $pkg->{'buildpri'};
+            $c .= ":binNMU{" . $pkg->{'binary_nmu_version'} . "}" if defined $pkg->{'binary_nmu_version'};
+            $c .= ":calprio{". $pkg->{'calprio'}."}";
+            $c .= ":days{". $pkg->{'state_days'}."}";
+            return $c;
+            },
+        'c' => $pkg->{'section'},
+        'P' => $pkg->{'previous_state'} || "unknwon",
+        'E' => sub { return $pkg->{'depends'} if $pkg->{'state'} eq "Dep-Wait";
+            return $var->{scnt}{'Needs-Build'} + 1 if $pkg->{'state'} eq 'Needs-Build';
+            return ""; },
+        'D' => sub { return "" unless $pkg->{'bd_problem'};
+            return $pkg->{'package'}."#".$arch."-bd-problem\n".
+            join("\\0a",split("\n",$pkg->{'bd_problem'}))."\\0a\n"; },
+    ));
+}
+
 sub list_packages {
        my $state = shift;
        my( $name, $pkg, @list );
@@ -1872,31 +1921,7 @@ sub list_packages {
 
        foreach $pkg (sort sort_list_func @list) {
                 if ($printformat) {
-                    print stringf($printformat, (
-                        'p' => $pkg->{'package'},
-                        'a' => $arch,
-                        's' => sub { return floor(str2time($pkg->{'state_change'})); },
-                        'v' => $pkg->{'version'},
-                        'S' => $pkg->{'state'},
-                        'u' => $pkg->{'builder'} || "",
-                        'X' => sub {
-                            my $c = "$pkg->{'priority'}:$pkg->{'notes'}";
-                            $c .= ":PREV-FAILED" if $pkg->{'previous_state'} =~ /^Failed/;
-                            $c .= ":bp{" . $pkg->{'buildpri'} . "}" if defined $pkg->{'buildpri'};
-                            $c .= ":binNMU{" . $pkg->{'binary_nmu_version'} . "}" if defined $pkg->{'binary_nmu_version'};
-                            $c .= ":calprio{". $pkg->{'calprio'}."}";
-                            $c .= ":days{". $pkg->{'state_days'}."}";
-                            return $c;
-                            },
-                        'c' => $pkg->{'section'},
-                        'P' => $pkg->{'previous_state'} || "unknwon",
-                        'E' => sub { return $pkg->{'depends'} if $pkg->{'state'} eq "Dep-Wait";
-                            return $scnt{'Needs-Build'} + 1 if $pkg->{'state'} eq 'Needs-Build';
-                            return ""; },
-                        'D' => sub { return "" unless $pkg->{'bd_problem'};
-                            return $pkg->{'package'}."#".$arch."-bd-problem\n".
-                            join("\\0a",split("\n",$pkg->{'bd_problem'}))."\\0a\n"; },
-                    ))."\n";
+                    print print_format($printformat, $pkg, {'cnt' => $cnt, 'scnt' => \%scnt})."\n";
                    ++$cnt;
                    $scnt{$pkg->{'state'}}++;
                     next;