slurm writes output to the same file by default

[uiuc_igb_scripts.git] / dqsub

diff --git a/dqsub b/dqsub
index 5b4b845218a0df6a94fc0793c5f5f07b70d912f5..8620f1f9856e1d41814f776296b293f1f8646b02 100755 (executable)
--- a/dqsub
+++ b/dqsub
@@ -157,7 +157,7 @@ if ($options{interactive} and @ARGV) {
 
 if (not defined $options{batch}) {
     qx/which sbatch/;
-    if ($?) {
+    if ($? == 0) {
         $options{batch} = 'slurm'
     } else {
        $options{batch} = 'pbs'
@@ -192,7 +192,7 @@ if ($options{batch} eq 'pbs') {
 
 if ($options{interactive}) {
     print STDERR 'running: qsub '.join(' ',@qsub_options) if $DEBUG;
-    exec('qsub',@qsub_options);
+    exec($JOB_SUBMITTER,@qsub_options);
 } else {
     my @array = ();
     if ($options{array}) {
@@ -207,6 +207,9 @@ if ($options{interactive}) {
             }
         }
     }
+    if ($options{batch} eq 'pbs') {
+        push @qsub_options,'-';
+    }
     call_qsub(\@qsub_options,write_qsub_script(\%options,\@ARGV,\@array));
 }
 
@@ -257,7 +260,7 @@ sub generate_qsub_options{
     return @qo;
 }
 
-sub generate_slrum_options{
+sub generate_slurm_options{
     my ($options,$args) = @_;
     my @qo;
     if (defined $options->{queue} and length $options->{queue}) {
@@ -279,11 +282,11 @@ sub generate_slrum_options{
         );
     for my $k (keys %options_map) {
         if ($options->{$k}) {
-            push @qo,'--'.$options_map{$k}.'=',$options{$k};
+            push @qo,'--'.$options_map{$k}.'='.$options{$k};
         }
     }
     if ($options{mem}) {
-        push @qo,'--mem=',$options{mem};
+        push @qo,'--mem='.$options{mem};
     }
     if ($options->{interactive}) {
         push @qo,'-I';
@@ -295,10 +298,6 @@ sub generate_slrum_options{
                            map {my $a = $_; $a =~ s/[^a-zA-Z0-9]*//g; $a;}
                           @{$args}[0..min($#{$args},2)]);
     }
-    # join error and output streams
-   if ($options->{join}) {
-        push @qo,'-j','oe';
-    }
     return @qo;
 }
 
@@ -320,7 +319,7 @@ sub read_array_options{
 sub call_qsub {
     my ($qsub_options,$script) = @_;
     my $qsub_fh;
-    open $qsub_fh,'|-',$JOB_SUBMITTER,@{$qsub_options},'-' or
+    open $qsub_fh,'|-',$JOB_SUBMITTER,@{$qsub_options} or
         die "Unable to start $JOB_SUBMITTER: $!";
     print {$qsub_fh} $script or
         die "Unable to print to $JOB_SUBMITTER: $!";