0 is a successful return value from bam_read1(). (In practice, it never

returns 0 anyway; but all the other callers treat 0 as successful.)

diff --git a/bam_index.c b/bam_index.c
index e218a70b66c99591e4eebf0ea3c9e3ac23a3559b..9d819d33aa30677384c2d1bdd97639a206f04003 100644 (file)
--- a/bam_index.c
+++ b/bam_index.c
@@ -674,7 +674,7 @@ int bam_iter_read(bamFile fp, bam_iter_t iter, bam1_t *b)
                        }
                        ++iter->i;
                }
-               if ((ret = bam_read1(fp, b)) > 0) {
+               if ((ret = bam_read1(fp, b)) >= 0) {
                        iter->curr_off = bam_tell(fp);
                        if (b->core.tid != iter->tid || b->core.pos >= iter->end) break; // no need to proceed
                        else if (is_overlap(iter->beg, iter->end, b)) return ret;