Revert "Update build instructions and docker file to download submodules" (#5533)

* Revert "Update build instructions and Dockerfile to download submodules"

This reverts commit 93210547bd1bfbbb1ffd56801bb81af46af350a5.

* Update build tools docs based on feedback

* Fix bad link in build tools docs

diff --git a/Dockerfile b/Dockerfile
index c4acfec71aa5b0e38154ff84eabe37dc6431634d..6bd5acb335736505fc2cb4f400872244c07a8813 100644 (file)
--- a/Dockerfile
+++ b/Dockerfile
@@ -26,4 +26,4 @@ VOLUME /qmk_firmware
 WORKDIR /qmk_firmware
 COPY . .
 
-CMD make clean ; make git-submodule ; make $KEYBOARD:$KEYMAP
+CMD make $KEYBOARD:$KEYMAP

diff --git a/docs/getting_started_build_tools.md b/docs/getting_started_build_tools.md
index b72f52e189e72f79baf6aa004022eb2a537816e7..0e1acca66a8d8f9ace4163774257fb0db708cacc 100644 (file)
--- a/docs/getting_started_build_tools.md
+++ b/docs/getting_started_build_tools.md
@@ -2,11 +2,11 @@
 
 This page describes setting up the build environment for QMK. These instructions cover AVR processors (such as the atmega32u4).
 
-After cloning the repo of QMK run `make git-submodule` once to download 3rd party libraries like ChibiOS.
-
 <!-- FIXME: We should have ARM instructions somewhere. -->
 
-Note: If it is your first time here, Check out the "Complete Newbs guide" instead
+**Note:** If this is your first time here, check out the [Complete Newbs Guide](newbs.md) page.
+
+Before continuing, double check that your submodules (third-party libraries) are up to date by running `make git-submodule`.
 
 ## Linux
 

diff --git a/util/docker_build.sh b/util/docker_build.sh
index 35839ac41eb218a9017de1cf65e584d0c107137c..e7aeac8f3e5f08aa2c23822e8122e14efe93c1f9 100755 (executable)
--- a/util/docker_build.sh
+++ b/util/docker_build.sh
@@ -47,4 +47,4 @@ dir=$(pwd -W 2>/dev/null) || dir=$PWD  # Use Windows path if on Windows
 
 # Run container and build firmware
 docker run --rm -it $usb_args -v "$dir":/qmk_firmware qmkfm/qmk_firmware \
-       /bin/bash -c "make git-submodule; make \"$keyboard${keymap:+:$keymap}${target:+:$target}\""
+       make "$keyboard${keymap:+:$keymap}${target:+:$target}"