]> git.donarmstrong.com Git - qmk_firmware.git/commitdiff
Reference issue #524 from the unit tests
authorFred Sundvik <fsundvik@gmail.com>
Sat, 8 Jul 2017 16:26:47 +0000 (19:26 +0300)
committerJack Humbert <jack.humb@gmail.com>
Sun, 9 Jul 2017 01:59:51 +0000 (21:59 -0400)
tests/basic/test_keypress.cpp

index d85cba44650fc4a98f8e5ce07a9c29ae8d266015..194b1745b125870cd79a87ca4fd9143118fa2812 100644 (file)
@@ -111,6 +111,9 @@ TEST_F(KeyPress, RightShiftLeftControlAndCharWithTheSameKey) {
     press_key(6, 0);
     // BUG: The press is split into two reports
     // BUG: It reports RSFT instead of LSFT
+    // See issue #524 for more information
+    // The underlying cause is that we use only one bit to represent the right hand
+    // modifiers.
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_RSFT, KC_RCTRL)));
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_RSFT, KC_RCTRL, KC_O)));
     keyboard_task();