]> git.donarmstrong.com Git - qmk_firmware.git/commitdiff
move `#include "rgb.h"` from quantum.h to quantum.c
authormtei <2170248+mtei@users.noreply.github.com>
Thu, 10 Jan 2019 03:04:01 +0000 (12:04 +0900)
committerDrashna Jaelre <drashna@live.com>
Fri, 25 Jan 2019 21:38:12 +0000 (13:38 -0800)
I think `quantum.h` should contain only API declarations that `quantum.c` provides externally. `rgb.h` contains function weak definitions. This should not be in `quantum.h`.

quantum/quantum.c
quantum/quantum.h

index 85db100ab4b8ab6059c69936502ad9fa38fc0f99..5d8ffe34eb8f60348cbea131835424dd215b9d8e 100644 (file)
  */
 
 #include "quantum.h"
+
+#if !defined(RGBLIGHT_ENABLE) && !defined(RGB_MATRIX_ENABLE)
+       #include "rgb.h"
+#endif
+
 #ifdef PROTOCOL_LUFA
 #include "outputselect.h"
 #endif
index f78915fdfbc0376b77d7e5473badf28b65322da8..56a6a1a991ada202659d6725759890349f838e55 100644 (file)
@@ -30,9 +30,6 @@
 #ifdef BACKLIGHT_ENABLE
     #include "backlight.h"
 #endif
-#if !defined(RGBLIGHT_ENABLE) && !defined(RGB_MATRIX_ENABLE)
-       #include "rgb.h"
-#endif
 #ifdef RGBLIGHT_ENABLE
   #include "rgblight.h"
 #else