]> git.donarmstrong.com Git - qmk_firmware.git/commitdiff
Fix `quantum/split_common/matrix.c: select_col()/select_row()` (#5174)
authorTakeshi ISHII <2170248+mtei@users.noreply.github.com>
Mon, 18 Feb 2019 21:55:20 +0000 (06:55 +0900)
committerDrashna Jaelre <drashna@live.com>
Mon, 18 Feb 2019 21:55:20 +0000 (13:55 -0800)
* add temporary pdhelix(Patched Helix) code

* add test code into  quantum/split_common/matrix.c

* add test code into keyboards/handwired/pdhelix/

* Revert "add test code into keyboards/handwired/pdhelix/"

This reverts commit 9ed98f0797ddd962c99756689fc4ecb4cd067d3d.

* Revert "add test code into  quantum/split_common/matrix.c"

This reverts commit 1876d3ed69f6c213153a9f6476192be839f16c1f.

* Revert "add temporary pdhelix(Patched Helix) code"

This reverts commit 41ac92b814e3f894eaf85bc3e5bb945895342fa8.

* fix quantum/split_common/matrix.c: select_col()/select_row()

quantum/split_common/matrix.c

index c3d2857ed50bfd9b8894817f88e76b77d305f60c..f2a277c69f3a698de4ecb16220617e264960172c 100644 (file)
@@ -143,8 +143,8 @@ static bool read_cols_on_row(matrix_row_t current_matrix[], uint8_t current_row)
 #elif (DIODE_DIRECTION == COL2ROW)
 
 static void select_row(uint8_t row) {
-  writePinLow(row_pins[row]);
   setPinOutput(row_pins[row]);
+  writePinLow(row_pins[row]);
 }
 
 static void unselect_row(uint8_t row) { setPinInputHigh(row_pins[row]); }
@@ -188,8 +188,8 @@ static bool read_cols_on_row(matrix_row_t current_matrix[], uint8_t current_row)
 #elif (DIODE_DIRECTION == ROW2COL)
 
 static void select_col(uint8_t col) {
-  writePinLow(col_pins[col]);
   setPinOutput(col_pins[col]);
+  writePinLow(col_pins[col]);
 }
 
 static void unselect_col(uint8_t col) { setPinInputHigh(col_pins[col]); }