]> git.donarmstrong.com Git - lilypond.git/log
lilypond.git
9 years agoDoc: NR Fixes mis-ordered menu section for 4.3
James Lowe [Wed, 6 Aug 2014 21:07:49 +0000 (22:07 +0100)]
Doc: NR Fixes mis-ordered menu section for 4.3

Issue 4053

This fixes a mistake introduced in

aec840a735b33a4be38b10baeb40f8e660e3d55c

Where @nodes were moved around but the corresponding
@menu section wasn't altered accordingly.

9 years agoIssue 4039: Improvements to magnifyMusic and magnifyStaff
Mark Polesky [Tue, 22 Jul 2014 10:08:41 +0000 (03:08 -0700)]
Issue 4039: Improvements to magnifyMusic and magnifyStaff

Remove redundant scaling when mag factor = 1.
Scale tablature half-note double-stems.
Scale baseline-skip and word-space props.
Add regtests.

9 years agoIssue 4038: Add text-interface to InstrumentName.
Mark Polesky [Wed, 30 Jul 2014 23:10:11 +0000 (16:10 -0700)]
Issue 4038: Add text-interface to InstrumentName.

9 years agoIssue 4034: Fix some broken commit references.
Mark Polesky [Sun, 27 Jul 2014 22:17:08 +0000 (15:17 -0700)]
Issue 4034: Fix some broken commit references.

9 years agoIssue 4024: Clarify break-align symbols and space-alist args in IR.
Mark Polesky [Fri, 18 Jul 2014 05:19:15 +0000 (22:19 -0700)]
Issue 4024: Clarify break-align symbols and space-alist args in IR.

9 years agoUpdates CG with new script to test LSR files
Phil Holmes [Mon, 4 Aug 2014 15:59:02 +0000 (16:59 +0100)]
Updates CG with new script to test LSR files

9 years agoRelease: bump VERSION.
Phil Holmes [Sun, 3 Aug 2014 21:17:19 +0000 (22:17 +0100)]
Release: bump VERSION.

9 years agoRelease: bump Welcome versions. release/2.19.11-1
Phil Holmes [Sun, 3 Aug 2014 13:26:59 +0000 (14:26 +0100)]
Release: bump Welcome versions.

9 years agoRelease: update news.
Phil Holmes [Sun, 3 Aug 2014 13:26:59 +0000 (14:26 +0100)]
Release: update news.

9 years agoPO: update template.
Phil Holmes [Sun, 3 Aug 2014 13:26:59 +0000 (14:26 +0100)]
PO: update template.

9 years agoCorrect release instructions
Phil Holmes [Sun, 3 Aug 2014 13:26:42 +0000 (14:26 +0100)]
Correct release instructions

9 years agoRelease: bump VERSION_DEVEL.
Phil Holmes [Sun, 3 Aug 2014 13:24:57 +0000 (14:24 +0100)]
Release: bump VERSION_DEVEL.

9 years agoDOC: Easier Editing - Frescobaldi
Colin Campbell [Mon, 28 Jul 2014 02:39:38 +0000 (20:39 -0600)]
DOC: Easier Editing - Frescobaldi

Changed description of Frescobaldi

9 years agoUndocument the Scheme interface to make-simple closure
Keith OHara [Sun, 27 Jul 2014 20:15:18 +0000 (13:15 -0700)]
Undocument the Scheme interface to make-simple closure

in favor of lambdas; issue 3993

9 years agoMerge branch 'issue4032'
David Kastrup [Sat, 2 Aug 2014 14:55:32 +0000 (16:55 +0200)]
Merge branch 'issue4032'

9 years agoManual cleanup after unsmob_xxx -> Xxx:unsmob conversion
David Kastrup [Sun, 27 Jul 2014 14:24:57 +0000 (16:24 +0200)]
Manual cleanup after unsmob_xxx -> Xxx:unsmob conversion

9 years agoReplace remaining uses of unsmob_xxx with Xxx::unsmob
David Kastrup [Sun, 27 Jul 2014 13:21:22 +0000 (15:21 +0200)]
Replace remaining uses of unsmob_xxx with Xxx::unsmob

This runs
sed -i 's/unsmob_\(engraver\|global_context\|input\|item\|music\|paper_score\|performance\|performer\|spanner\|stream_event\)\b/\u\1::unsmob/g' $(git grep -l unsmob_ lily)

as the mechanical part of the conversion.  A separate commit provides
the required definitions.

9 years agoRemove definition of DECLARE_UNSMOB
David Kastrup [Sun, 27 Jul 2014 08:08:27 +0000 (10:08 +0200)]
Remove definition of DECLARE_UNSMOB

9 years agounsmob_pitch -> Pitch::unsmob and related
David Kastrup [Fri, 25 Jul 2014 17:00:42 +0000 (19:00 +0200)]
unsmob_pitch -> Pitch::unsmob and related

This is part of moving away from implementing LilyPond infrastructure
via the C preprocessor rather than C++ features since C++ features tend
to be more transparent to IDEs, debuggers, editors, and newcomers.

sed -i "$(git grep -h DECLARE_UNSMOB|sed 's/.*(\(.*\), \(.*\)).*/s\/unsmob_\2\\b\/\1::unsmob\/g/')" $(git grep -l unsmob_)
sed -i '/^DECLARE_UNSMOB/d' `git grep -l DECLARE_UNSMOB`
git checkout Documentation/misc/CHANGES-1.3

(the changes to the CHANGES file are not useful).

The definition of DECLARE_UNSMOB is removed in a separate commit.

9 years agoRemove unused macros ADD_TYPE_PREDICATE and DECLARE_TYPE_P
David Kastrup [Fri, 25 Jul 2014 16:35:49 +0000 (18:35 +0200)]
Remove unused macros ADD_TYPE_PREDICATE and DECLARE_TYPE_P

9 years agoIssue 4033: All subsequent clef transpositions are marked as optional
David Kastrup [Sun, 27 Jul 2014 16:01:09 +0000 (18:01 +0200)]
Issue 4033: All subsequent clef transpositions are marked as optional

This removes a bug cover-up in scm/parser-clef.scm, implements the
necessary functionality in display-lily-music and adds some regtests
for that functionality.

9 years agoIssue 4035: Some refactoring and cleanup in lily/paper-book.cc
David Kastrup [Sat, 2 Mar 2013 12:33:10 +0000 (13:33 +0100)]
Issue 4035: Some refactoring and cleanup in lily/paper-book.cc

9 years agomakelsr run on snippets from LSR
Phil Holmes [Sat, 2 Aug 2014 10:57:37 +0000 (11:57 +0100)]
makelsr run on snippets from LSR

9 years agoPhase two of pruning snippets/new
Phil Holmes [Mon, 28 Jul 2014 13:57:13 +0000 (14:57 +0100)]
Phase two of pruning snippets/new

9 years agoDoc: Appendix - Articulations and Ornamentation - part 2
James Lowe [Tue, 15 Jul 2014 21:21:10 +0000 (22:21 +0100)]
Doc: Appendix - Articulations and Ornamentation - part 2

Issue 1189

Create Texifo @multitable entries for the
List of Articulations appendix.

As there are a lot of separate scripts being
documented this Issue is going to be split
into multiple, smaller, parts to aid in the
review process. Part 1 was commit 8553021

This is part 2 and covers 'Fermata', 'Instrument
specific', 'Repeat signs' and 'Ancient' scripts.

Also, after more consideration, a third example
of each script has been added to show the
explicit differences between the up/down/neutral
positions. Not every script has a different
up/down glyph nor is positioned up/down when
placed on a note that is either top or bottom of
the Staff without explicit positioning. So this,
I hope just clarifies things (regardless whether
the position is musically 'correct' notation).

I have also sey the @code{} script examples into
the same column as the @lilypond examples; saving
a significant of wasted page space. Also I have
removed unnecessary lilypond-book variables making
the texinfo code less noisy.

9 years agoMerge branch 'translation'
David Kastrup [Wed, 30 Jul 2014 15:43:00 +0000 (17:43 +0200)]
Merge branch 'translation'

9 years agoMerge remote-tracking branch 'origin/master' into translation
David Kastrup [Wed, 30 Jul 2014 15:37:14 +0000 (17:37 +0200)]
Merge remote-tracking branch 'origin/master' into translation

9 years agoMake list of `non-staff lines' easier to find in IR.
Mark Polesky [Tue, 22 Jul 2014 19:29:45 +0000 (12:29 -0700)]
Make list of `non-staff lines' easier to find in IR.

Linking from the NR to the Axis_group_engraver IR entry
directs the reader to the list of staff contexts and
`non-staff line' contexts.

9 years agoRemove warning when there are no noteheads to attach lyrics to.
Janek Warchoł [Sat, 26 Jul 2014 07:00:39 +0000 (09:00 +0200)]
Remove warning when there are no noteheads to attach lyrics to.

The warning was added to address issue 248, but it is now moot after
issue 3254 (c73b41b3e7be6d7): attaching lyrics to a note-less context
(like Devnull) is perfectly legal now.

9 years agoIssue 4021: Remove obsolete restrictions from define-*-function docstrings
David Kastrup [Sun, 20 Jul 2014 18:30:36 +0000 (20:30 +0200)]
Issue 4021: Remove obsolete restrictions from define-*-function docstrings

9 years agoIssue 4019: binding-offset not properly scaled along with paper size
David Kastrup [Sun, 20 Jul 2014 11:56:51 +0000 (13:56 +0200)]
Issue 4019: binding-offset not properly scaled along with paper size

This will unfortunately affect all previous uses of binding-offset which
likely were employed using trial-and-error.

9 years agoDoc: NR - Pitches.itely - dodecaphonic-no-repeat text alt
James Lowe [Mon, 21 Jul 2014 07:12:56 +0000 (08:12 +0100)]
Doc: NR - Pitches.itely - dodecaphonic-no-repeat text alt

Issue 4023

Came out of issue 3992

Corrected wording for dodecaphonic-no-repeat
accidental style.

9 years agoCG: Update of Patchy instructions
James Lowe [Sat, 12 Jul 2014 21:41:57 +0000 (22:41 +0100)]
CG: Update of Patchy instructions

Issue 4013

Added fuller explanatory information regarding Patchy.

9 years agoIssue 4005: Set X-parent of TextScript to NoteColumn instead of PaperColumn
Janek Warchoł [Sun, 29 Jun 2014 16:25:04 +0000 (18:25 +0200)]
Issue 4005: Set X-parent of TextScript to NoteColumn instead of PaperColumn

This makes TextScripts consistent with DynamicTexts and LyricTexts.
This is a follow-up to commit 59a842eba0f7ad78289a58a (Issue 2245).

Setting TextScript.cross-staff property to #f is required to ensure
that there are no collisions between TextScripts and cross-staff notes:

\context PianoStaff <<
  \new Staff = "up" {
    b8[
    \change Staff="down"
    d'] ^"text"
  }
  \new Staff = "down" {
    \clef bass
    s4
  }
>>

(see also beam-cross-staff-auto-knee.ly)

As far as I can see, we don't want TextScript.cross-staff to be true
in any situation, because it would result in unwanted collisions.

Why it worked before: cross-staff property in this example evaluated to #f,
but only because of a bug in Script_interface::calc_cross_staff.  That
function should have marked the TextScript as cross-staff if the stem
of the note to which TextScript was attached was cross-staff, but it
didn't work correctly because it expected the parent of the TextScript
to be a NoteColumn, while it actually was a PaperColumn.  When I changed
the parent to be a NoteColumn, the function started working correctly
and marked the TextScript as cross-staff, so I had to change the default
value of the property.

9 years agoImport snippets from LSR and delete initial batch in snippets/new
Phil Holmes [Thu, 24 Jul 2014 14:17:57 +0000 (15:17 +0100)]
Import snippets from LSR and delete initial batch in snippets/new

9 years agoFix ly:make-stream-event to receive a symbol list rather than a symbol as event class
David Kastrup [Sun, 13 Jul 2014 11:02:18 +0000 (13:02 +0200)]
Fix ly:make-stream-event to receive a symbol list rather than a symbol as event class

9 years agoIssue 4007: Fix parts of apparently dead code make-stream-event
David Kastrup [Sun, 13 Jul 2014 10:40:26 +0000 (12:40 +0200)]
Issue 4007: Fix parts of apparently dead code make-stream-event

It is not clear whether the code will be operative for its intended purpose
afterwards, but leaving it in broken state is not going to help.

9 years agotypo/oversight in align-interface.cc and page-layout-problem.cc
Thomas Morley [Sun, 13 Jul 2014 11:45:03 +0000 (13:45 +0200)]
typo/oversight in align-interface.cc and page-layout-problem.cc

issue 4008

fix oversight in doc-string of align-interface.cc
fix typo in comment of page-layout-problem.cc

9 years agoIssue 4017: Define spacing from KeyCancellation to custos
Mark Polesky [Thu, 17 Jul 2014 20:09:32 +0000 (13:09 -0700)]
Issue 4017: Define spacing from KeyCancellation to custos

Adds a space-alist rule from KeyCancellation to custos
to prevent "No spacing entry" programming error.

9 years agoIssue 4015: Add \magnifyStaff.
Mark Polesky [Tue, 15 Jul 2014 19:34:15 +0000 (12:34 -0700)]
Issue 4015: Add \magnifyStaff.

* Add \magnifyStaff.
* Rewrite parts of the \magnifyMusic function so that it can share
  some scheme code with the new \magnifyStaff function.
* Add regtests.
* Update documentation.

9 years agoDon't call Pitch::Pitch with more arguments than necessary.
David Kastrup [Tue, 24 Jun 2014 10:56:22 +0000 (12:56 +0200)]
Don't call Pitch::Pitch with more arguments than necessary.

9 years agoPitch::Pitch (int, int) is declared but not defined
David Kastrup [Tue, 24 Jun 2014 18:48:15 +0000 (20:48 +0200)]
Pitch::Pitch (int, int) is declared but not defined

This caters for the definition by making the last argument of
Pitch::Pitch (int, int, Rational) a default argument.

9 years agoMerge branch 'dev/dodecaphonic_no_repeat' into staging
David Nalesnik [Fri, 18 Jul 2014 22:49:39 +0000 (17:49 -0500)]
Merge branch 'dev/dodecaphonic_no_repeat' into staging

9 years agoIssue 3992: Fix dodecaphonic-no-repeat
David Nalesnik [Sun, 6 Jul 2014 01:01:40 +0000 (20:01 -0500)]
Issue 3992: Fix dodecaphonic-no-repeat

Incorporate renaming of localKeySignature to localAlterations.

The function dodecaphonic-no-repeat-rule now considers alterations.

A pitch which overlaps the same pitch begun earlier should not
receive an accidental.

Improvement to code comments.

Improve code formatting.

9 years agoIssue 3999: Make tablature half-note stem-spacing adjustable.
Mark Polesky [Wed, 9 Jul 2014 00:04:25 +0000 (17:04 -0700)]
Issue 3999: Make tablature half-note stem-spacing adjustable.

This adds a new property to the Stem grob called
'double-stem-separation (default=0.5), that allows users to adjust
the space between the double-stemmed half-notes in tablature:

\new TabStaff {
  \tabFullNotation
  c4 c2 c4
  \override Stem.double-stem-separation = 0.3
  c4 c2 c4
}

It also centers the stems on the fret number and adjusts the
X-extent accordingly.

9 years agoIssue 3995: Rename 'thin-kern to 'segno-kern.
Mark Polesky [Fri, 11 Jul 2014 09:16:03 +0000 (02:16 -0700)]
Issue 3995: Rename 'thin-kern to 'segno-kern.

9 years agoIssue 3994: Fix typo `dash-details' => `dash-definition'.
Mark Polesky [Sun, 6 Jul 2014 04:17:24 +0000 (21:17 -0700)]
Issue 3994: Fix typo `dash-details' => `dash-definition'.

Fix typo in the docs and translated .po files.
Also fix some whitespace errors.

9 years agoIssue 3952: Automatically sort props within each grob-interface.
Mark Polesky [Fri, 11 Jul 2014 07:16:46 +0000 (00:16 -0700)]
Issue 3952: Automatically sort props within each grob-interface.

Ensures that "User settable properties" and "Internal properties"
are listed in sorted order in the "Graphical Object Interfaces"
section of the IR.

This was originally pushed with commit 84f0776,
but was accidentally reverted with commit 0ea80a5.

9 years agoRun scripts/auxilar/makelsr.py
David Kastrup [Fri, 18 Jul 2014 13:44:43 +0000 (15:44 +0200)]
Run scripts/auxilar/makelsr.py

9 years agoIssue 3998: Let "Mars" example in pitch snippets use isolated durations
David Kastrup [Tue, 8 Jul 2014 09:04:19 +0000 (11:04 +0200)]
Issue 3998: Let "Mars" example in pitch snippets use isolated durations

This is one example quite benefitting from issue 3648.  One somewhat
incidental boon is that it would now work in relative mode without
requiring the make-relative macro.

9 years agoRevert "Change dsi to di in LSR address; update version"
David Kastrup [Fri, 18 Jul 2014 12:50:35 +0000 (14:50 +0200)]
Revert "Change dsi to di in LSR address; update version"

This reverts commit 4ee99b07605942b02e82c6526df98b68cbc03981.

9 years agoNR: Adapt docs for inversions in chordmode
David Kastrup [Thu, 10 Jul 2014 13:18:38 +0000 (15:18 +0200)]
NR: Adapt docs for inversions in chordmode

9 years agoIssue 2617: simple chord inversions take 2 octaves
David Kastrup [Wed, 9 Jul 2014 15:31:11 +0000 (17:31 +0200)]
Issue 2617: simple chord inversions take 2 octaves

With this change, chord inversions transpose all notes following the
inversion from the original chord down along with the inversion, as long
as the result ends up below the root note of the uninverted chord.

So with \chordmode { c:11 } => < c' e' g' bes' d'' f'' >
we get \chordmode { c:11/e } => < e g bes c' d'' f'' >

In order to have the Chord_name_engraver reconstruct the correct
uninverted chord, all the additionally octavated note events are given
an octavation property like the inversion event itself.

An "inversion" on the chord root just transposes the chord root one
octave down, leaving the rest in place.

9 years agoIssue 4001: Fix doc string of ly:pitch-diff
David Kastrup [Wed, 9 Jul 2014 15:47:09 +0000 (17:47 +0200)]
Issue 4001: Fix doc string of ly:pitch-diff

The documentation of ly:pitch-diff has got the sign wrong like forever.

9 years agoIssue 4003: NR: warning for { \chordmode { c } c } obsoleted by issue 3797
David Kastrup [Thu, 10 Jul 2014 13:30:08 +0000 (15:30 +0200)]
Issue 4003: NR: warning for { \chordmode { c } c } obsoleted by issue 3797

9 years agoIssue 4009: \retrograde fails on slurs
David Kastrup [Sun, 13 Jul 2014 13:30:03 +0000 (15:30 +0200)]
Issue 4009: \retrograde fails on slurs

The section "Retrograde" in the Notation Reference is affected.
This became likely exposed with issue 2240; the corresponding
regtest does not cover it.  The problem was existent previously
for slurs and other spans inside of chords.

9 years agoAdd slur to modal-transform regtest motif
David Kastrup [Sun, 13 Jul 2014 13:31:27 +0000 (15:31 +0200)]
Add slur to modal-transform regtest motif

9 years agoChange dsi to di in LSR address; update version
Phil Holmes [Thu, 17 Jul 2014 10:38:09 +0000 (11:38 +0100)]
Change dsi to di in LSR address; update version

9 years agoMention backslash escaping in Scheme.
Mark Polesky [Wed, 9 Jul 2014 21:40:31 +0000 (14:40 -0700)]
Mention backslash escaping in Scheme.

Clarify confusion about `@code{\foo}' vs. `@code{\\foo}'.

9 years agoDoc: Appendix - Articulations and Ornamentation - part 1
James Lowe [Wed, 9 Jul 2014 19:13:24 +0000 (20:13 +0100)]
Doc: Appendix - Articulations and Ornamentation - part 1

Issue 1189

Create Texifo @multitable entries for the
List of Articulations appendix.

As there are a lot of separate scripts being
documented this Issue is going to be split
into multiple, smaller, parts to aid in the
review process.

This is part 1 and covers 'Articulation' and
'Ornament' scripts only.

9 years agoChanges.tely updated - 2.19.x up to June 2014
James Lowe [Sun, 22 Jun 2014 14:17:06 +0000 (15:17 +0100)]
Changes.tely updated - 2.19.x up to June 2014

Issue 3965

Since Feb 17th 2014.

Added Tracker issues
2752, 3937, 3913 and 3860

Included @lilypond examples where appropriate

9 years agoDoc:NR Appendix - Clef Styles - added G2 and modernTab Clefs
James Lowe [Fri, 4 Jul 2014 05:35:06 +0000 (06:35 +0100)]
Doc:NR Appendix - Clef Styles - added G2 and modernTab Clefs

Issue 3988

Added two Clefs to notation-appendices.itely - Clef Styles

\clef "G2" and \clef moderntab

Removed excessive brackets in the @lilypond constructions and
updated the '\clef tab' entry so that it engraves correct out
put by adding a \new TabStaff block in the @lilypond example.

9 years agoIssue 4004: NR: remove a few warnings that do not apply any more
David Kastrup [Thu, 10 Jul 2014 18:22:05 +0000 (20:22 +0200)]
Issue 4004: NR: remove a few warnings that do not apply any more

9 years agoIssue 4000: NR: Non-working multi-staff beatStructure override example
David Kastrup [Wed, 9 Jul 2014 10:50:02 +0000 (12:50 +0200)]
Issue 4000: NR: Non-working multi-staff beatStructure override example

9 years agoDon't depend on features removed in Guile 2.1. (issue 3972)
Devon Schudy [Wed, 25 Jun 2014 00:55:44 +0000 (20:55 -0400)]
Don't depend on features removed in Guile 2.1. (issue 3972)

* Replace scm_listify with scm_list_*. (It's been deprecated for a long time.)
* Use scm_protects only when available (Guile versions <2.1).

9 years agoRelease: bump VERSION.
Phil Holmes [Sun, 13 Jul 2014 21:45:22 +0000 (22:45 +0100)]
Release: bump VERSION.

9 years agoMerge remote branch 'origin/release/unstable' into HEAD
Phil Holmes [Sun, 13 Jul 2014 21:44:02 +0000 (22:44 +0100)]
Merge remote branch 'origin/release/unstable' into HEAD

9 years agoRelease: bump Welcome versions. release/2.19.10-1
Phil Holmes [Sun, 13 Jul 2014 14:42:40 +0000 (15:42 +0100)]
Release: bump Welcome versions.

9 years agoRelease: update news.
Phil Holmes [Sun, 13 Jul 2014 14:42:39 +0000 (15:42 +0100)]
Release: update news.

9 years agoPO: update template.
Phil Holmes [Sun, 13 Jul 2014 14:42:39 +0000 (15:42 +0100)]
PO: update template.

9 years agoRelease: bump VERSION_DEVEL.
Phil Holmes [Sun, 13 Jul 2014 14:42:38 +0000 (15:42 +0100)]
Release: bump VERSION_DEVEL.

9 years agoDoc-fr: updates texidocs
Jean-Charles Malahieude [Sun, 13 Jul 2014 14:16:24 +0000 (16:16 +0200)]
Doc-fr: updates texidocs

9 years agoUpdates to GUB build instructions in CG
Phil Holmes [Sun, 13 Jul 2014 13:04:19 +0000 (14:04 +0100)]
Updates to GUB build instructions in CG

9 years agoIssue 3996: Clarify 'thickness and 'line-thickness property docstrings.
Mark Polesky [Fri, 11 Jul 2014 06:33:17 +0000 (23:33 -0700)]
Issue 3996: Clarify 'thickness and 'line-thickness property docstrings.

9 years agoIssue 3997: \magnifyMusic: don't modify nested properties.
Mark Polesky [Fri, 11 Jul 2014 06:11:16 +0000 (23:11 -0700)]
Issue 3997: \magnifyMusic: don't modify nested properties.

Also reformat Scheme code.

9 years agoIssue 3991: \magnifyMusic: surrender to issues 3987 and 3990.
Mark Polesky [Fri, 11 Jul 2014 06:03:06 +0000 (23:03 -0700)]
Issue 3991: \magnifyMusic: surrender to issues 3987 and 3990.

Until issues 3987 and 3990 are fixed, automatic scaling
of horizontal spacing with \magnifyMusic is broken.  This
patch turns the feature off, and adds a note in the docs.

9 years agoIssue 3958: Give examples of \applyContext usage.
Mark Polesky [Fri, 11 Jul 2014 05:39:34 +0000 (22:39 -0700)]
Issue 3958: Give examples of \applyContext usage.

9 years agoIssue 2462: don't change ideal spacing when adding a rod
Janek Warchoł [Mon, 30 Jun 2014 20:14:16 +0000 (22:14 +0200)]
Issue 2462: don't change ideal spacing when adding a rod

When objects like lyrics are added to the PaperColumns, LilyPond inserts
rods between these columns to ensure that the objects won't overlap.
However, the ideal distance should remain unchanged.  For example, in

\layout {
  ragged-right = ##f
}
\relative f' { \repeat unfold 8 a4 }
\addlyrics { \repeat unfold 4 la \repeat unfold 4 straight }

notes in 2nd measure have long lyrics attached to them - min_distance_
of the springs between these columns should be adjusted, but distance_
(the ideal distance) should not: it should be the same as for notes
with short lyrics.  When the line is stretched so much that the minimum
distances are not involved, the springs between notes in both measures
should behave (almost) identical.

Note that there are more such problems in the springs code, for example
in merge_springs.  The code should be rewritten, but that's not trivial.
Since this one-liner fixes some instances of the problem without any bad
side-effects, it makes sense to include it separately.

9 years agodoc: update make-simple-closure example in Extending (Issue 3993)
Janek Warchoł [Thu, 10 Jul 2014 19:59:56 +0000 (21:59 +0200)]
doc: update make-simple-closure example in Extending (Issue 3993)

After improvements in Self_alignment_interface::aligned_on_parent
(in particular after fixing issue 3254) it was possible to simplify
default X-offset values for several grobs, so that they didn't have
to use make-simple-closure (see e.g. commit 1d765020f8679958). This
made an example in Extending 2.7 obsolete, so I'm replacing it with
one that still uses make-simple-closure.

9 years agoRevert "Doc: Appendix - Articulations and Ornamentation - part 1"
James Lowe [Fri, 11 Jul 2014 05:18:33 +0000 (06:18 +0100)]
Revert "Doc: Appendix - Articulations and Ornamentation - part 1"

This reverts commit 0cf0757b026ea6d7435a9cd837019291c6dee3d6.

Pushed by mistake. This checkin is still under review.

My apologies

9 years agoDoc: Updated Roadmap file
James Lowe [Sun, 22 Jun 2014 13:24:17 +0000 (14:24 +0100)]
Doc: Updated Roadmap file

Issue 3963

Added new Catalan translation

Updated existing descriptions for previous entries
including minor formatting changes.

9 years agoDoc: Appendix - Articulations and Ornamentation - part 1
James Lowe [Wed, 9 Jul 2014 19:13:24 +0000 (20:13 +0100)]
Doc: Appendix - Articulations and Ornamentation - part 1

Issue 1189

Create Texifo @multitable entries for the
List of Articulations appendix.

As there are a lot of separate scripts being
documented this Issue is going to be split
into multiple, smaller, parts to aid in the
review process.

This is part 1 and covers 'Articulation' and
'Ornament' scripts only.

9 years agoIssue 2245: always align dynamics and lyrics on "main" notehead
Janek Warchoł [Wed, 27 Mar 2013 16:20:03 +0000 (17:20 +0100)]
Issue 2245: always align dynamics and lyrics on "main" notehead

Until now, LyricTexts and DynamicTexts had their X-parents set to
the first NoteHead in the NoteColumn.  This resulted in inconsistent
alignment - placement of lyrics and dynamics depended on the order
of notes in the input:

% this was aligned differently
{ <f' g'>1\p <g' f'>\p }
\addlyrics { la la }

By using NoteColumns themselves as the X-parents, we make sure that
the input order won't matter.  Since the NoteColumn contains all NoteHeads
(including suspended ones, which usually should be ignored when aligning),
as well as Flags and some other objects, we cannot use its X-extent directly -
instead, we add a function for calculating X-extent of the "main" part of the
NoteColumn, i.e. X-extent of the non-suspended NoteHeads (represented by the
NoteHead furthest away from the stem).

9 years agoDoc: NR 1.2.1 - Tuplets add examples ...Up, ...Down & ...Neutral
James Lowe [Tue, 1 Jul 2014 21:08:55 +0000 (22:08 +0100)]
Doc: NR 1.2.1 - Tuplets add examples ...Up, ...Down & ...Neutral

Issue 3956

Added example showing the \tupletUp, \tupletDown and \tupletNeutral
@lilypond example.

The commands were mentioned in the @predefined and @funindex but
not actually illustrated with an @lilypond example.

9 years agoDoc: NR 4.5.4 Change Node name from 'Line length' to 'Line width'
James Lowe [Tue, 1 Jul 2014 20:32:09 +0000 (21:32 +0100)]
Doc: NR 4.5.4 Change Node name from 'Line length' to 'Line width'

Issue 3982

Change Node name from 'Line length' to 'Line width'.

In the Notation Reference, this page is called
"Line length" but the property that it covers
(among others) is called "line-width."  Seems like
it would be better if the title of the page was
renamed "Line width" for greater consistency.

9 years agoIssue 3984: Let \parallelMusic cope with \repeat .. \alternative
David Kastrup [Wed, 2 Jul 2014 09:56:27 +0000 (11:56 +0200)]
Issue 3984: Let \parallelMusic cope with \repeat .. \alternative

\parallelMusic's recursive decent only worked for comparatively simple
cases.  It now should be able to deal with complex constructs
gracefully.

9 years agoIssue 3986: \displayScheme broken
David Kastrup [Thu, 3 Jul 2014 08:22:37 +0000 (10:22 +0200)]
Issue 3986: \displayScheme broken

    \displayScheme \markup \null

failed because a markup following an omitted optional argument (here the
optional output port) was backed up erroneously with the token type
LYRIC_ELEMENT only to be used in lyrics mode.

The optional argument was introduced with issue 2067 in version 2.19.0.
The actual underlying parser error triggered by this, however, is quite
older and originates from

    commit d4694123961690b173377b3c3a199d5a24c66a9d
    Author: David Kastrup <dak@gnu.org>
    Date:   Thu Nov 1 15:16:52 2012 +0100

parser/lexer: eliminate LYRIC_MARKUP as a token separate from MARKUP (2996/2)

in version 2.17.9.

9 years agoIssue 3983: Avoid define-public and define*-public with curried definitions
David Kastrup [Thu, 5 Jun 2014 18:34:14 +0000 (20:34 +0200)]
Issue 3983: Avoid define-public and define*-public with curried definitions

Regarding curried definitions, GUILE has problems with define-public
before version 2.0.10, and with define*-public even later.

define-safe-public is implemented by LilyPond itself rather than the
(ice-9 curried-definitions) module and is unproblematic.

This is basically a cop-out since juggling with overriding bugfix
definitions of define-public is a distraction for getting GUILEv2
migration under way that we can do without.

9 years agoDoc-fr: updates texidocs
Jean-Charles Malahieude [Sun, 6 Jul 2014 10:31:19 +0000 (12:31 +0200)]
Doc-fr: updates texidocs

9 years agoIssue 3942: Scale slurs and ties when using \magnifyMusic.
Mark Polesky [Sun, 6 Jul 2014 08:11:35 +0000 (01:11 -0700)]
Issue 3942: Scale slurs and ties when using \magnifyMusic.

9 years agoIssue 3978: Merge alignment cleanup
Janek Warchoł [Sat, 5 Jul 2014 21:11:40 +0000 (23:11 +0200)]
Issue 3978: Merge alignment cleanup

Make DynamicTexts, TextScripts and many other grobs use aligned_on_parent,
which makes their behaviour consitent, predictable and thus more user-friendly.

9 years agodefine-grobs.scm: reorder properties alphabetically
Janek Warchoł [Fri, 4 Jul 2014 20:42:08 +0000 (22:42 +0200)]
define-grobs.scm: reorder properties alphabetically

9 years agoTextScript, CombineTextScript: use aligned_on_parent
Janek Warchoł [Mon, 23 Jun 2014 21:30:49 +0000 (23:30 +0200)]
TextScript, CombineTextScript: use aligned_on_parent

I think this makes more sense than just using "self-alignment".
It makes these grobs consistent with Lyrics and Dynamics, and
allows users to override their alignment more predictably.

Expected changes in output: TextScripts and CombineTextScripts
will be aligned slightly different when the user sets self-alignment-X
explicitly (parent notehead will be included in alignment, as in Lyrics).
Default placement should remain the same.

I'm also changing one regtest, just to make sure that despite slightly
changed alignment the markups will stick out far enough to the left.

9 years agoReplace XY-offset closures with aligned_on_parent where possible
Janek Warchoł [Mon, 23 Jun 2014 21:04:26 +0000 (23:04 +0200)]
Replace XY-offset closures with aligned_on_parent where possible

It doesn't make sense to specify placement using multiple added
callbacks or closures when we can use aligned_on_parent. What's
more, aligned_on_parent should expose more consistent interface
for the users - affected grobs should now behave similarly to
LyricTexts and DynamicTexts. For example, this

\relative c'' \context Voice {
  \compressFullBarRests
  \override MultiMeasureRestNumber.self-alignment-X = #RIGHT
  R1*100
}

will result in right edge of the MultiMeasureRestNumber being
aligned on the right edge of the MultiMeasureRest.

Affected grobs:
- AccidentalSuggestion
- ClefModifier
- DoublePercentRepeatCounter
- Fingering
- GridLine
- MultiMeasureRestNumber
- MultiMeasureRestText
- PercentRepeatCounter
- StemTremolo

Expected changes in output: none.

9 years agoClean up DynamicText horizontal alignment.
Janek Warchoł [Fri, 29 Mar 2013 23:11:28 +0000 (00:11 +0100)]
Clean up DynamicText horizontal alignment.

Until now, DynamicText alignment was messy, as there were 3 different
callbacks involved - some of them interacting in a confusing way:
 - in define-grobs.scm, X-offset property was initialized to
   ly:self-alignment-interface::x-aligned-on-self,
 - Dynamic_engraver called set_center_parent on every DynamicText
   attached to a note, so that half a NoteHead width was always added
   to its X-offset (producing confusing results for example when
   user requested dynamics to be left-aligned),
 - DynamicTexts living in a Dynamics context used a completely
   different offset callback, which aligned them on NoteColumns.

Since aligned_on_parent is now able to correctly align grobs
with PaperColumn parents (issue 3254), we can use it for all
DynamicTexts and have a single interface for the job.

Expected changes in output: DynamicTexts in Dynamics context
aligned to suspended noteheads may be placed up to 1/4 NoteHead
width further to the right.  This shouldn't be a problem.

9 years agoDoc-fr: updates to NR
Jean-Charles Malahieude [Sat, 5 Jul 2014 18:14:01 +0000 (20:14 +0200)]
Doc-fr: updates to NR

9 years agoReg Tests: XML 02a fix incorrect last note duration
Patrick Schmidt [Sat, 28 Jun 2014 20:09:34 +0000 (21:09 +0100)]
Reg Tests: XML 02a fix incorrect last note duration

Issue 3974

Unofficial MusicXML test suite shows incorrect last not duration
the last note was duration 2 (undotted 64th) but shows dotted 128th

Added some missing <type> elements
Corrected the durations of the last measure

Fixes provided by Patrick Schmidt

9 years agoReg Tests: XML 01b has an incorrect number of measures
Patrick Schmidt [Sat, 28 Jun 2014 20:24:23 +0000 (21:24 +0100)]
Reg Tests: XML 01b has an incorrect number of measures

Issue 3973

01b-Pitches-Intervals.xml from the Unofficial MusicXML
test suite contains only a single measure in MusicXML,
but there should be 41.

musicxml2ly is very tolerant here so the error doesn’t
show in the pdf.

Added missing <measure> elements
Fixed a typo in the title
Added missing <accidental> elements (They represent
the actual notated accidentals.  Without these elements
there shouldn’t be any visible accidentals. So this is
actually a bug in musicxml2ly. The bug doesn’t show here
because musicxml2ly interprets the <alter> element which
represents the sounding pitch of a note.)

Fixes provided by Patrick Schmidt

9 years agoRelease: bump VERSION.
Phil Holmes [Thu, 3 Jul 2014 21:15:30 +0000 (22:15 +0100)]
Release: bump VERSION.

9 years agoMerge remote branch 'origin/master' into release/unstable release/2.19.9-1
Phil Holmes [Thu, 3 Jul 2014 15:16:37 +0000 (16:16 +0100)]
Merge remote branch 'origin/master' into release/unstable