]> git.donarmstrong.com Git - lilypond.git/commitdiff
Issue 4384: Remove convert-ly rule \shiftOff -> \undo\shiftOn
authorDavid Kastrup <dak@gnu.org>
Sun, 10 May 2015 12:17:48 +0000 (14:17 +0200)
committerDavid Kastrup <dak@gnu.org>
Sun, 17 May 2015 17:05:34 +0000 (19:05 +0200)
For the rationale, see
<URL:https://codereview.appspot.com/190500043/#msg1>

The presence of the rule will cause similarly surprising effects to
users as it would to the current state of documentation translations.

Even if it were properly mentioned in the diagnostic description of
the conversion rule, people would rarely look closely enough to
notice.

python/convertrules.py

index 05beeec455de0c524d3821c6172d4b1d0af90a0a..8dc8e9160ab887078c30a01bba3b9916df74f682 100644 (file)
@@ -3741,7 +3741,6 @@ def conv(str):
     str = re.sub (r'\bimplicitTimeSignatureVisibility\b', 'initialTimeSignatureVisibility', str)
     str = re.sub ('(' + before_id + r'[a-g])((?:sharp){1,2}|(?:flat){1,2})'
                   + after_id, r'\1-\2', str)
-    str = re.sub (r'\\shiftOff\b', r'\\undo\\shiftOn', str)
     return str
 
 # Guidelines to write rules (please keep this at the end of this file)