MIDI: always set note volume when initialized. Fixes #1636.

diff --git a/Documentation/changes.tely b/Documentation/changes.tely
index 0c468b14beec2e2583c47026cde5454db194d3a8..552a0e7edcc8639393c5f46662a253b404b9c1b1 100644 (file)
--- a/Documentation/changes.tely
+++ b/Documentation/changes.tely
@@ -109,9 +109,10 @@ Lilypond now engraves woodwind fingering charts.
 @item
 MIDI output has been improved
 @itemize @bullet
-@item voices are kept separated, which makes the MIDI much more useful for postprocessing
+@item voices are kept separated, which makes the MIDI file much more useful for postprocessing
 @item optimal channel distribution: identical instruments share the same channel.  This means that e.g. for a full orchestral score there are always 16 (15 plus percussion) diffently sounding instruments available, unrestricted by the number of staves or voices.
-@item dynamics are now rendered as note velocities, no longer as midi dynamics.  This improves the sound on [high end] midi renderers.
+@item @code{\set Score.midiChannelMapping = #'staff} assigns one MIDI channel per staff, previously the default behavior.  This setting is required if you want instrument changes to create MIDI program changes on a single MIDI channel.
+@item dynamics are now rendered as note velocities, no longer as midi volume.  This improves the sound on [high end] midi renderers.
 @end itemize
 
 @item

diff --git a/lily/midi-item.cc b/lily/midi-item.cc
index a04553508fc660314c5d9a7452af6501ae0189b8..1fcb259ae13c2c0b6b0ee94967476cd8099f3928 100644 (file)
--- a/lily/midi-item.cc
+++ b/lily/midi-item.cc
@@ -181,7 +181,7 @@ Midi_time_signature::to_string () const
 Midi_note::Midi_note (Audio_note *a)
   : Midi_channel_item (a)
   , audio_ (a)
-  , dynamic_byte_ (a->dynamic_ && a->dynamic_->volume_ > 0
+  , dynamic_byte_ (a->dynamic_ && a->dynamic_->volume_ >= 0
                   ? Byte (a->dynamic_->volume_ * 0x7f) : Byte (0x5a))
 {
 }