]> git.donarmstrong.com Git - lilypond.git/commitdiff
Issue 4319: toward-stem-shift-in-column should only affect Script grobs
authorDavid Nalesnik <david.nalesnik@gmail.com>
Mon, 9 Mar 2015 15:16:55 +0000 (10:16 -0500)
committerDavid Nalesnik <david.nalesnik@gmail.com>
Thu, 19 Mar 2015 16:04:15 +0000 (11:04 -0500)
Previously, toward-stem-shift-in-column did not discriminate between
different types of grobs in the 'scripts grob-array.  This meant that
TextScript, StringNumber, and Fingering objects would be caught as well.
This patch only shifts an articulation in the presence of another Script
grob.

scm/output-lib.scm

index 96456b1b77fb436ae4a90b6b7ae851c30fa01678..2b2a65c719f12ec575c6587c206180e8bf89fb8b 100644 (file)
@@ -1187,8 +1187,19 @@ parent or the parent has no setting."
   (let* ((shift-when-alone (ly:grob-property grob 'toward-stem-shift 0.0))
          (shift-in-column (ly:grob-property grob 'toward-stem-shift-in-column))
          (script-column (ly:grob-object grob 'script-column))
-         (shift (if (and (ly:grob? script-column) (number? shift-in-column))
-                    shift-in-column shift-when-alone))
+         (shift
+           (if (and (ly:grob? script-column)
+                    (number? shift-in-column)
+                    ;; ScriptColumn can contain grobs other than Script.
+                    ;; These should not result in a shift.
+                    (any (lambda (s)
+                           (and (not (eq? s grob))
+                                (grob::has-interface s 'script-interface)
+                                (not (grob::has-interface s
+                                       'accidental-suggestion-interface))))
+                         (ly:grob-array->list
+                           (ly:grob-object script-column 'scripts))))
+               shift-in-column shift-when-alone))
          (note-head-location
           (ly:self-alignment-interface::aligned-on-x-parent grob))
          (note-head-grob (ly:grob-parent grob X))