]> git.donarmstrong.com Git - lilypond.git/commit
Issue 3531: replaced function argument 'string' by 'const string&' where it makes...
authorFrédéric Bron <frederic.bron@m4x.org>
Fri, 23 Aug 2013 15:30:34 +0000 (17:30 +0200)
committerDavid Kastrup <dak@gnu.org>
Tue, 10 Sep 2013 01:15:34 +0000 (03:15 +0200)
commit00216e16c717470ae53dbbfd1d52850d1b102e29
tree09a68e777977b2dd6e9c85a69fd103eb1d076474
parentc0a691181c981f55ef28e5daa8410b41e37ef808
Issue 3531: replaced function argument 'string' by 'const string&' where it makes sense to avoid unnecessary copying of 'string' objects.

Measurements on x86_64 (i7-2760QM, 2.40GHz) Fedora 19 with g++ 4.8.1, with
configure --enable-optimising --disable-debugging; tests run 10 times, average
elapsed time compared (/usr/bin/time)

* Bach, Concerto in E major or violin and strings, BWV 1042 (Mutopia source),
  38 pages:
  $ lilypond score.ly -> master: 15.4s, with patch: -0.1%
* lilypond regression tests (1153 .ly files):
  $ lilypond *.ly -> master: 276.6s, with patch: -2.5%
83 files changed:
flower/file-name.cc
flower/file-path.cc
flower/include/file-name.hh
flower/include/file-path.hh
flower/include/international.hh
flower/include/std-string.hh
flower/include/std-vector.hh
flower/include/string-convert.hh
flower/include/warn.hh
flower/international.cc
flower/std-string.cc
flower/string-convert.cc
flower/warn.cc
lily/all-font-metrics.cc
lily/audio-item.cc
lily/auto-change-iterator.cc
lily/axis-group-interface.cc
lily/change-iterator.cc
lily/context.cc
lily/control-track-performer.cc
lily/file-name-map.cc
lily/font-metric.cc
lily/function-documentation.cc
lily/global-context.cc
lily/gregorian-ligature.cc
lily/grob.cc
lily/includable-lexer.cc
lily/include/all-font-metrics.hh
lily/include/audio-item.hh
lily/include/axis-group-interface.hh
lily/include/change-iterator.hh
lily/include/context.hh
lily/include/file-name-map.hh
lily/include/font-metric.hh
lily/include/global-context.hh
lily/include/grob.hh
lily/include/includable-lexer.hh
lily/include/input.hh
lily/include/lily-guile-macros.hh
lily/include/lily-guile.hh
lily/include/lily-lexer.hh
lily/include/lily-parser.hh
lily/include/lilypond-version.hh
lily/include/midi-chunk.hh
lily/include/midi-stream.hh
lily/include/misc.hh
lily/include/modified-font-metric.hh
lily/include/note-head.hh
lily/include/open-type-font.hh
lily/include/output-def.hh
lily/include/pango-font.hh
lily/include/paper-outputter.hh
lily/include/relocate.hh
lily/include/rest.hh
lily/include/slur-configuration.hh
lily/include/slur-proto-engraver.hh
lily/include/source-file.hh
lily/include/tie-configuration.hh
lily/input.cc
lily/lexer.ll
lily/lily-guile.cc
lily/lily-lexer.cc
lily/lily-parser.cc
lily/lilypond-version.cc
lily/main.cc
lily/midi-chunk.cc
lily/midi-stream.cc
lily/misc.cc
lily/modified-font-metric.cc
lily/note-head.cc
lily/open-type-font.cc
lily/output-def.cc
lily/pango-font.cc
lily/paper-outputter.cc
lily/parser.yy
lily/relocate.cc
lily/rest.cc
lily/slur-configuration.cc
lily/slur-proto-engraver.cc
lily/source-file.cc
lily/staff-performer.cc
lily/tie-configuration.cc
lily/ttf.cc