]> git.donarmstrong.com Git - dsa-puppet.git/commitdiff
Prevent python from releasing locks prematurely
authorPeter Palfrader <peter@palfrader.org>
Sun, 7 Apr 2013 21:32:00 +0000 (23:32 +0200)
committerPeter Palfrader <peter@palfrader.org>
Sun, 7 Apr 2013 21:32:00 +0000 (23:32 +0200)
modules/roles/files/static-mirroring/static-master-run

index d9aa164a394f97af4778e55ddd1a80aad0691583..c82d68849e1003c1b30c9f2dc58d1b7069cd0a2a 100755 (executable)
@@ -123,7 +123,7 @@ def run_mirror():
   cur = os.path.join(base, subdirs['cur'])
   live = os.path.join(base, subdirs['live'])
   tmpdir_new = tempfile.mkdtemp(prefix='live.new-', dir=base); cleanup_dirs.append(tmpdir_new);
-  tmpdir_old = tempfile.mkdtemp(prefix='live.new-', dir=base); cleanup_dirs.append(tmpdir_old);
+  tmpdir_old = tempfile.mkdtemp(prefix='live.old-', dir=base); cleanup_dirs.append(tmpdir_old);
   os.chmod(tmpdir_new, 0755)
 
   locks = []
@@ -163,10 +163,15 @@ def run_mirror():
     log("Cleaning up.")
     shutil.rmtree(tmpdir_old)
     log("Done.")
-    return True
+    ret = True
   else:
     log("Aborted.")
-    return False
+    ret = False
+
+  for fd in locks:
+    fd.close()
+
+  return ret
 
 
 ok = False