Try to get rid of mxinfo again

diff --git a/manifests/site.pp b/manifests/site.pp
index 07efa9ca47a44f9a593cd1ce1ee226004ce71d59..e1b67ab20e4cb2819616a035ea7440217a64ad65 100644 (file)
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -17,8 +17,7 @@ node default {
     $localinfo = yamlinfo('*', "/etc/puppet/modules/debian-org/misc/local.yaml")
     $nodeinfo  = nodeinfo($fqdn, "/etc/puppet/modules/debian-org/misc/local.yaml")
     $hosterinfo = whohosts($nodeinfo, "/etc/puppet/modules/debian-org/misc/hoster.yaml")
-    $allnodeinfo = allnodeinfo("sshRSAHostKey ipHostNumber", "purpose")
-    $mxinfo    = allnodeinfo("mXRecord", "")
+    $allnodeinfo = allnodeinfo("sshRSAHostKey ipHostNumber", "purpose mXRecord")
     notice("hoster for ${fqdn} is ${hosterinfo}")
 
     include munin-node

diff --git a/modules/exim/templates/manualroute.erb b/modules/exim/templates/manualroute.erb
index ce22a342b867ca9adfa9a4e5021a94d3111889da..3e51534d253571f607635aeb8bbc97a840827ac9 100644 (file)
--- a/modules/exim/templates/manualroute.erb
+++ b/modules/exim/templates/manualroute.erb
@@ -18,8 +18,9 @@ if nodeinfo['mailrelay']
 end
 
 mxregex = Regexp.new('^\d+\s+(.*)\.$')
-mxinfo.keys.sort.each do |host|
-  mxinfo[host]['mXRecord'].each do |mx|
+allnodeinfo.keys.sort.each do |host|
+  next unless allnodeinfo[host['mXRecord']
+  allnodeinfo[host]['mXRecord'].each do |mx|
     mxmatch = mxregex.match(mx)
     if mxmatches.include?(mxmatch[1])
       route = host + ":\t\t" + host