Try a new modules/ferm/templates/me.conf.erb

diff --git a/modules/ferm/templates/me.conf.erb b/modules/ferm/templates/me.conf.erb
index 4efebbe84022a9d1ae8acaa622bd859d36b8fae7..0a80ab1fcf8ba120431b111be00e9332eb4ba323 100644 (file)
--- a/modules/ferm/templates/me.conf.erb
+++ b/modules/ferm/templates/me.conf.erb
@@ -3,80 +3,45 @@
 ## USE: git clone git+ssh://$USER@puppet.debian.org/srv/puppet.debian.org/git/dsa-puppet.git
 ##
 
-<%=
-  out=''
-  case hostname
-  when 'schroeder' then 
-    out = '@def $CARNET = ( 193.198.184.8/29 161.53.160.133 161.53.160.90 161.53.11.222 161.53.12.134 161.53.12.142 161.53.12.143 );'
-  end
-  out
-%>
-
-@def $SSH_SOURCES = (<%=
+<%
+restrict_ssh = %w{logtest01 geo1 geo2 geo3 bartok beethoven tchaikovsky schroeder}
 
-sshallowed = []
+ssh4allowed = []
+ssh6allowed = []
 
-case hostname
-  when 'logtest01', 'geo1', 'geo2', 'geo3', 'bartok', 'beethoven', 'tchaikovsky' then sshallowed << [ '$DSA_IPS', '$HOST_NAGIOS_V4', '$HOST_DB_V4' ]
-  when 'schroeder' then sshallowed << [ '$DSA_IPS', '$HOST_NAGIOS_V4', '$HOST_DB_V4', '$CARNET' ]
+if restrict_ssh.include?(hostname) then
+       ssh4allowed  << %w{$DSA_IPS $HOST_NAGIOS_V4 $HOST_DB_V4}
+       ssh6allowed << %w{$DSA_V6_IPS $HOST_NAGIOS_V6 $HOST_DB_V6}
 end
-
-case hostname
-  when 'bartok', 'beethoven' then sshallowed << '$HOST_DEBIAN_V4'
-end
-
-if sshallowed.length == 0
-  sshallowed = [ '0.0.0.0/0' ]
+if %w{schroeder}.include?(hostname) then
+       puts '@def $CARNET = ( 193.198.184.8/29 161.53.160.133 161.53.160.90 161.53.11.222 161.53.12.134 161.53.12.142 161.53.12.143 );'
+       ssh4allowed << '$CARNET'
 end
-
-sshallowed.join(' ')
-%>);
-
-@def $SSH_V6_SOURCES = (<%=
-
-sshallowed = []
-
-case hostname
-  when 'logtest01', 'geo1', 'geo2', 'geo3', 'bartok', 'beethoven', 'schroeder', 'tchaikovsky' then sshallowed << [ '$DSA_V6_IPS', '$HOST_NAGIOS_V6', '$HOST_DB_V6' ]
+if %w{bartok beethoven}.include?(hostname) then
+       ssh4allowed << '$HOST_DEBIAN_V4'
+       ssh6allowed << '$HOST_DEBIAN_V6'
 end
+ssh4allowed.length == 0 and ssh4allowed << '0.0.0.0/0'
+ssh6allowed.length == 0 and ssh6allowed << '::'
 
-case hostname
-  when 'bartok', 'beethoven' then sshallowed << '$HOST_DEBIAN_V6'
-end
+puts "@def $SSH_SOURCES    = (#{ssh4allowed.join(' ')});";
+puts "@def $SSH_V6_SOURCES = (#{ssh6allowed.join(' ')});";
 
-if sshallowed.length == 0
-  sshallowed = [ '::' ]
-end
 
-sshallowed.join(' ')
-%>);
 
-def $SMTP_SOURCES =(<%=
 
-smtpallowed = []
+smtp4allowed = []
+smtp6allowed = []
 
 if not nodeinfo['smarthost'].empty?
-  smtpallowed = [ '$HOST_MAILRELAY_V4', '$HOST_NAGIOS_V4' ]
-end
-
-if smtpallowed.length == 0
-  smtpallowed = [ '0.0.0.0/0' ]
+  smtp4allowed << %w{$HOST_MAILRELAY_V4 $HOST_NAGIOS_V4}
+  smtp6allowed << %w{$HOST_MAILRELAY_V6 $HOST_NAGIOS_V6}
 end
 
-smtpallowed.join(' ')
-%>);
-
-def $SMTP_V6_SOURCES =(<%=
-
-smtpallowed = []
+smtp4allowed.length == 0 and smtp4allowed << '0.0.0.0/0'
+smtp6allowed.length == 0 and smtp6allowed << '::'
 
-if not nodeinfo['smarthost'].empty?
-  smtpallowed = [ '$HOST_MAILRELAY_V6', '$HOST_NAGIOS_V6' ]
-end
+puts "@def $SMTP_SOURCES    = (#{smtp4allowed.join(' ')});";
+puts "@def $SMTP_V6_SOURCES = (#{smtp6allowed.join(' ')});";
 
-if smtpallowed.length == 0
-  smtpallowed = [ '::' ]
-end
-
-smtpallowed.join(' ')
-%>);
+%>