Removed explicit keyword from SamHeader-related object copy ctors

diff --git a/src/api/SamHeader.h b/src/api/SamHeader.h
index add44181b213caae536f19fa408b4b1e3efbec88..899459cd54e8afe2e733f5277625cb77de39e6a1 100644 (file)
--- a/src/api/SamHeader.h
+++ b/src/api/SamHeader.h
@@ -23,8 +23,8 @@ struct API_EXPORT SamHeader {
 
     // ctor & dtor
     public:
-        explicit SamHeader(const std::string& headerText = "");
-        explicit SamHeader(const SamHeader& other);
+        SamHeader(const std::string& headerText = "");
+        SamHeader(const SamHeader& other);
         ~SamHeader(void);
 
     // query/modify entire SamHeader at once

diff --git a/src/api/SamReadGroup.h b/src/api/SamReadGroup.h
index 14498af5fed9dd4a7f7148788dd26bab56f0e252..c53274af8aa667cf6607a924a745bdeaba502b7e 100644 (file)
--- a/src/api/SamReadGroup.h
+++ b/src/api/SamReadGroup.h
@@ -22,7 +22,7 @@ class API_EXPORT SamReadGroup {
     public:
         SamReadGroup(void);
         SamReadGroup(const std::string& id);
-        explicit SamReadGroup(const SamReadGroup& other);
+        SamReadGroup(const SamReadGroup& other);
         ~SamReadGroup(void);
 
     // public methods

diff --git a/src/api/SamReadGroupDictionary.h b/src/api/SamReadGroupDictionary.h
index 5179b267a2ff57e70e52b7713e088fa735a70408..8a2bb5b1adf8cc0a50683f135588a1fa87399fb2 100644 (file)
--- a/src/api/SamReadGroupDictionary.h
+++ b/src/api/SamReadGroupDictionary.h
@@ -29,7 +29,7 @@ class API_EXPORT SamReadGroupDictionary {
     // ctor & dtor
     public:
         SamReadGroupDictionary(void);
-        explicit SamReadGroupDictionary(const SamReadGroupDictionary& other);
+        SamReadGroupDictionary(const SamReadGroupDictionary& other);
         ~SamReadGroupDictionary(void);
 
     // query/modify read group data

diff --git a/src/api/SamSequence.h b/src/api/SamSequence.h
index 97cdb96d04cec567a09015f95c106f0dab80c267..4dedcaaac4171e4bff38811b9c6718af16441832 100644 (file)
--- a/src/api/SamSequence.h
+++ b/src/api/SamSequence.h
@@ -21,7 +21,7 @@ class API_EXPORT SamSequence {
     // ctor & dtor
     public:
         SamSequence(const std::string& name = "");
-        explicit SamSequence(const SamSequence& other);
+        SamSequence(const SamSequence& other);
         ~SamSequence(void);
 
     // public methods

diff --git a/src/api/SamSequenceDictionary.h b/src/api/SamSequenceDictionary.h
index 37ac824ef63de30102b1ca208513cea27be004c3..ce807560670e339bd3066b349f27501e17cdbb3d 100644 (file)
--- a/src/api/SamSequenceDictionary.h
+++ b/src/api/SamSequenceDictionary.h
@@ -27,7 +27,7 @@ class API_EXPORT SamSequenceDictionary {
     // ctor & dtor
     public:
         SamSequenceDictionary(void);
-        explicit SamSequenceDictionary(const SamSequenceDictionary& other);
+        SamSequenceDictionary(const SamSequenceDictionary& other);
         ~SamSequenceDictionary(void);
 
     // query/modify sequence data

diff --git a/src/api/internal/BamReader_p.cpp b/src/api/internal/BamReader_p.cpp
index 7aa18f3b0a1f44176732107f52c9ee98722cdd46..e0a3d90508072de505a79292a6395aadd1dc1598 100644 (file)
--- a/src/api/internal/BamReader_p.cpp
+++ b/src/api/internal/BamReader_p.cpp
@@ -137,7 +137,7 @@ const string BamReaderPrivate::GetHeaderText(void) const {
     return m_header->ToString();
 }
 
-SamHeader BamReaderPrivate::GetSamHeader(void) const {
+const SamHeader BamReaderPrivate::GetSamHeader(void) const {
     return m_header->ToSamHeader();
 }
 

diff --git a/src/api/internal/BamReader_p.h b/src/api/internal/BamReader_p.h
index 79bcddb3698023a67e1db28e461e547c3813cf21..3d49a6370bc11393cd91f967334127d2983a7bbb 100644 (file)
--- a/src/api/internal/BamReader_p.h
+++ b/src/api/internal/BamReader_p.h
@@ -67,7 +67,7 @@ class BamReaderPrivate {
 
         // access auxiliary data
         const std::string GetHeaderText(void) const;
-        SamHeader GetSamHeader(void) const;
+        const SamHeader GetSamHeader(void) const;
         int GetReferenceID(const std::string& refName) const;
 
         // index operations

diff --git a/src/api/internal/BamWriter_p.h b/src/api/internal/BamWriter_p.h
index 6eecd73b9d147dc89f9ae201b4792a9bae24d11e..d9314053e9bfd8fdee7d5134f24d02f3f3f61f49 100644 (file)
--- a/src/api/internal/BamWriter_p.h
+++ b/src/api/internal/BamWriter_p.h
@@ -46,10 +46,6 @@ class BamWriterPrivate {
                  const std::string& samHeader,
                  const BamTools::RefVector& referenceSequences,
                  bool isWriteUncompressed);
-    bool Open(const std::string& filename,
-              const std::string& samHeader,
-              const BamTools::RefVector& referenceSequences,
-              bool isWriteUncompressed);
        void SaveAlignment(const BamAlignment& al);
 
     // internal methods