Merge pull request #1915 from dondelelcaro/ergodox_ez_left_leds

[qmk_firmware.git] / tests / basic / test_keypress.cpp

diff --git a/tests/basic/test_keypress.cpp b/tests/basic/test_keypress.cpp
index 2323b7cb44b7681fc27002d8c4973cdbe1f9e7ee..194b1745b125870cd79a87ca4fd9143118fa2812 100644 (file)
--- a/tests/basic/test_keypress.cpp
+++ b/tests/basic/test_keypress.cpp
@@ -14,7 +14,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "test_common.h"
+#include "test_common.hpp"
 
 using testing::_;
 using testing::Return;
@@ -42,6 +42,7 @@ TEST_F(KeyPress, CorrectKeysAreReportedWhenTwoKeysArePressed) {
     press_key(1, 0);
     press_key(0, 3);
     //Note that QMK only processes one key at a time
+    //See issue #1476 for more information
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_B)));
     keyboard_task();
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_B, KC_C)));
@@ -68,6 +69,7 @@ TEST_F(KeyPress, LeftShiftIsReportedCorrectly) {
     press_key(3, 0);
     press_key(0, 0);
     // Unfortunately modifiers are also processed in the wrong order
+    // See issue #1476 for more information
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_A)));
     keyboard_task();
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_A, KC_LSFT)));
@@ -85,6 +87,7 @@ TEST_F(KeyPress, PressLeftShiftAndControl) {
     press_key(3, 0);
     press_key(5, 0);
     // Unfortunately modifiers are also processed in the wrong order
+    // See issue #1476 for more information
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
     keyboard_task();
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT, KC_LCTRL)));
@@ -96,6 +99,7 @@ TEST_F(KeyPress, LeftAndRightShiftCanBePressedAtTheSameTime) {
     press_key(3, 0);
     press_key(4, 0);
     // Unfortunately modifiers are also processed in the wrong order
+    // See issue #1476 for more information
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT)));
     keyboard_task();
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_LSFT, KC_RSFT)));
@@ -107,6 +111,9 @@ TEST_F(KeyPress, RightShiftLeftControlAndCharWithTheSameKey) {
     press_key(6, 0);
     // BUG: The press is split into two reports
     // BUG: It reports RSFT instead of LSFT
+    // See issue #524 for more information
+    // The underlying cause is that we use only one bit to represent the right hand
+    // modifiers.
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_RSFT, KC_RCTRL)));
     EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport(KC_RSFT, KC_RCTRL, KC_O)));
     keyboard_task();