make sure chanstats don't flood

[infobot.git] / src / UserExtra.pl

diff --git a/src/UserExtra.pl b/src/UserExtra.pl
index e0c234a4cadc3580cb1e05503e77bc18af88b8ef..c09291ef9a31184d5ac200fe6e25d55abf5c4866 100644 (file)
--- a/src/UserExtra.pl
+++ b/src/UserExtra.pl
@@ -30,8 +30,11 @@ use vars qw(%channels %chanstats %cmdstats);
        Help => 'nslookup', Identifier => 'allowDNS',
        Forker => "NULL", ) );
 &addCmdHook("main", 'tell|explain', ('CODEREF' => 'tell', 
-       Help => 'tell', Identifier => 'allowTelling', ) );
-
+       Help => 'tell', Identifier => 'allowTelling',
+       Cmdstats => 'Tell') );
+&addCmdHook("main", 'news', ('CODEREF' => 'News::Parse', 
+       Module => 'news', ) );
+#      Module => 'news', Identifier => 'news') );
 
 &status("CMD: loaded ".scalar(keys %hooks_main)." MAIN command hooks.");
 
@@ -57,13 +60,13 @@ sub chaninfo {
                &ircCheck();
                next;
            }
-           push(@array, "$_ (".scalar(keys %{$channels{$_}{''}}).")");
+           push(@array, "$_ (".scalar(keys %{ $channels{$_}{''} }).")");
        }
        &pSReply($reply.": ".join(' ', @array));
 
        ### total user count.
        foreach $chan (keys %channels) {
-           $tucount += scalar(keys %{$channels{$chan}{''}});
+           $tucount += scalar(keys %{ $channels{$chan}{''} });
        }
 
        ### unique user count.
@@ -75,6 +78,10 @@ sub chaninfo {
                push(@nicks, $_);
            }
        }
+       &DEBUG("nicks => '".scalar(@nicks)."'...");
+       if (scalar @nicks != $uucount) {
+           &DEBUG("nicks != uucount...");
+       }
 
        my $chans = scalar(keys %channels);
        &pSReply(
@@ -96,7 +103,7 @@ sub chaninfo {
 
     # Step 1:
     my @array;
-    foreach (sort keys %{$chanstats{$chan}}) {
+    foreach (sort keys %{ $chanstats{$chan} }) {
        my $int = $chanstats{$chan}{$_};
        next unless ($int);
 
@@ -116,7 +123,7 @@ sub chaninfo {
                - $chanstats{$chan}{'Part'};
 
     if ($delta_stats) {
-       my $total = scalar(keys %{$channels{$chan}{''}});
+       my $total = scalar(keys %{ $channels{$chan}{''} });
        &status("chaninfo: join ~= signoff + part (drift of $delta_stats < $total).");
 
        if ($delta_stats > $total) {
@@ -128,7 +135,7 @@ sub chaninfo {
     undef @array;
     my $type;
     foreach ("v","o","") {
-       my $int = scalar(keys %{$channels{$chan}{$_}});
+       my $int = scalar(keys %{ $channels{$chan}{$_} });
        next unless ($int);
 
        $type = "Voice" if ($_ eq "v");
@@ -141,6 +148,13 @@ sub chaninfo {
 
     # Step 3:
     ### TODO: what's wrong with the following?
+    foreach (keys %userstats) {
+       next if (exists $userstats{$_}{'Count'});
+       delete $userstats{$_};
+       $delete++;
+    }
+    &DEBUG("chanstats: delete: $delete... nowtotal => ".scalar(keys %userstats) );
+
     my %new = map { $userstats{$_}{'Count'} => $_ } keys %userstats;
     my($count) = (sort { $b <=> $a } keys %new)[0];
     if ($count) {
@@ -160,14 +174,14 @@ sub cmdstats {
 
     my %countstats;
     foreach (keys %cmdstats) {
-       $countstats{$cmdstats{$_}}{$_} = 1;
+       $countstats{ $cmdstats{$_} }{$_} = 1;
     }
 
     foreach (sort {$b <=> $a} keys %countstats) {
        my $int = $_;
        next unless ($int);
 
-       foreach (keys %{$countstats{$int}}) {
+       foreach (keys %{ $countstats{$int} }) {
            push(@array, "\002$int\002 of $_");
        }
     }
@@ -616,17 +630,29 @@ sub userCommands {
     }
 
     # ircstats.
-    if ($message =~ /^ircstats$/i) {
+    if ($message =~ /^ircstats?$/i) {
+       $ircstats{'TotalTime'}  ||= 0;
+       $ircstats{'OffTime'}    ||= 0;
+
        my $count       = $ircstats{'ConnectCount'};
        my $format_time = &Time2String(time() - $ircstats{'ConnectTime'});
-       my $total_time  = time() - $ircstats{'ConnectTime'} + $ircstats{'TotalTime'};
+       my $total_time  = time() - $ircstats{'ConnectTime'} +
+                               $ircstats{'TotalTime'};
        my $reply;
 
-       &DEBUG("ircstats: total_time => $total_time.");
-       &DEBUG("ircstats: offtime => $ircstats{'OffTime'}");
+       my $connectivity = 100 * ($total_time - $ircstats{'OffTime'}) /
+                               $total_time;
+       my $p = sprintf("%.03f", $connectivity);
+       $p =~ s/(\.\d*)0+$/$1/;
+       if ($p =~ s/\.0$//) {
+           # this should not happen... but why...
+       } else {
+           $p =~ s/\.$//
+       }
 
-       foreach (keys %ircstats) {
-           &DEBUG("ircstats: $_ => '$ircstats{$_}'.");
+       if ($total_time != (time() - $ircstats{'ConnectTime'}) ) {
+           my $tt_format = &Time2String($total_time);
+           &DEBUG("tt_format => $tt_format");
        }
 
        ### RECONNECT COUNT.
@@ -636,13 +662,14 @@ sub userCommands {
        } else {
            $reply = "Currently I'm hooked up to $ircstats{'Server'} but only".
                " for $format_time.  ".
-               "I had to reconnect \002$count\002 times.";
+               "I had to reconnect \002$count\002 times.".
+               "   Connectivity: $p %";
        }
 
        ### REASON.
        my $reason = $ircstats{'DisconnectReason'};
        if (defined $reason) {
-           $reply .= "  I was last disconnected for '$reason'.";
+           $reply .= ".  I was last disconnected for '$reason'.";
        }
 
        &pSReply($reply);