- updates to DEBUG/WARN/ERROR or the result of looking at them

[infobot.git] / src / UserExtra.pl

diff --git a/src/UserExtra.pl b/src/UserExtra.pl
index f4cb80904acb802a5ecc3809a2fc04180ef3a75c..23b287394c8e260a79a77333d52f9725d8b87f5b 100644 (file)
--- a/src/UserExtra.pl
+++ b/src/UserExtra.pl
@@ -160,7 +160,8 @@ sub chaninfo {
        $new{$_} = $userstats{$_}{'Count'};
     }
 
-    my($count) = (sort { $a <=> $b } keys %new)[0];
+    # todo: show top 3 with percentages?
+    my($count) = (sort { $new{$a} <=> $new{$b} } keys %new)[0];
     if ($count) {
        $reply .= ".  \002$count\002 has said the most with a total of \002$new{$count}\002 messages";
     }
@@ -219,7 +220,8 @@ sub factstats {
 
 sub karma {
     my $target = lc( shift || $who );
-    my $karma  = &dbGet("stats", "counter", "nick='$target' and type='karma'") || 0;
+    my $karma  = &dbGet("stats", "counter", "nick=".
+                       &dbQuote($target)." AND type='karma'") || 0; 
 
     if ($karma != 0) {
        &pSReply("$target has karma of $karma");
@@ -261,6 +263,9 @@ sub ispell {
        } elsif (/^\+/) {
            &DEBUG("spell: '+' found => '$_'.");
            last;
+       } elsif (/^# (.*?) 0$/) {
+           # none found.
+           last;
        } else {
            &DEBUG("spell: unknown: '$_'.");
        }
@@ -391,9 +396,14 @@ sub DNS {
     my $pid;
     $dns =~ s/^\s+|\s+$//g;
 
+    if (!defined $dns or $dns =~ /^\s*$/ or $dns =~ / /) {
+       &help("dns");
+       return;
+    }
+
     if ($dns =~ /(\d+\.\d+\.\d+\.\d+)/) {
-       &status("DNS query by IP address: $in");
        $match = $1;
+       &status("DNS query by IP address: $match");
 
        $y = pack('C4', split(/\./, $match));
        $x = (gethostbyaddr($y, &AF_INET));
@@ -692,19 +702,28 @@ sub userCommands {
        my $raw_perc2   = $cpu_usage2*100/$time;
        my $perc;
        my $perc2;
+       my $total;
+       my $ratio;
 
        if ($raw_perc > 1) {
            $perc       = sprintf("%.01f", $raw_perc);
            $perc2      = sprintf("%.01f", $raw_perc2);
+           $total      = sprintf("%.01f", $raw_perc+$raw_perc2);
        } elsif ($raw_perc > 0.1) {
            $perc       = sprintf("%.02f", $raw_perc);
            $perc2      = sprintf("%.02f", $raw_perc2);
+           $total      = sprintf("%.02f", $raw_perc+$raw_perc2);
        } else {                        # <=0.1
            $perc       = sprintf("%.03f", $raw_perc);
            $perc2      = sprintf("%.03f", $raw_perc2);
+           $total      = sprintf("%.03f", $raw_perc+$raw_perc2);
        }
+       $ratio  = sprintf("%.01f", 100*$perc/($perc+$perc2) );
 
-       &pSReply("Total CPU usage: $cpu_usage s ... Percentage CPU used: $perc % (+childs: $perc2 %)");
+       &pSReply("Total CPU usage: \002$cpu_usage\002 s ... ".
+               "Total used: \002$total\002 % ".
+               "(parent/child ratio: $ratio %)"
+       );
 
        return;
     }
@@ -762,6 +781,7 @@ sub userCommands {
        my $startString = scalar(localtime $^T);
        my $upString    = &Time2String(time() - $^T);
        my $count       = &countKeys("factoids");
+
        $count{'Commands'}      = 0;
        foreach (keys %cmdstats) {
            $count{'Commands'} += $cmdstats{$_};
@@ -785,6 +805,19 @@ sub userCommands {
          "kB of memory."
        );
 
+       # todo: make dbGetColNiceHash().
+       my %hash = &dbGetCol("stats", "nick,counter", "type='cmdstats'".
+#                      " ORDER BY counter DESC LIMIT 3", 1);
+                       " ORDER BY counter DESC", 1);
+
+       foreach (keys %hash) {
+           my $i = $_;
+           foreach (keys %{ $hash{$i} }) {
+               &DEBUG("cmdstats: $hash{$i}{$_} = $_");
+           }
+       }
+       &DEBUG("end of cmdstats.");
+
        return;
     }