standard TODO: and FIXME:

[infobot.git] / src / Net.pl

diff --git a/src/Net.pl b/src/Net.pl
index 1d167cc04235ee661c6d24673cde934252b256c5..c08341cd0e0f5a731f955c4b4fc813305d538312 100644 (file)
--- a/src/Net.pl
+++ b/src/Net.pl
@@ -77,7 +77,7 @@ sub ftpGet {
     if (defined $lsize) {
        &DEBUG("FTP: locsize => '$lsize'.");
        if ($size != $lsize) {
-           &WARN("FTP: downloaded file seems truncated. FIXME.");
+           &FIXME("FTP: downloaded file seems truncated.");
        }
     }
 
@@ -145,7 +145,7 @@ sub ftpList {
 
 ### LWP.
 # Usage: &getURL($url, [$post]);
-# todo: rename this to getHTTP
+# TODO: rename this to getHTTP
 sub getURL {
     my ($url,$post) = @_;
     my ($ua,$res,$req);
@@ -181,20 +181,23 @@ sub getURL {
 sub getURLAsFile {
     my ($url,$file) = @_;
     my ($ua,$res,$req);
+    my $time = time();
 
     return unless &loadPerlModule("LWP::UserAgent");
+
     $ua = new LWP::UserAgent;
     $ua->proxy('http', $param{'httpProxy'}) if &IsParam("httpProxy");
-    my $req = HTTP::Request->new('GET', $url);
-    my $time = time();
+    $req = HTTP::Request->new('GET', $url);
     &status("getURLAsFile: getting '$url' as '$file'");
-    my $res = $ua->request($req, $file);
+    $res = $ua->request($req, $file);
+
     my $delta_time     = time() - $time;
     if ($delta_time) {
        my $size = -s $file || 0;
        my $rate = int($size / $delta_time / 1024);
        &status("getURLAsFile: Done. ($rate kB/sec)");
     }
+
     return $res;
 }