- strictify

[infobot.git] / src / Modules / Uptime.pl

diff --git a/src/Modules/Uptime.pl b/src/Modules/Uptime.pl
index c1897f7fd328be6a96d604aeb76178d32a7e2790..d433952f8be94f85dffbbe10e8e474af68ce1953 100644 (file)
--- a/src/Modules/Uptime.pl
+++ b/src/Modules/Uptime.pl
@@ -5,7 +5,7 @@
 #   Created: 19990925.
 #
 
-use strict;
+# use strict;  # TODO
 
 my $uptimerecords      = 3;
 
@@ -24,7 +24,7 @@ sub uptimeStr {
 }
 
 sub uptimeGetInfo {
-  my (%uptime,%done,%pid);
+  my (%uptime,%done);
   my ($uptime,$pid);
   my @results;
   my $file = $file{utm};
@@ -49,8 +49,9 @@ sub uptimeGetInfo {
 
   # fixed up bad implementation :)
   # should be no problems, even if uptime or pid is duplicated.
+  ## WARN: run away forks may get through here, have to fix.
   foreach $uptime (sort {$b <=> $a} keys %uptime) {
-    foreach $pid (keys %{$uptime{$uptime}}) {
+    foreach $pid (keys %{ $uptime{$uptime} }) {
        next if (exists $done{$pid});
 
        push(@results,"$uptime.$pid $uptime{$uptime}{$pid}");
@@ -68,7 +69,7 @@ sub uptimeWriteFile {
   my $file = $file{utm};
 
   if ($$ != $bot_pid) {
-    &WARN("uptime: forked process doing weird things! FIXME");
+    &FIXME("uptime: forked process doing weird things!");
     exit 0;
   }
 
@@ -82,9 +83,11 @@ sub uptimeWriteFile {
   }
 
   close OUT;
+  &status("--- Saved uptime records.");
+
+  return unless defined $conn;
 
   $conn->schedule(&getRandomInt("1800-3600"), \&uptimeWriteFile, "");
-  return;
 }
 
 1;