standard TODO: and FIXME:

[infobot.git] / src / IRC / IrcHooks.pl

diff --git a/src/IRC/IrcHooks.pl b/src/IRC/IrcHooks.pl
index 45fee8b074e0a14fed32232b85a87ce1d6d827a3..5a18b7cfbf7f0ae6a34d6985c9c7d6f0cd66a2f6 100644 (file)
--- a/src/IRC/IrcHooks.pl
+++ b/src/IRC/IrcHooks.pl
@@ -69,7 +69,7 @@ sub on_chat {
 
        ### TODO: prevent users without CRYPT chatting.
        if (!defined $crypto) {
-           &DEBUG("todo: dcc close chat");
+           &TODO("dcc close chat");
            &msg($who, "nope, no guest logins allowed...");
            return;
        }
@@ -89,7 +89,7 @@ sub on_chat {
            &DEBUG("chat: sock => '$sock'.");
 ###        $sock->close();
            delete $dcc{'CHAT'}{$nick};
-           &DEBUG("chat: after closing sock. FIXME");
+           &FIXME("chat: after closing sock.");
            ### BUG: close seizes bot. why?
        }
 
@@ -327,7 +327,7 @@ sub on_dcc_open_chat {
     my(undef, $nick, $sock) = @_;
 
     if ($nuh{$nick} eq "GETTING-NOW") {
-       &DEBUG("getting nuh for $nick failed. FIXME.");
+       &FIXME("getting nuh for $nick failed.");
        return;
     }
 
@@ -344,7 +344,7 @@ sub on_dcc_open_chat {
     my $crypto = $users{$userHandle}{PASS};
     $dcc{'CHAT'}{$nick} = $sock;
 
-    # todo: don't make DCC CHAT established in the first place.
+    # TODO: don't make DCC CHAT established in the first place.
     if ($userHandle eq "_default") {
        &dccsay($nick, "_default/guest not allowed");
        $sock->close();
@@ -474,7 +474,7 @@ sub on_join {
     }
 
     $chanstats{$chan}{'Join'}++;
-    $userstats{lc $who}{'Join'} = time() if (&IsChanConf("seenStats"));
+    $userstats{lc $who}{'Join'} = time() if (&IsChanConf("seenStats") > 0);
     $cache{maxpeeps}{$chan}    = $i if ($i > $j);
 
     &joinfloodCheck($who, $chan, $event->userhost);
@@ -694,7 +694,7 @@ sub on_nick {
            $channels{$chan}{$mode}{$newnick} = $channels{$chan}{$mode}{$nick};
        }
     }
-    # todo: do %flood* aswell.
+    # TODO: do %flood* aswell.
 
     &delUserInfo($nick, keys %channels);
     $nuh{lc $newnick} = $nuh{lc $nick};
@@ -735,6 +735,7 @@ sub on_nick_taken {
 
 sub on_notice {
     my ($self, $event) = @_;
+    #$conn = $self; <- ugly hack or elegant solution?
     my $nick = $event->nick();
     my $chan = ($event->to)[0];
     my $args = ($event->args)[0];
@@ -817,7 +818,7 @@ sub on_part {
        &clearChanVars($chan);
     }
 
-    if (!&IsNickInAnyChan($nick) and &IsChanConf("seenStats")) {
+    if (!&IsNickInAnyChan($nick) and &IsChanConf("seenStats") > 0) {
        delete $userstats{lc $nick};
     }
 
@@ -855,7 +856,7 @@ sub on_public {
     $uh                = $event->userhost();
     $nuh       = $nick."!".$uh;
     $msgType   = "public";
-    # todo: move this out of hookMsg to here?
+    # TODO: move this out of hookMsg to here?
     ($user,$host) = split(/\@/, $uh);
     $h         = $host;
 
@@ -868,7 +869,7 @@ sub on_public {
     $msgtime           = time();
     $lastWho{$chan}    = $nick;
     ### TODO: use $nick or lc $nick?
-    if (&IsChanConf("seenStats")) {
+    if (&IsChanConf("seenStats") > 0) {
        $userstats{lc $nick}{'Count'}++;
        $userstats{lc $nick}{'Time'} = time();
     }
@@ -899,7 +900,7 @@ sub on_public {
        $v++;
 
        # don't allow ppl to cheat the stats :-)
-       if (defined $t && $time - $t > 60) { 
+       if (defined $t && $time - $t > 60) {
            &sqlReplace("stats", {
                nick    => $who,
                type    => $x,
@@ -977,7 +978,7 @@ sub on_quit {
        # well.. it's good but weird that this has happened - lets just
        # be quiet about it.
     }
-    delete $userstats{lc $nick} if (&IsChanConf("seenStats"));
+    delete $userstats{lc $nick} if (&IsChanConf("seenStats") > 0);
     delete $chanstats{lc $nick};
     ###