]> git.donarmstrong.com Git - infobot.git/blobdiff - src/Factoids/Core.pl
standard TODO: and FIXME:
[infobot.git] / src / Factoids / Core.pl
index d8d559a0a8b2202a5afc1521f16f174314c1113b..2e79107c11c354cd5f04edb964b50736c3cf7e4c 100644 (file)
@@ -5,7 +5,11 @@
 #   Created: 20010906
 #
 
-if (&IsParam("useStrict")) { use strict; }
+# use strict;  # TODO
+
+use vars qw(%param %cache %lang %cmdstats %bots);
+use vars qw($message $who $addressed $chan $h $nuh $ident $msgType
+       $correction_plausable);
 
 # Usage: &validFactoid($lhs,$rhs);
 sub validFactoid {
@@ -143,91 +147,143 @@ sub FactoidStuff {
        }
 
        $faqtoid =~ tr/A-Z/a-z/;
+       $faqtoid =~ s/^cmd:/CMD:/; # basic command forgetting
        my $result = &getFactoid($faqtoid);
 
-       if (defined $result) {
-           my $author  = &getFactInfo($faqtoid, "created_by");
-           my $count   = &getFactInfo($faqtoid, "requested_count") || 0;
-           my $limit   = &getChanConfDefault("factoidPreventForgetLimit", 
-                               100, $chan);
+       # if it doesn't exist, well... it doesn't!
+       if (!defined $result) {
+           &performReply("i didn't have anything called '$faqtoid'");
+           return;
+       }
 
-           if (IsFlag("r") ne "r") {
-               &msg($who, "you don't have access to remove factoids");
-               return;
-           }
+       # TODO: squeeze 3 getFactInfo calls into one?
+       my $author      = &getFactInfo($faqtoid, "created_by");
+       my $count       = &getFactInfo($faqtoid, "requested_count") || 0;
+       # don't delete if requested $limit times
+       my $limit       = &getChanConfDefault(
+                               "factoidPreventForgetLimit", 100, $chan);
+       # don't delete if older than $limitage seconds (modified by requests below)
+       my $limitage    = &getChanConfDefault(
+                               "factoidPreventForgetLimitTime", 7 * 24 * 60 * 60, $chan);
+       my $t           = &getFactInfo($faqtoid, "created_time") || 0;
+       my $age         = time() - $t;
+
+       # lets scale limitage from 1 (nearly 0) to $limit (full time).
+       $limitage       = $limitage*($count+1)/$limit if ($count < $limit);
+       # isauthor and isop.
+       my $isau        = (defined $author and &IsHostMatch($author) == 2) ? 1 : 0;
+       my $isop        = (&IsFlag("o") eq "o") ? 1 : 0;
+
+       if (IsFlag("r") ne "r" && !$isop) {
+           &msg($who, "you don't have access to remove factoids");
+           return;
+       }
 
-           return 'locked factoid' if (&IsLocked($faqtoid) == 1);
+       return 'locked factoid' if (&IsLocked($faqtoid) == 1);
 
-           # factoidPreventForgetLimit:
-           if ($limit and $count > $limit and (&IsFlag("o") ne "o")) {
-               &msg($who, "will not delete '$faqtoid', count > limit ($count > $limit)");
-               return;
-           }
+       ###
+       ### lets go do some checking.
+       ###
 
-           # prevent/minimize abuse.
-           my $faqauth = &getFactInfo($faqtoid, "created_by");
-           if (&IsFlag("o") ne "o" and &IsHostMatch($faqauth) != 2) {
-               $cache{forget}{$h}++;
+       # factoidPreventForgetLimitTime:
+       if (!($isop or $isau) and $age/(60*60*24) > $limitage) {
+           &msg($who, "cannot remove factoid '$faqtoid', too old. (" .
+                   $age/(60*60*24) . ">$limitage) use 'no,' instead");
+           return;
+       }
 
-               # warn.
-               if ($cache{forget}{$h} > 3) {
-                   &msg($who, "Stop abusing forget!");
-               }
+       # factoidPreventForgetLimit:
+       if (!($isop or $isau) and $limit and $count > $limit) {
+           &msg($who, "will not delete '$faqtoid', count > limit ($count > $limit) use 'no, ' instead.");
+           return;
+       }
 
-               # ignore.
-               # todo: make forget limit configurable.
-               # todo: make forget ignore time configurable.
-               if ($cache{forget}{$h} > 5) {
-                   &ignoreAdd(&makeHostMask($nuh), "*", 3*24*60*60, "abuse of forget");
-                   &msg($who, "forget: Suck it!");
-               }
+       # this may eat some memory.
+       # prevent deletion if other factoids redirect to it.
+       # TODO: use hash instead of array.
+       my @list;
+       if (&getChanConf("factoidPreventForgetRedirect")) {
+           &status("Factoids/Core: forget: checking for redirect factoids");
+           @list = &searchTable("factoids", "factoid_key",
+                       "factoid_value", "^<REPLY> see ");
+       }
+
+       my $match = 0;
+       for (@list) {
+           my $f = $_;
+           my $v = &getFactInfo($f, "factoid_value");
+           my $fsafe = quotemeta($faqtoid);
+           next unless ($v =~ /^<REPLY> ?see( also)? $fsafe\.?$/i);
+
+           &DEBUG("Factoids/Core: match! ($f || $faqtoid)");
+
+           $match++;
+       }
+       # TODO: warn for op aswell, but allow force delete.
+       if (!$isop and $match) {
+           &msg($who, "uhm, other (redirection) factoids depend on this one.");
+           return;
+       }
+
+       # minimize abuse.
+       if (!$isop and &IsHostMatch($author) != 2) {
+           $cache{forget}{$h}++;
+
+           # warn.
+           if ($cache{forget}{$h} > 3) {
+               &msg($who, "Stop abusing forget!");
            }
 
-           # lets do it!
+           # ignore.
+           # TODO: make forget limit configurable.
+           # TODO: make forget ignore time configurable.
+           if ($cache{forget}{$h} > 5) {
+               &ignoreAdd(&makeHostMask($nuh), "*", 3*24*60, "abuse of forget");
+               &msg($who, "forget: Ignoring you for abuse!");
+           }
+       }
 
-           if (&IsParam("factoidDeleteDelay") or &IsChanConf("factoidDeleteDelay")) {
-               if ($faqtoid =~ / #DEL#$/ and !&IsFlag("o")) {
-                   &msg($who, "cannot delete it ($faqtoid).");
-                   return;
-               }
+       # lets do it!
 
-               &status("forgot (safe delete): '$faqtoid' - ". scalar(localtime));
-               ### TODO: check if the "backup" exists and overwrite it
-               my $check = &getFactoid("$faqtoid #DEL#");
+       if (&IsParam("factoidDeleteDelay") or &IsChanConf("factoidDeleteDelay")) {
+           if (!($isop or $isau) and $faqtoid =~ / #DEL#$/) {
+               &msg($who, "cannot delete it ($faqtoid).");
+               return;
+           }
 
-               if (!defined $check or $check =~ /^\s*$/) {
-                   if ($faqtoid !~ / #DEL#$/) {
-                       my $new = $faqtoid." #DEL#";
+           &status("forgot (safe delete): '$faqtoid' - ". scalar(gmtime));
+           ### TODO: check if the "backup" exists and overwrite it
+           my $check = &getFactoid("$faqtoid #DEL#");
 
-                       my $backup = &getFactoid($new);
-                       if ($backup) {
-                           &DEBUG("forget: not overwriting backup: $faqtoid");
-                       } else {
-                           &status("forget: backing up '$faqtoid'");
-                           &setFactInfo($faqtoid, "factoid_key", $new);
-                           &setFactInfo($new, "modified_by", $who);
-                           &setFactInfo($new, "modified_time", time());
-                       }
+           if (!defined $check or $check =~ /^\s*$/) {
+               if ($faqtoid !~ / #DEL#$/) {
+                   my $new = $faqtoid." #DEL#";
 
+                   my $backup = &getFactoid($new);
+                   if ($backup) {
+                       &DEBUG("forget: not overwriting backup: $faqtoid");
                    } else {
-                       &status("forget: not backing up $faqtoid.");
+                       &status("forget: backing up '$faqtoid'");
+                       &setFactInfo($faqtoid, "factoid_key", $new);
+                       &setFactInfo($new, "modified_by", $who);
+                       &setFactInfo($new, "modified_time", time());
                    }
 
                } else {
-                   &status("forget: not overwriting backup!");
+                   &status("forget: not backing up $faqtoid.");
                }
-           }
 
-           &status("forget: <$who> '$faqtoid' =is=> '$result'");
-           &delFactoid($faqtoid);
+           } else {
+               &status("forget: not overwriting backup!");
+           }
+       }
 
-           &performReply("i forgot $faqtoid");
+       &status("forget: <$who> '$faqtoid' =is=> '$result'");
+       &delFactoid($faqtoid);
 
-           $count{'Update'}++;
+       &performReply("i forgot $faqtoid");
 
-       } else {
-           &performReply("i didn't have anything called '$faqtoid'");
-       }
+       $count{'Update'}++;
 
        return;
     }
@@ -246,33 +302,37 @@ sub FactoidStuff {
 
        my $faqtoid = $message;
        if ($faqtoid eq "") {
-           &help("undelete");
+           &help("unforget");
            return;
        }
 
        $faqtoid =~ tr/A-Z/a-z/;
+       $faqtoid =~ s/^cmd:/CMD:/; # basic command undeleteing
        my $result = &getFactoid($faqtoid." #DEL#");
        my $check  = &getFactoid($faqtoid);
 
-       if (!defined $result) {
-           &performReply("that factoid was not backedup :/");
-           return;
-       }
-
        if (defined $check) {
            &performReply("cannot undeleted '$faqtoid' because it already exists!");
            return;
        }
 
-       &setFactInfo($faqtoid." #DEL#", "factoid_key", $faqtoid);
-
-       ### delete info. modified_ isn't really used.
-       &setFactInfo($faqtoid, "modified_by",  "");
-       &setFactInfo($faqtoid, "modified_time", 0);
+       if (!defined $result) {
+           &performReply("that factoid was not backedup :/");
+           return;
+       }
 
-       &performReply("Successfully recovered '$faqtoid'.  Have fun now.");
+       &setFactInfo($faqtoid." #DEL#", "factoid_key",   $faqtoid);
+#      &setFactInfo($faqtoid, "modified_by",   "");
+#      &setFactInfo($faqtoid, "modified_time", 0);
 
-       $count{'Undelete'}++;
+       $check  = &getFactoid($faqtoid);
+       # TODO: check if $faqtoid." #DEL#" exists?
+       if (defined $check) {
+           &performReply("Successfully recovered '$faqtoid'.  Have fun now.");
+           $count{'Undelete'}++;
+       } else {
+           &performReply("did not recover '$faqtoid'.  What happened?");
+       }
 
        return;
     }
@@ -320,29 +380,31 @@ sub FactoidStuff {
        }
 
        if ($message =~ /^'(.*)'\s+'(.*)'$/) {
-           my($from,$to) = (lc $1, lc $2);
+           my ($from,$to) = (lc $1, lc $2);
 
            my $result = &getFactoid($from);
            if (defined $result) {
-               my $author = &getFactInfo($from, "created_by");
-
-               if (0 and !&IsFlag("m") or $author !~ /^\Q$who\E\!/i) {
-                   &msg($who, "It's not yours to modify.");
-                   return;
-               }
+               &performReply("i didn't have anything called '$from'");
+               return;
+           }
 
-               if ($_ = &getFactoid($to)) {
-                   &performReply("destination factoid already exists.");
-                   return;
-               }
+           my $author = &getFactInfo($from, "created_by");
 
-               &setFactInfo($from,"factoid_key",$to);
+           # who == nick!user@host.
+           if (&IsFlag("m") ne "m" and $author !~ /^\Q$who\E\!/i) {
+               &msg($who, "factoid '$form' is not yours to modify.");
+               return;
+           }
 
-               &status("rename: <$who> '$from' is now '$to'");
-               &performReply("i renamed '$from' to '$to'");
-           } else {
-               &performReply("i didn't have anything called '$from'");
+           if ($_ = &getFactoid($to)) {
+               &performReply("destination factoid already exists.");
+               return;
            }
+
+           &setFactInfo($from,"factoid_key",$to);
+
+           &status("rename: <$who> '$from' is now '$to'");
+           &performReply("i renamed '$from' to '$to'");
        } else {
            &msg($who,"error: wrong format. ask me about 'help rename'.");
        }
@@ -463,7 +525,7 @@ sub FactoidStuff {
        return;
     }
 
-    return unless ($addressed);
+    return unless ($addressed and !$addrchar);
 
     if (length $message > 64) {
        &status("unparseable-moron: $message");