use IO::Scalar;
use IO::File;
-use Debbugs::Config qw(:globals :text);
+use Debbugs::Config qw(:globals :text :config);
# for read_log_records
use Debbugs::Log qw(:read);
-use Debbugs::CGI qw(:url :html :util);
+use Debbugs::CGI qw(:url :html :util :cache);
use Debbugs::CGI::Bugreport qw(:all);
use Debbugs::Common qw(buglog getmaintainers make_list bug_status);
use Debbugs::Packages qw(getpkgsrc);
);
# This is craptacular.
-my $ref = $param{bug} or quitcgi("No bug number");
-$ref =~ /(\d+)/ or quitcgi("Invalid bug number");
+my $ref = $param{bug} or quitcgi("No bug number", '400 Bad Request');
+$ref =~ /(\d+)/ or quitcgi("Invalid bug number", '400 Bad Request');
$ref = $1;
my $short = "#$ref";
my ($msg) = $param{msg} =~ /^(\d+)$/ if exists $param{msg};
## Identify the users required
for my $user (map {split /[\s*,\s*]+/} make_list($param{users}||[])) {
next unless length($user);
- push @dependent_files,Debbugs::User::usertag_flie_from_email($user);
+ push @dependent_files,Debbugs::User::usertag_file_from_email($user);
}
if (defined $param{usertag}) {
for my $usertag (make_list($param{usertag})) {
my ($user, $tag) = split /:/, $usertag, 2;
- push @dependent_files,Debbugs::User::usertag_flie_from_email($user);
+ push @dependent_files,Debbugs::User::usertag_file_from_email($user);
}
}
$etag =
],
);
if (not $etag) {
- print $q->header(-status => 304);
+ print $q->header(-status => 304,
+ -cache_control => 'public, max-age=600',
+ -etag => $etag,
+ -charset => 'utf-8',
+ -content_type => 'text/html',
+ );
print "304: Not modified\n";
exit 0;
}
print $q->header(-status => 200,
-cache_control => 'public, max-age=600',
-etag => $etag,
+ -charset => 'utf-8',
-content_type => 'text/html',
);
exit 0;
}
}
-
-my $buglogfh;
-if ($buglog =~ m/\.gz$/) {
- my $oldpath = $ENV{'PATH'};
- $ENV{'PATH'} = '/bin:/usr/bin';
- $buglogfh = IO::File->new("zcat $buglog |") or quitcgi("open log for $ref: $!");
- $ENV{'PATH'} = $oldpath;
-} else {
- $buglogfh = IO::File->new($buglog,'r') or quitcgi("open log for $ref: $!");
-}
-
-
my %status;
if ($need_status) {
%status = %{split_status_fields(get_bug_status(bug=>$ref,
my @records;
eval{
- @records = read_log_records(logfh => $buglogfh,inner_file => 1);
+ @records = read_log_records(bug_num => $ref,inner_file => 1);
};
if ($@) {
quitcgi("Bad bug log for $gBug $ref. Unable to read records: $@");
}
-undef $buglogfh;
-
my $log='';
my $msg_num = 0;
binmode(STDOUT,":raw");
my $date = strftime "%a %b %d %T %Y", localtime;
if (@records > 1) {
- print $q->header(-type => "text/plain",
+ print $q->header(-type => "application/mbox",
-cache_control => 'public, max-age=600',
-etag => $etag,
content_disposition => qq(attachment; filename="bug_${ref}.mbox"),
- (length $mtime)?(-last_modified => $mtime):(),
);
}
else {
-cache_control => 'public, max-age=86400',
-etag => $etag,
content_disposition => qq(attachment; filename="bug_${ref}_message_${msg_num}.mbox"),
- (length $mtime)?(-last_modified => $mtime):(),
);
}
if ($mbox_status_message and @records > 1) {
$msg_num++;
## allow this to be cached for a week
print "Status: 200 OK\n";
- print "Cache-control: public, max-age=604800\n";
+ print "Cache-Control: public, max-age=604800\n";
print "Etag: $etag\n";
print handle_email_message($records[0],
ref => $ref,
\%seen_msg_ids,
trim_headers => $trim_headers,
avatars => $avatars,
+ terse => $terse,
);
}
}
'&maybelink' => \&Debbugs::CGI::maybelink,
},
);
+
+__END__
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End: