woot! %myModules is dead

[infobot.git] / blootbot / src / Factoids / Core.pl

diff --git a/blootbot/src/Factoids/Core.pl b/blootbot/src/Factoids/Core.pl
index fde06aa273292ebd14bad902ec70836b703646ff..684922d0759bcc804a7be7406d12de4c0e4798dc 100644 (file)
--- a/blootbot/src/Factoids/Core.pl
+++ b/blootbot/src/Factoids/Core.pl
@@ -37,7 +37,6 @@ sub validFactoid {
        /^learn / and last;             # teach. damn morons.
        /^tell (\S+) about / and last;  # tell.
        /\=\~/ and last;                # substituition.
-       /^\S+ to \S+ \S+/ and last;     # babelfish.
 
        /^\=/ and last;                 # botnick = heh is.
        /wants you to know/ and last;
@@ -147,14 +146,16 @@ sub FactoidStuff {
        }
 
        $faqtoid =~ tr/A-Z/a-z/;
+       $faqtoid =~ s/^cmd:/CMD:/; # basic command forgetting
        my $result = &getFactoid($faqtoid);
 
        # if it doesn't exist, well... it doesn't!
        if (!defined $result) {
-           &performReply("i didn't have anything called '$faqtoid'");
+           &performReply("i didn't have anything called '$faqtoid' to forget");
            return;
        }
 
+       # TODO: squeeze 3 getFactInfo calls into one?
        my $author      = &getFactInfo($faqtoid, "created_by");
        my $count       = &getFactInfo($faqtoid, "requested_count") || 0;
        # don't delete if requested $limit times
@@ -198,7 +199,7 @@ sub FactoidStuff {
 
        # this may eat some memory.
        # prevent deletion if other factoids redirect to it.
-       # todo: use hash instead of array.
+       # TODO: use hash instead of array.
        my @list;
        if (&getChanConf("factoidPreventForgetRedirect")) {
            &status("Factoids/Core: forget: checking for redirect factoids");
@@ -217,7 +218,7 @@ sub FactoidStuff {
 
            $match++;
        }
-       # todo: warn for op aswell, but allow force delete.
+       # TODO: warn for op aswell, but allow force delete.
        if (!$isop and $match) {
            &msg($who, "uhm, other (redirection) factoids depend on this one.");
            return;
@@ -233,11 +234,11 @@ sub FactoidStuff {
            }
 
            # ignore.
-           # todo: make forget limit configurable.
-           # todo: make forget ignore time configurable.
+           # TODO: make forget limit configurable.
+           # TODO: make forget ignore time configurable.
            if ($cache{forget}{$h} > 5) {
-               &ignoreAdd(&makeHostMask($nuh), "*", 3*24*60*60, "abuse of forget");
-               &msg($who, "forget: Suck it!");
+               &ignoreAdd(&makeHostMask($nuh), "*", 3*24*60, "abuse of forget");
+               &msg($who, "forget: Ignoring you for abuse!");
            }
        }
 
@@ -305,6 +306,7 @@ sub FactoidStuff {
        }
 
        $faqtoid =~ tr/A-Z/a-z/;
+       $faqtoid =~ s/^cmd:/CMD:/; # basic command undeleteing
        my $result = &getFactoid($faqtoid." #DEL#");
        my $check  = &getFactoid($faqtoid);
 
@@ -323,7 +325,7 @@ sub FactoidStuff {
 #      &setFactInfo($faqtoid, "modified_time", 0);
 
        $check  = &getFactoid($faqtoid);
-       # todo: check if $faqtoid." #DEL#" exists?
+       # TODO: check if $faqtoid." #DEL#" exists?
        if (defined $check) {
            &performReply("Successfully recovered '$faqtoid'.  Have fun now.");
            $count{'Undelete'}++;
@@ -380,16 +382,14 @@ sub FactoidStuff {
            my ($from,$to) = (lc $1, lc $2);
 
            my $result = &getFactoid($from);
-           if (defined $result) {
-               &performReply("i didn't have anything called '$from'");
+           if (!defined $result) {
+               &performReply("i didn't have anything called '$from' to rename");
                return;
            }
 
-           my $author = &getFactInfo($from, "created_by");
-
            # who == nick!user@host.
            if (&IsFlag("m") ne "m" and $author !~ /^\Q$who\E\!/i) {
-               &msg($who, "factoid '$form' is not yours to modify.");
+               &msg($who, "factoid '$from' is not yours to modify.");
                return;
            }
 
@@ -447,7 +447,7 @@ sub FactoidStuff {
                &performReply("that doesn't contain '$op'");
            }
        } else {
-           &performReply("i didn't have anything called '$faqtoid'");
+           &performReply("i didn't have anything called '$faqtoid' to modify");
        }
 
        return;
@@ -496,8 +496,8 @@ sub FactoidStuff {
     if (defined $result and $result !~ /^0?$/) {       # question.
        &status("question: <$who> $message");
        $count{'Question'}++;
-    } elsif (&IsChanConf("perlMath") > 0 and $addressed) { # perl math.
-       &loadMyModule("perlMath");
+    } elsif (&IsChanConf('Math') > 0 and $addressed) { # perl math.
+       &loadMyModule('Math');
        my $newresult = &perlMath();
 
        if (defined $newresult and $newresult ne "") {
@@ -513,7 +513,7 @@ sub FactoidStuff {
     }
 
     # why would a friendly bot get passed here?
-    if (&IsParam("friendlyBots")) {
+    if (&IsParam('friendlyBots')) {
        return if (grep lc($_) eq lc($who), split(/\s+/, $param{'friendlyBots'}));
     }