$lock_for_pid, $transactional);
# global vars
-$ENV{'PATH'} = "/bin:/usr/bin:/usr/local/bin";
+$ENV{'PATH'} = "/bin:/usr/bin:/usr/local/bin:/org/wanna-build/bin/";
$verbose = 0;
$mail_logs = "";
@curr_time = gmtime;
if !isin( $list_state, qw(needs-build building uploaded
built build-attempted failed installed dep-wait
not-for-us all failed-removed
- install-wait reupload-wait));} },
+ install-wait reupload-wait bd-uninstallable));} },
# options with args
dist =>
{ short => "d", arg => \$distribution,
export => { arg => \$export_to, mode => "export" },
"lock-for" => { arg => \$lock_for_pid, mode => "lock-for" },
"unlock-for" => { arg => \$lock_for_pid, mode => "unlock-for" },
- "act-on-behalve-of" => { arg => \$lock_for_pid },
+ "act-on-behalf-of" => { arg => \$lock_for_pid },
"start-transaction" => { mode => "start-transaction" },
"commit-transaction" => { mode => "commit-transaction" },
"transactional" => { flag => \$transactional },
parse_quinn_diff(0);
@ARGV = ( $ARGS[2] );
my $build_deps = parse_sources(1);
- call_edos_depcheck( $ARGS[0], $ARGS[2] );
+ call_edos_depcheck( $ARGS[0] );
clean_db();
last SWITCH;
};
$ok = 0;
$reason = "not all source dependencies available yet";
}
+ elsif ($pkg->{'State'} =~ /^BD-Uninstallable/) {
+ $ok = 0;
+ $reason = "source dependencies are not installable";
+ }
elsif ($pkg->{'State'} eq "Uploaded" &&
(version_lesseq($version, $pkg->{'Version'}))) {
$ok = 0;
print "$name: Warning: marked as waiting for dependencies, ".
"but processing anyway.\n";
}
+ elsif ($state eq "BD-Uninstallable") {
+ print "$name: Warning: marked as having uninstallable build-dependencies, ".
+ "but processing anyway.\n";
+ }
elsif ($state eq "Failed") {
print "$name: already registered as failed; will append new message\n"
if $fail_reason;
return;
}
}
+ if ($state eq "BD-Uninstallable") {
+ if ($opt_override) {
+ print "$name: Forcing uninstallability mark to be removed\n";
+ }
+ else {
+ print "$name: has uninstallable build-dependencies. Skipping\n",
+ " (use --override to clear dependency list and ",
+ "give back anyway)\n";
+ return;
+ }
+ }
elsif (!isin( $state, qw(Building Built Build-Attempted))) {
print "$name: not taken for building (state is $state).";
if ($opt_override) {
print "$name: merging with previously registered dependencies\n";
}
- if (isin( $state, qw(Needs-Build Failed))) {
+ if (isin( $state, qw(Needs-Build Failed BD-Uninstallable))) {
print "$name: Warning: not registered for building previously, ".
"but processing anyway.\n";
}
next if (defined $srcver{$name} and version_less( $version, $srcver{$name} ));
$srcver{$name} = $version;
- if ($buildconf) {
- $buildconf = join( ", ", map { "!$_" } split( /\s*,\s*/, $buildconf ));
- if ($builddep) {
- $builddep .= "," . $buildconf;
- } else {
- $builddep = $buildconf;
- }
- }
- $pkgs{$name}{'dep'} = defined $builddep ? $builddep : "";
$pkgs{$name}{'ver'} = $version;
$pkgs{$name}{'bin'} = $binaries;
my $pkg = $db{$name};
$pkg->{'Section'} = $section, $change++
if defined $section and (not defined($pkg->{'Section'}) or $pkg->{'Section'} ne $section);
+
+ # Store Build-Deps and Build-Conflicts for edos-debcheck later
+ $pkg->{'Build-Depends'} = $builddep, $change++
+ if ($pkg->{'Build-Depends'} ne $builddep);
+ $pkg->{'Build-Conflicts'} = $buildconf, $change++
+ if ($pkg->{'Build-Conflicts'} ne $buildconf);
+
+ # Remove field from previous wanna-build versions
+ delete $pkg->{$_}, $change++
+ if (exists $pkg->{$_})
+ for (qw/Reason/);
+
$db{$name} = $pkg if $change;
}
}
}
# Now re-check the DB for packages in states Needs-Build, Failed,
- # or Dep-Wait and remove them if they're not listed anymore by quinn-diff.
+ # Dep-Wait or BD-Uninstallable and remove them if they're not listed
+ # anymore by quinn-diff.
if ( !$partial ) {
my $name;
foreach $name (keys %db) {
my $pkg = $db{$name};
next if defined $pkg->{'Binary-NMU-Version'};
next if !isin( $pkg->{'State'},
- qw(Needs-Build Building Built Build-Attempted Uploaded Failed Dep-Wait) );
+ qw(Needs-Build Building Built Build-Attempted Uploaded Failed Dep-Wait BD-Uninstallable) );
my $virtual_delete = $pkg->{'State'} eq 'Failed';
if (!$quinn_pkgs{$name}) {
if $pkg->{'State'} =~ /^Failed/;
print " Dependencies: $pkg->{'Depends'}\n"
if $pkg->{'State'} eq "Dep-Wait";
+ print " Reason: $pkg->{'BD-Problem'}\n"
+ if $pkg->{'State'} eq "BD-Uninstallable";
print " Previous state was $pkg->{'Previous-State'} until ",
"$pkg->{'State-Change'}\n"
if $verbose && $pkg->{'Previous-State'};
die "Bad state $pkg->{'State'} of package $pkg->{Package}\n"
if !isin( $pkg->{'State'},
qw(Needs-Build Building Built Build-Attempted Uploaded Installed Dep-Wait
- Failed Failed-Removed Not-For-Us
+ Failed Failed-Removed Not-For-Us BD-Uninstallable
) );
}
delete $pkg->{'Failed'};
delete $pkg->{'Failed-Category'};
}
+ if (defined($$state) and $$state eq 'BD-Uninstallable') {
+ delete $pkg->{'BD-Problem'};
+ }
$$state = $newstate;
}
sub call_edos_depcheck {
my $packagesfile = shift;
- my $sourcesfile = shift;
my $key;
return if defined ($conf::distributions{$distribution}{noadw});
#print "I would look at these sources with edos-depcheck:\n";
#print join " ", keys %interesting_packages,"\n";
- open(EDOS,"-|","wb-edos-builddebcheck", "-a", $arch, $packagesfile, $sourcesfile)
- or die "Failed to run wb-edos-builddebcheck: $!\n";
+ my $tmpfile_pattern = "/tmp/wanna-build-interesting-sources-$distribution.$$-";
+ my ($tmpfile, $i);
+ for( $i = 0;; ++$i ) {
+ $tmpfile = $tmpfile_pattern . $i;
+ last if ! -e $tmpfile;
+ }
- local($/) = ""; # read in paragraph mode
- while( <EDOS> ) {
- my( $key, $reason ) ;
- s/\s*$//m;
- /^Package:\s*(\S+)$/mi and $key = $1;
- /^Failed-Why:(([^\n]|\n ([^\n]|\.))*)$/msi and $reason = $1;
- $reason =~ s/^\s*//mg;
+ open SOURCES, '>', $tmpfile or die "Could not open temporary file $tmpfile\n";
+ for my $key (keys %interesting_packages) {
+ my $pkg = $db{$key};
+ print SOURCES "Package: $key\n";
+ print SOURCES "Version: $pkg->{'Version'}\n";
+ print SOURCES "Build-Depends: $pkg->{'Build-Depends'}\n" if $pkg->{'Build-Depends'};
+ print SOURCES "Build-Conflicts: $pkg->{'Build-Conflicts'}\n" if $pkg->{'Build-Conflicts'};
+ print SOURCES "Architecture: all\n";
+ print SOURCES "\n";
+ }
+ close SOURCES;
- if (exists $interesting_packages{$key}) {
- $interesting_packages{$key} = $reason;
- } else {
- print "TODO: edos reported a package we do not care about now" if $verbose;
- }
+ if (open(EDOS,"-|","wb-edos-builddebcheck", "-a", $arch, $packagesfile, $tmpfile))
+ {
+ local($/) = ""; # read in paragraph mode
+ while( <EDOS> ) {
+ my( $key, $reason ) ;
+ s/\s*$//m;
+ /^Package:\s*(\S+)$/mi and $key = $1;
+ /^Failed-Why:(([^\n]|\n ([^\n]|\.))*)$/msi and $reason = $1;
+ $reason =~ s/^\s*//mg;
+ $reason ||= 'No reason given by edos-debcheck';
+
+ if (exists $interesting_packages{$key}) {
+ $interesting_packages{$key} = $reason;
+ } else {
+ #print "TODO: edos reported a package we do not care about now\n" if $verbose;
+ }
+ }
+ close EDOS;
+ } else {
+ print "ERROR: Could not run wb-edos-builddebcheck. I am continuing, assuming\n" .
+ "all packages have installable build-dependencies."
}
- close EDOS;
+
+ unlink( $tmpfile );
for my $key (keys %interesting_packages) {
my $pkg = $db{$key};
my $change =
- (defined $interesting_packages{$key} && $pkg->{'State'} eq 'Needs-Build') ||
- (not defined $interesting_packages{$key} && $pkg->{'State'} eq 'BD-Uninstallable');
+ (defined $interesting_packages{$key} and $pkg->{'State'} eq 'Needs-Build') ||
+ (not defined $interesting_packages{$key} and $pkg->{'State'} eq 'BD-Uninstallable');
if ($change) {
if (defined $interesting_packages{$key}) {
- $pkg->{'State'} = 'BD-Uninstallable';
- $pkg->{'Reason'} = $interesting_packages{$key};
change_state( \$pkg, 'BD-Uninstallable' );
+ $pkg->{'BD-Problem'} = $interesting_packages{$key};
} else {
- $pkg->{'State'} = 'Needs-Build';
- delete $pkg->{'Reason'};
change_state( \$pkg, 'Needs-Build' );
}
log_ta( $pkg, "--merge-all" );
--export FILE: Export database to a ASCII file FILE
--lock-for PID: Locks the database for the process with this pid
--unlock-for PID: Unlocks the database for the process with this pid
- --act-on-behalve-of PID: Ignores the log (if it is held by this pid)
+ --act-on-behalf-of PID: Ignores the log (if it is held by this pid)
--start-transaction: Creates a copy of the state of the database, for
use with --transactional. This overrides any previous uncommited
transaction. Should only be used after --lock-for