package conf;
# defaults
-$basedir = "/var/lib/debbuild";
-$dbbase = "build-db";
-$transactlog = "transactions.log";
-$mailprog = "/usr/sbin/sendmail";
+$basedir ||= "/var/lib/debbuild";
+$dbbase ||= "build-db";
+$transactlog ||= "transactions.log";
+$mailprog ||= "/usr/sbin/sendmail";
require "/etc/wanna-build.conf";
die "$conf::basedir is not a directory\n" if ! -d $conf::basedir;
die "dbbase is empty\n" if ! $dbbase;
our ($verbose, $mail_logs, $list_order, $list_state,
$curr_date, $op_mode, $user, $real_user, $distribution,
$fail_reason, $opt_override, $import_from, $export_to, $opt_create_db,
- $transactlog, %db, %otherdb, %otherdb_lock, %prioval, %sectval,
+ %db, %otherdb, %otherdb_lock, %prioval, %sectval,
$info_all_dists, $arch,
$category, %catval, %short_category,
$short_date, $list_min_age, $dbbase, @curr_time,
$lock_for_pid, $transactional);
# global vars
-$ENV{'PATH'} = "/bin:/usr/bin:/usr/local/bin";
+$ENV{'PATH'} = "/bin:/usr/bin:/usr/local/bin:/org/wanna-build/bin/";
$verbose = 0;
$mail_logs = "";
@curr_time = gmtime;
if !isin( $list_state, qw(needs-build building uploaded
built build-attempted failed installed dep-wait
not-for-us all failed-removed
- install-wait reupload-wait));} },
+ install-wait reupload-wait bd-uninstallable));} },
# options with args
dist =>
{ short => "d", arg => \$distribution,
export => { arg => \$export_to, mode => "export" },
"lock-for" => { arg => \$lock_for_pid, mode => "lock-for" },
"unlock-for" => { arg => \$lock_for_pid, mode => "unlock-for" },
- "act-on-behalve-of" => { arg => \$lock_for_pid },
+ "act-on-behalf-of" => { arg => \$lock_for_pid },
"start-transaction" => { mode => "start-transaction" },
"commit-transaction" => { mode => "commit-transaction" },
"transactional" => { flag => \$transactional },
$distribution ||= "unstable";
die "Bad distribution '$distribution'\n"
if !isin($distribution, keys %conf::distributions);
-$conf::dbbase =~ m#^([^/]+/)#;
-$transactlog = "$conf::basedir/$1$conf::transactlog";
if ($verbose) {
my $version = '$Revision: db181a534e9d $ $Date: 2008/03/26 06:20:22 $ $Author: rmurray $';
while(!eof(STDIN)) {
$line = <STDIN>;
last if $line eq ".\n";
- $line = ".\n" if $line eq "\n";
$fail_reason .= $line;
}
chomp( $fail_reason );
if ($op_mode eq "start-transaction") {
copy ( db_filename_master( $distribution ), db_filename_transaction( $distribution ))
or die "Copy failed: $!";
+ open LOG, ">", db_transactlog_transaction( $distribution )
+ or die "Could not create logfile for transaction: $!";
+ close LOG;
exit 0;
}
if ($op_mode eq "commit-transaction") {
- move ( db_filename_transaction( $distribution ), db_filename_master( $distribution ))
+ # we need to copy here to preserve the owner and group of the file
+ copy ( db_filename_transaction( $distribution ), db_filename_master( $distribution ))
or die "Copy failed: $!";
+ unlink db_filename_transaction( $distribution );
+ open TLOG, "<", db_transactlog_transaction( $distribution )
+ or die "Could not open logfile from transaction: $!";
+ open LOG, ">>", db_transactlog_master( $distribution )
+ or die "Could not open logfile: $!";
+ while (<TLOG>) { print LOG $_ };
+ close TLOG;
+ close LOG;
+ unlink db_transactlog_transaction( $distribution );
exit 0;
}
@ARGV = ( $ARGS[1] );
parse_quinn_diff(0);
@ARGV = ( $ARGS[2] );
- my $build_deps = parse_sources(1);
- auto_dep_wait( $build_deps, $pkgs );
+ my $srcs = parse_sources(1);
+ call_edos_depcheck( $ARGS[0], $srcs );
clean_db();
last SWITCH;
};
$ok = 0;
$reason = "not all source dependencies available yet";
}
+ elsif ($pkg->{'State'} =~ /^BD-Uninstallable/) {
+ $ok = 0;
+ $reason = "source dependencies are not installable";
+ }
elsif ($pkg->{'State'} eq "Uploaded" &&
(version_lesseq($version, $pkg->{'Version'}))) {
$ok = 0;
print "$name: Warning: marked as waiting for dependencies, ".
"but processing anyway.\n";
}
+ elsif ($state eq "BD-Uninstallable") {
+ print "$name: Warning: marked as having uninstallable build-dependencies, ".
+ "but processing anyway.\n";
+ }
elsif ($state eq "Failed") {
print "$name: already registered as failed; will append new message\n"
if $fail_reason;
}
$state = $pkg->{'State'};
- if ($state eq "Dep-Wait") {
+ if ($state eq "BD-Uninstallable") {
+ if ($opt_override) {
+ print "$name: Forcing uninstallability mark to be removed. This is not permanent and might be reset with the next trigger run\n";
+
+ change_state( \$pkg, 'Needs-Build' );
+ delete $pkg->{'Builder'};
+ delete $pkg->{'Depends'};
+ log_ta( $pkg, "--give-back" );
+ $db{$name} = $pkg;
+ print "$name: given back\n" if $verbose;
+ return;
+ }
+ else {
+ print "$name: has uninstallable build-dependencies. Skipping\n",
+ " (use --override to clear dependency list and ",
+ "give back anyway)\n";
+ return;
+ }
+ }
+ elsif ($state eq "Dep-Wait") {
if ($opt_override) {
print "$name: Forcing source dependency list to be cleared\n";
}
"Skipping.\n";
return;
}
- change_state( \$pkg, 'Needs-Build' );
+ change_state( \$pkg, 'BD-Uninstallable' );
+ $pkg->{'BD-Problem'} = "Installability of build dependencies not tested yet";
delete $pkg->{'Builder'};
delete $pkg->{'Depends'};
log_ta( $pkg, "--give-back" );
return;
}
- change_state( \$pkg, 'Needs-Build' );
+ change_state( \$pkg, 'BD-Uninstallable' );
+ $pkg->{'BD-Problem'} = "Installability of build dependencies not tested yet";
delete $pkg->{'Builder'};
delete $pkg->{'Depends'};
$pkg->{'Binary-NMU-Version'} = $binNMUver;
print "$name: merging with previously registered dependencies\n";
}
- if (isin( $state, qw(Needs-Build Failed))) {
+ if (isin( $state, qw(Needs-Build Failed BD-Uninstallable))) {
print "$name: Warning: not registered for building previously, ".
"but processing anyway.\n";
}
next if (defined $srcver{$name} and version_less( $version, $srcver{$name} ));
$srcver{$name} = $version;
- if ($buildconf) {
- $buildconf = join( ", ", map { "!$_" } split( /\s*,\s*/, $buildconf ));
- if ($builddep) {
- $builddep .= "," . $buildconf;
- } else {
- $builddep = $buildconf;
- }
- }
- $pkgs{$name}{'dep'} = defined $builddep ? $builddep : "";
$pkgs{$name}{'ver'} = $version;
$pkgs{$name}{'bin'} = $binaries;
+ $pkgs{$name}{'dep'} = $builddep;
+ $pkgs{$name}{'conf'} = $buildconf;
my $pkg = $db{$name};
if (defined $pkg) {
$pkg->{'Section'} = $section, $change++
if defined $section and (not defined($pkg->{'Section'}) or $pkg->{'Section'} ne $section);
+
+ # Remove field from previous wanna-build versions
+ for (qw/Reason Build-Depends Build-Conflicts/) {
+ if (exists $pkg->{$_}) {
+ delete $pkg->{$_};
+ $change++;
+ }
+ }
+
$db{$name} = $pkg if $change;
}
}
}
# Now re-check the DB for packages in states Needs-Build, Failed,
- # or Dep-Wait and remove them if they're not listed anymore by quinn-diff.
+ # Dep-Wait or BD-Uninstallable and remove them if they're not listed
+ # anymore by quinn-diff.
if ( !$partial ) {
my $name;
foreach $name (keys %db) {
my $pkg = $db{$name};
next if defined $pkg->{'Binary-NMU-Version'};
next if !isin( $pkg->{'State'},
- qw(Needs-Build Building Built Build-Attempted Uploaded Failed Dep-Wait) );
+ qw(Needs-Build Building Built Build-Attempted Uploaded Failed Dep-Wait BD-Uninstallable) );
my $virtual_delete = $pkg->{'State'} eq 'Failed';
if (!$quinn_pkgs{$name}) {
if $pkg->{'State'} =~ /^Failed/;
print " Dependencies: $pkg->{'Depends'}\n"
if $pkg->{'State'} eq "Dep-Wait";
+ print " Reason: $pkg->{'BD-Problem'}\n"
+ if $pkg->{'State'} eq "BD-Uninstallable";
print " Previous state was $pkg->{'Previous-State'} until ",
"$pkg->{'State-Change'}\n"
if $verbose && $pkg->{'Previous-State'};
my $val = $pkg->{$key};
chomp( $val );
$val = "\n$val" if isin( $key, qw(Failed Old-Failed));
- $val =~ s/\n/\n /g;
+ $val =~ s/\n/\n /g;
printf " %-20s: %s\n", $key, $val;
}
foreach $key (sort keys %$pkg) {
my $val = $pkg->{$key};
chomp( $val );
$val = "\n$val" if isin( $key, qw(Failed Old-Failed));
- $val =~ s/\n/\n /g;
+ $val =~ s/\n/\n /g;
printf " %-20s: %s\n", $key, $val;
}
}
sub lock_db {
my $dist = shift;
my $try = 0;
- my $lockfile = db_filename($dist) . ".lock";
+ my $lockfile = db_lockfilename($dist);
local( *F );
print "Locking $dist database\n" if $verbose >= 2;
sub unlock_db {
my $dist = shift;
- my $lockfile = db_filename($dist) . ".lock";
+ my $lockfile = db_lockfilename($dist);
if (!$main::keep_lock{$dist}) {
print "Unlocking $dist database\n" if $verbose >= 2;
}
sub create_maintlock {
- my $lockfile = db_filename("maintenance") . ".lock";
+ my $lockfile = db_lockfilename("maintenance");
my $try = 0;
local( *F );
}
sub remove_maintlock {
- my $lockfile = db_filename("maintenance") . ".lock";
+ my $lockfile = db_lockfilename("maintenance");
print "Removing maintenance lock\n" if $verbose >= 2;
unlink $lockfile;
}
sub waitfor_maintlock {
- my $lockfile = db_filename("maintenance") . ".lock";
+ my $lockfile = db_lockfilename("maintenance");
my $try = 0;
local( *F );
die "Bad state $pkg->{'State'} of package $pkg->{Package}\n"
if !isin( $pkg->{'State'},
qw(Needs-Build Building Built Build-Attempted Uploaded Installed Dep-Wait
- Failed Failed-Removed Not-For-Us
+ Failed Failed-Removed Not-For-Us BD-Uninstallable
) );
}
if (!defined($ui->{'User'}));
foreach $key (keys %{$ui}) {
my $val = $ui->{$key};
- chomp($val);
- $val =~ s/\n/\n /g;
+ $val =~ s/\n*$//;
+ $val =~ s/^/ /mg;
+ $val =~ s/^ +$/ ./mg;
print F "$key: $val\n";
}
print F "\n";
else {
foreach $key (keys %{$pkg}) {
my $val = $pkg->{$key};
- chomp( $val );
- $val =~ s/\n/\n /g;
+ $val =~ s/\n*$//;
+ $val =~ s/^/ /mg;
+ $val =~ s/^ +$/ ./mg;
print F "$key: $val\n";
}
print F "\n";
delete $pkg->{'Failed'};
delete $pkg->{'Failed-Category'};
}
+ if (defined($$state) and $$state eq 'BD-Uninstallable') {
+ delete $pkg->{'BD-Problem'};
+ }
$$state = $newstate;
}
"changed from $prevstate to $pkg->{'State'} ".
"by $real_user as $user";
+ my $transactlog = db_transactlog( $distribution );
if (!open( LOG, ">>$transactlog" )) {
warn "Can't open log file $transactlog: $!\n";
return;
my $dist = shift;
return $transactional ? db_filename_transaction($dist) : db_filename_master($dist);
}
-
sub db_filename_master {
my $dist = shift;
return "$conf::basedir/$conf::dbbase-$dist";
return "$conf::basedir/$conf::dbbase-$dist-transaction";
}
+sub db_lockfilename {
+ my $dist = shift;
+ return db_filename_master($dist) . ".lock";
+}
+
+
+sub db_transactlog {
+ my $dist = shift;
+ return $transactional ? db_transactlog_transaction($dist) : db_transactlog_master($dist);
+}
+sub db_transactlog_master {
+ my $dist = shift;
+ $conf::dbbase =~ m#^([^/]+/)#;
+ return "$conf::basedir/$1$conf::transactlog";
+}
+sub db_transactlog_transaction {
+ my $dist = shift;
+ $conf::dbbase =~ m#^([^/]+/)#;
+ return "$conf::basedir/$1$conf::transactlog-$dist-transaction";
+}
+
# for parsing input to dep-wait
sub parse_deplist {
my $deps = shift;
return "";
}
-sub auto_dep_wait {
- my $bd = shift;
- my $pkgs = shift;
+sub call_edos_depcheck {
+ my $packagesfile = shift;
+ my $srcs = shift;
my $key;
return if defined ($conf::distributions{$distribution}{noadw});
- # We need to walk all of needs-build, as any new upload could make
+ # We need to check all of needs-build, as any new upload could make
# something in needs-build have uninstallable deps
+ # We also check everything in bd-uninstallable, as any new upload could
+ # make that work again
+ my %interesting_packages;
foreach $key (keys %db) {
my $pkg = $db{$key};
- next
- if not defined $pkg or $pkg->{'State'} ne "Needs-Build";
- my $srcdeps = parse_srcdeplist($key,$bd->{$key}{'dep'},$arch);
- foreach my $srcdep (@$srcdeps) {
- next if $srcdep->{'Neg'} != 0; # we ignore conflicts atm
- my $rc = get_unsatisfied_dep($bd,$pkgs,$srcdep,0);
- if ($rc ne "") {
- # set dep-wait
- my $deplist = parse_deplist( $pkg->{'Depends'} );
- my $newdeps = parse_deplist( $rc );
- my $change = 0;
- foreach (%$newdeps) {
- my $dep = $$newdeps{$_};
- # ensure we're not waiting on ourselves, or a package that has been removed
- next if (not defined($merge_binsrc{$dep->{'Package'}})) or ($merge_binsrc{$dep->{'Package'}} eq $key);
- if ($dep->{'Rel'} =~ '^>') {
- $deplist->{$dep->{'Package'}} = $dep;
- $change++;
- }
- }
- if ($change) {
- $pkg->{'Depends'} = build_deplist($deplist);
- change_state( \$pkg, 'Dep-Wait' );
- log_ta( $pkg, "--merge-all" );
- $db{$key} = $pkg;
- print "Auto-Dep-Waiting ${key}_$pkg->{'Version'} to $pkg->{'Depends'}\n" if $verbose;
- }
- last;
- }
+ if (defined $pkg and isin($pkg->{'State'}, qw/Needs-Build BD-Uninstallable/)) {
+ $interesting_packages{$key} = undef;
+ }
+ }
+
+ #print "I would look at these sources with edos-depcheck:\n";
+ #print join " ", keys %interesting_packages,"\n";
+
+ my $tmpfile_pattern = "/tmp/wanna-build-interesting-sources-$distribution.$$-";
+ my ($tmpfile, $i);
+ for( $i = 0;; ++$i ) {
+ $tmpfile = $tmpfile_pattern . $i;
+ last if ! -e $tmpfile;
+ }
+
+ open SOURCES, '>', $tmpfile or die "Could not open temporary file $tmpfile\n";
+ for my $key (keys %interesting_packages) {
+ my $pkg = $db{$key};
+ print SOURCES "Package: $key\n";
+ print SOURCES "Version: $pkg->{'Version'}\n";
+ print SOURCES "Build-Depends: $srcs->{$key}{'dep'}\n" if $srcs->{$key}{'dep'};
+ print SOURCES "Build-Conflicts: $srcs->{$key}{'conf'}\n" if $srcs->{$key}{'conf'};
+ print SOURCES "Architecture: all\n";
+ print SOURCES "\n";
+ }
+ close SOURCES;
+
+ if (open(EDOS,"-|","wb-edos-builddebcheck", "-a", $arch, $packagesfile, $tmpfile))
+ {
+ local($/) = ""; # read in paragraph mode
+ while( <EDOS> ) {
+ my( $key, $reason ) ;
+ s/\s*$//m;
+ /^Package:\s*(\S+)$/mi and $key = $1;
+ /^Failed-Why:(([^\n]|\n ([^\n]|\.))*)$/msi and $reason = $1;
+ $reason =~ s/^\s*//mg;
+ $reason ||= 'No reason given by edos-debcheck';
+
+ if (exists $interesting_packages{$key}) {
+ $interesting_packages{$key} = $reason;
+ } else {
+ #print "TODO: edos reported a package we do not care about now\n" if $verbose;
+ }
+ }
+ close EDOS;
+ } else {
+ print "ERROR: Could not run wb-edos-builddebcheck. I am continuing, assuming\n" .
+ "all packages have installable build-dependencies."
+ }
+
+ unlink( $tmpfile );
+
+ for my $key (keys %interesting_packages) {
+ my $pkg = $db{$key};
+ my $change =
+ (defined $interesting_packages{$key} and $pkg->{'State'} eq 'Needs-Build') ||
+ (not defined $interesting_packages{$key} and $pkg->{'State'} eq 'BD-Uninstallable');
+ my $problemchange = $interesting_packages{$key} ne $pkg->{'BD-Problem'};
+ if ($change) {
+ if (defined $interesting_packages{$key}) {
+ change_state( \$pkg, 'BD-Uninstallable' );
+ $pkg->{'BD-Problem'} = $interesting_packages{$key};
+ } else {
+ change_state( \$pkg, 'Needs-Build' );
+ }
+ }
+ if ($problemchange) {
+ if (defined $interesting_packages{$key}) {
+ $pkg->{'BD-Problem'} = $interesting_packages{$key};
+ }
+ }
+ if ($change) {
+ log_ta( $pkg, "--merge-all" );
+ print "edos-builddebchange changed state of ${key}_$pkg->{'Version'} to $pkg->{'State'}\n" if $verbose;
+ }
+ if ($change || $problemchange) {
+ $db{$key} = $pkg;
}
}
}
for some source dependencies to become available
--binNMU num: Schedule a re-build of the package with unchanged source, but
a new version number (source-version + "+b<num>")
+ --give-back: Mark a package as ready to build that is in state Building,
+ Built or Build-Attempted. To give back a package in state Failed, use
+ --override. This command will actually put the package in state
+ BD-Uninstallable, until the installability of its Build-Dependencies
+ were verified. This happens at each call of --merge-all, usually
+ every 15 minutes.
--merge-quinn: Merge quinn-diff output into database.
--merge-packages: Merge Packages files into database.
--pretend-avail: Pretend that given packages are available now and give
--export FILE: Export database to a ASCII file FILE
--lock-for PID: Locks the database for the process with this pid
--unlock-for PID: Unlocks the database for the process with this pid
- --act-on-behalve-of PID: Ignores the log (if it is held by this pid)
+ --act-on-behalf-of PID: Ignores the lock (if it is held by this pid)
--start-transaction: Creates a copy of the state of the database, for
use with --transactional. This overrides any previous uncommited
transaction. Should only be used after --lock-for