type => 'bcc',
);
}
- if (defined(getmaintainers()->{$p})) {
- $addmaint= getmaintainers()->{$p};
- print {$param{debug}} "MR|$addmaint|$p|$ref|\n";
- _add_address(recipients => $param{recipients},
- address => $addmaint,
- reason => $p,
- bug_num => $param{data}{bug_num},
- type => 'cc',
- );
- print {$param{debug}} "maintainer add >$p|$addmaint<\n";
+ my @maints = package_maintainer(binary => $p);
+ if (@maints) {
+ print {$param{debug}} "MR|".join(',',@maints)."|$p|$ref|\n";
+ _add_address(recipients => $param{recipients},
+ address => \@maints,
+ reason => $p,
+ bug_num => $param{data}{bug_num},
+ type => 'cc',
+ );
+ print {$param{debug}} "maintainer add >$p|".join(',',@maints)."<\n";
}
- else {
+ else {
print {$param{debug}} "maintainer none >$p<\n";
print {$param{transcript}} "Warning: Unknown package '$p'\n";
print {$param{debug}} "MR|unknown-package|$p|$ref|\n";
$level = 'cc';
}
}
- # strip out all non-word non-spaces
- $reason =~ s/[^\ \w]//g;
+ # RFC 2822 comments cannot contain specials and
+ # unquoted () or \; there's no reason for us to allow
+ # insane things here, though, so we restrict this even
+ # more to 20-7E ( -~)
+ $reason =~ s/\\/\\\\/g;
+ $reason =~ s/([\)\(])/\\$1/g;
+ $reason =~ s/[^\x20-\x7E]//g;
push @reasons, $reason . ' for {'.join(',',@bugs).'}';
}
if ($param{address_only}) {
}
for (qw(to cc bcc)) {
if ($param{$_}) {
- return @{$final_recipients{$_}};
+ if (exists $final_recipients{$_}) {
+ return @{$final_recipients{$_}||[]};
+ }
+ return ();
}
}
return %final_recipients;