fix the spam lockfile name

[debbugs.git] / Debbugs / Log / Spam.pm

diff --git a/Debbugs/Log/Spam.pm b/Debbugs/Log/Spam.pm
index 9a9f21675d02330dd6679677c6f77e7363266077..ab0bc7c694134df3b7ecb4b39fe4fce09ffc3cf2 100644 (file)
--- a/Debbugs/Log/Spam.pm
+++ b/Debbugs/Log/Spam.pm
@@ -45,7 +45,7 @@ BEGIN{
 use Carp;
 use feature 'state';
 use Params::Validate qw(:types validate_with);
-use Debbugs::Common qw(getbuglocation getbugcomponent);
+use Debbugs::Common qw(getbuglocation getbugcomponent filelock unfilelock);
 
 =head1 FUNCTIONS
 
@@ -135,7 +135,8 @@ Saves changes to the bug log spam file.
 
 sub save {
     my $self = shift;
-    filelock($self->{name});
+    return unless keys %{$self->{spam}};
+    filelock($self->{name}.'.lock');
     open(my $fh,'>',$self->{name}.'.tmp') or
         croak "Unable to open bug log spam '$self->{name}.tmp' for writing: $!";
     binmode($fh,':encoding(UTF-8)');
@@ -158,6 +159,7 @@ Returns 0 if this message is not spam
 =cut
 sub is_spam {
     my ($self,$msgid) = @_;
+    return 0 if not defined $msgid or not length $msgid;
     $msgid =~ s/^<|>$//;
     if (exists $self->{spam}{$msgid} and
         $self->{spam}{$msgid}
@@ -185,6 +187,10 @@ sub add_spam {
 
 1;
 
+=back
+
+=cut
+
 __END__
 
 # Local Variables: