3 # Checks Debian packages from Incoming
4 # Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005, 2006 James Troup <james@nocrew.org>
6 # This program is free software; you can redistribute it and/or modify
7 # it under the terms of the GNU General Public License as published by
8 # the Free Software Foundation; either version 2 of the License, or
9 # (at your option) any later version.
11 # This program is distributed in the hope that it will be useful,
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 # GNU General Public License for more details.
16 # You should have received a copy of the GNU General Public License
17 # along with this program; if not, write to the Free Software
18 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
20 # Originally based on dinstall by Guy Maor <maor@debian.org>
22 ################################################################################
24 # Computer games don't affect kids. I mean if Pacman affected our generation as
25 # kids, we'd all run around in a darkened room munching pills and listening to
29 ################################################################################
31 import commands, errno, fcntl, os, re, shutil, stat, sys, time, tempfile, traceback
32 import apt_inst, apt_pkg
33 import daklib.database
40 ################################################################################
42 re_valid_version = re.compile(r"^([0-9]+:)?[0-9A-Za-z\.\-\+:~]+$")
43 re_valid_pkg_name = re.compile(r"^[\dA-Za-z][\dA-Za-z\+\-\.]+$")
44 re_changelog_versions = re.compile(r"^\w[-+0-9a-z.]+ \([^\(\) \t]+\)")
45 re_strip_revision = re.compile(r"-([^-]+)$")
46 re_strip_srcver = re.compile(r"\s+\(\S+\)$")
48 ################################################################################
59 # Aliases to the real vars in the Upload class; hysterical raisins.
67 ###############################################################################
70 global Cnf, Options, Upload, changes, dsc, dsc_files, files, pkg
74 Cnf = apt_pkg.newConfiguration()
75 apt_pkg.ReadConfigFileISC(Cnf,daklib.utils.which_conf_file())
77 Arguments = [('a',"automatic","Dinstall::Options::Automatic"),
78 ('h',"help","Dinstall::Options::Help"),
79 ('n',"no-action","Dinstall::Options::No-Action"),
80 ('p',"no-lock", "Dinstall::Options::No-Lock"),
81 ('s',"no-mail", "Dinstall::Options::No-Mail")]
83 for i in ["automatic", "help", "no-action", "no-lock", "no-mail",
84 "override-distribution", "version"]:
85 Cnf["Dinstall::Options::%s" % (i)] = ""
87 changes_files = apt_pkg.ParseCommandLine(Cnf,Arguments,sys.argv)
88 Options = Cnf.SubTree("Dinstall::Options")
93 Upload = daklib.queue.Upload(Cnf)
95 changes = Upload.pkg.changes
97 dsc_files = Upload.pkg.dsc_files
98 files = Upload.pkg.files
103 ################################################################################
105 def usage (exit_code=0):
106 print """Usage: dinstall [OPTION]... [CHANGES]...
107 -a, --automatic automatic run
108 -h, --help show this help and exit.
109 -n, --no-action don't do anything
110 -p, --no-lock don't check lockfile !! for cron.daily only !!
111 -s, --no-mail don't send any mail
112 -V, --version display the version number and exit"""
115 ################################################################################
117 def reject (str, prefix="Rejected: "):
118 global reject_message
120 reject_message += prefix + str + "\n"
122 ################################################################################
124 def copy_to_holding(filename):
127 base_filename = os.path.basename(filename)
129 dest = Cnf["Dir::Queue::Holding"] + '/' + base_filename
131 fd = os.open(dest, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0640)
134 # Shouldn't happen, but will if, for example, someone lists a
135 # file twice in the .changes.
136 if errno.errorcode[e.errno] == 'EEXIST':
137 reject("%s: already exists in holding area; can not overwrite." % (base_filename))
142 shutil.copy(filename, dest)
144 # In either case (ENOENT or EACCES) we want to remove the
145 # O_CREAT | O_EXCLed ghost file, so add the file to the list
146 # of 'in holding' even if it's not the real file.
147 if errno.errorcode[e.errno] == 'ENOENT':
148 reject("%s: can not copy to holding area: file not found." % (base_filename))
151 elif errno.errorcode[e.errno] == 'EACCES':
152 reject("%s: can not copy to holding area: read permission denied." % (base_filename))
157 in_holding[base_filename] = ""
159 ################################################################################
165 os.chdir(Cnf["Dir::Queue::Holding"])
166 for file in in_holding.keys():
167 if os.path.exists(file):
168 if file.find('/') != -1:
169 daklib.utils.fubar("WTF? clean_holding() got a file ('%s') with / in it!" % (file))
175 ################################################################################
178 filename = pkg.changes_file
180 # Parse the .changes field into a dictionary
182 changes.update(daklib.utils.parse_changes(filename))
183 except daklib.utils.cant_open_exc:
184 reject("%s: can't read file." % (filename))
186 except daklib.utils.changes_parse_error_exc, line:
187 reject("%s: parse error, can't grok: %s." % (filename, line))
190 # Parse the Files field from the .changes into another dictionary
192 files.update(daklib.utils.build_file_list(changes))
193 except daklib.utils.changes_parse_error_exc, line:
194 reject("%s: parse error, can't grok: %s." % (filename, line))
195 except daklib.utils.nk_format_exc, format:
196 reject("%s: unknown format '%s'." % (filename, format))
199 # Check for mandatory fields
200 for i in ("source", "binary", "architecture", "version", "distribution",
201 "maintainer", "files", "changes", "description"):
202 if not changes.has_key(i):
203 reject("%s: Missing mandatory field `%s'." % (filename, i))
204 return 0 # Avoid <undef> errors during later tests
206 # Strip a source version in brackets from the source field
207 if re_strip_srcver.search(changes["source"]):
208 changes["source"] = re_strip_srcver.sub('', changes["source"])
210 # Ensure the source field is a valid package name.
211 if not re_valid_pkg_name.match(changes["source"]):
212 reject("%s: invalid source name '%s'." % (filename, changes["source"]))
214 # Split multi-value fields into a lower-level dictionary
215 for i in ("architecture", "distribution", "binary", "closes"):
216 o = changes.get(i, "")
223 # Fix the Maintainer: field to be RFC822/2047 compatible
225 (changes["maintainer822"], changes["maintainer2047"],
226 changes["maintainername"], changes["maintaineremail"]) = \
227 daklib.utils.fix_maintainer (changes["maintainer"])
228 except daklib.utils.ParseMaintError, msg:
229 reject("%s: Maintainer field ('%s') failed to parse: %s" \
230 % (filename, changes["maintainer"], msg))
232 # ...likewise for the Changed-By: field if it exists.
234 (changes["changedby822"], changes["changedby2047"],
235 changes["changedbyname"], changes["changedbyemail"]) = \
236 daklib.utils.fix_maintainer (changes.get("changed-by", ""))
237 except daklib.utils.ParseMaintError, msg:
238 (changes["changedby822"], changes["changedby2047"],
239 changes["changedbyname"], changes["changedbyemail"]) = \
241 reject("%s: Changed-By field ('%s') failed to parse: %s" \
242 % (filename, changes["changed-by"], msg))
244 # Ensure all the values in Closes: are numbers
245 if changes.has_key("closes"):
246 for i in changes["closes"].keys():
247 if daklib.queue.re_isanum.match (i) == None:
248 reject("%s: `%s' from Closes field isn't a number." % (filename, i))
251 # chopversion = no epoch; chopversion2 = no epoch and no revision (e.g. for .orig.tar.gz comparison)
252 changes["chopversion"] = daklib.utils.re_no_epoch.sub('', changes["version"])
253 changes["chopversion2"] = daklib.utils.re_no_revision.sub('', changes["chopversion"])
255 # Check there isn't already a changes file of the same name in one
256 # of the queue directories.
257 base_filename = os.path.basename(filename)
258 for dir in [ "Accepted", "Byhand", "Done", "New", "ProposedUpdates" ]:
259 if os.path.exists(Cnf["Dir::Queue::%s" % (dir) ]+'/'+base_filename):
260 reject("%s: a file with this name already exists in the %s directory." % (base_filename, dir))
262 # Check the .changes is non-empty
264 reject("%s: nothing to do (Files field is empty)." % (base_filename))
269 ################################################################################
271 def check_distributions():
272 "Check and map the Distribution field of a .changes file."
274 # Handle suite mappings
275 for map in Cnf.ValueList("SuiteMappings"):
278 if type == "map" or type == "silent-map":
279 (source, dest) = args[1:3]
280 if changes["distribution"].has_key(source):
281 del changes["distribution"][source]
282 changes["distribution"][dest] = 1
283 if type != "silent-map":
284 reject("Mapping %s to %s." % (source, dest),"")
285 if changes.has_key("distribution-version"):
286 if changes["distribution-version"].has_key(source):
287 changes["distribution-version"][source]=dest
288 elif type == "map-unreleased":
289 (source, dest) = args[1:3]
290 if changes["distribution"].has_key(source):
291 for arch in changes["architecture"].keys():
292 if arch not in Cnf.ValueList("Suite::%s::Architectures" % (source)):
293 reject("Mapping %s to %s for unreleased architecture %s." % (source, dest, arch),"")
294 del changes["distribution"][source]
295 changes["distribution"][dest] = 1
297 elif type == "ignore":
299 if changes["distribution"].has_key(suite):
300 del changes["distribution"][suite]
301 reject("Ignoring %s as a target suite." % (suite), "Warning: ")
302 elif type == "reject":
304 if changes["distribution"].has_key(suite):
305 reject("Uploads to %s are not accepted." % (suite))
306 elif type == "propup-version":
307 # give these as "uploaded-to(non-mapped) suites-to-add-when-upload-obsoletes"
309 # changes["distribution-version"] looks like: {'testing': 'testing-proposed-updates'}
310 if changes["distribution"].has_key(args[1]):
311 changes.setdefault("distribution-version", {})
312 for suite in args[2:]: changes["distribution-version"][suite]=suite
314 # Ensure there is (still) a target distribution
315 if changes["distribution"].keys() == []:
316 reject("no valid distribution.")
318 # Ensure target distributions exist
319 for suite in changes["distribution"].keys():
320 if not Cnf.has_key("Suite::%s" % (suite)):
321 reject("Unknown distribution `%s'." % (suite))
323 ################################################################################
325 def check_deb_ar(filename, control):
326 """Sanity check the ar of a .deb, i.e. that there is:
330 o data.tar.gz or data.tar.bz2
332 in that order, and nothing else. If the third member is a
333 data.tar.bz2, an additional check is performed for the required
334 Pre-Depends on dpkg (>= 1.10.24)."""
335 cmd = "ar t %s" % (filename)
336 (result, output) = commands.getstatusoutput(cmd)
338 reject("%s: 'ar t' invocation failed." % (filename))
339 reject(daklib.utils.prefix_multi_line_string(output, " [ar output:] "), "")
340 chunks = output.split('\n')
342 reject("%s: found %d chunks, expected 3." % (filename, len(chunks)))
343 if chunks[0] != "debian-binary":
344 reject("%s: first chunk is '%s', expected 'debian-binary'." % (filename, chunks[0]))
345 if chunks[1] != "control.tar.gz":
346 reject("%s: second chunk is '%s', expected 'control.tar.gz'." % (filename, chunks[1]))
347 if chunks[2] == "data.tar.bz2":
348 # Packages using bzip2 compression must have a Pre-Depends on dpkg >= 1.10.24.
349 found_needed_predep = 0
350 for parsed_dep in apt_pkg.ParseDepends(control.Find("Pre-Depends", "")):
351 for atom in parsed_dep:
352 (dep, version, constraint) = atom
353 if dep != "dpkg" or (constraint != ">=" and constraint != ">>") or \
354 len(parsed_dep) > 1: # or'ed deps don't count
356 if (constraint == ">=" and apt_pkg.VersionCompare(version, "1.10.24") < 0) or \
357 (constraint == ">>" and apt_pkg.VersionCompare(version, "1.10.23") < 0):
359 found_needed_predep = 1
360 if not found_needed_predep:
361 reject("%s: uses bzip2 compression, but doesn't Pre-Depend on dpkg (>= 1.10.24)" % (filename))
362 elif chunks[2] != "data.tar.gz":
363 reject("%s: third chunk is '%s', expected 'data.tar.gz' or 'data.tar.bz2'." % (filename, chunks[2]))
365 ################################################################################
370 archive = daklib.utils.where_am_i()
371 file_keys = files.keys()
373 # if reprocess is 2 we've already done this and we're checking
374 # things again for the new .orig.tar.gz.
375 # [Yes, I'm fully aware of how disgusting this is]
376 if not Options["No-Action"] and reprocess < 2:
378 os.chdir(pkg.directory)
379 for file in file_keys:
380 copy_to_holding(file)
383 # Check there isn't already a .changes or .dak file of the same name in
384 # the proposed-updates "CopyChanges" or "CopyDotDak" storage directories.
385 # [NB: this check must be done post-suite mapping]
386 base_filename = os.path.basename(pkg.changes_file)
387 dot_dak_filename = base_filename[:-8]+".dak"
388 for suite in changes["distribution"].keys():
389 copychanges = "Suite::%s::CopyChanges" % (suite)
390 if Cnf.has_key(copychanges) and \
391 os.path.exists(Cnf[copychanges]+"/"+base_filename):
392 reject("%s: a file with this name already exists in %s" \
393 % (base_filename, Cnf[copychanges]))
395 copy_dot_dak = "Suite::%s::CopyDotDak" % (suite)
396 if Cnf.has_key(copy_dot_dak) and \
397 os.path.exists(Cnf[copy_dot_dak]+"/"+dot_dak_filename):
398 reject("%s: a file with this name already exists in %s" \
399 % (dot_dak_filename, Cnf[copy_dot_dak]))
405 for file in file_keys:
406 # Ensure the file does not already exist in one of the accepted directories
407 for dir in [ "Accepted", "Byhand", "New", "ProposedUpdates" ]:
408 if os.path.exists(Cnf["Dir::Queue::%s" % (dir) ]+'/'+file):
409 reject("%s file already exists in the %s directory." % (file, dir))
410 if not daklib.utils.re_taint_free.match(file):
411 reject("!!WARNING!! tainted filename: '%s'." % (file))
412 # Check the file is readable
413 if os.access(file,os.R_OK) == 0:
414 # When running in -n, copy_to_holding() won't have
415 # generated the reject_message, so we need to.
416 if Options["No-Action"]:
417 if os.path.exists(file):
418 reject("Can't read `%s'. [permission denied]" % (file))
420 reject("Can't read `%s'. [file not found]" % (file))
421 files[file]["type"] = "unreadable"
423 # If it's byhand skip remaining checks
424 if files[file]["section"] == "byhand" or files[file]["section"] == "raw-installer":
425 files[file]["byhand"] = 1
426 files[file]["type"] = "byhand"
427 # Checks for a binary package...
428 elif daklib.utils.re_isadeb.match(file):
430 files[file]["type"] = "deb"
432 # Extract package control information
433 deb_file = daklib.utils.open_file(file)
435 control = apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))
437 reject("%s: debExtractControl() raised %s." % (file, sys.exc_type))
439 # Can't continue, none of the checks on control would work.
443 # Check for mandatory fields
444 for field in [ "Package", "Architecture", "Version" ]:
445 if control.Find(field) == None:
446 reject("%s: No %s field in control." % (file, field))
450 # Ensure the package name matches the one give in the .changes
451 if not changes["binary"].has_key(control.Find("Package", "")):
452 reject("%s: control file lists name as `%s', which isn't in changes file." % (file, control.Find("Package", "")))
454 # Validate the package field
455 package = control.Find("Package")
456 if not re_valid_pkg_name.match(package):
457 reject("%s: invalid package name '%s'." % (file, package))
459 # Validate the version field
460 version = control.Find("Version")
461 if not re_valid_version.match(version):
462 reject("%s: invalid version number '%s'." % (file, version))
464 # Ensure the architecture of the .deb is one we know about.
465 default_suite = Cnf.get("Dinstall::DefaultSuite", "Unstable")
466 architecture = control.Find("Architecture")
467 if architecture not in Cnf.ValueList("Suite::%s::Architectures" % (default_suite)):
468 reject("Unknown architecture '%s'." % (architecture))
470 # Ensure the architecture of the .deb is one of the ones
471 # listed in the .changes.
472 if not changes["architecture"].has_key(architecture):
473 reject("%s: control file lists arch as `%s', which isn't in changes file." % (file, architecture))
475 # Sanity-check the Depends field
476 depends = control.Find("Depends")
478 reject("%s: Depends field is empty." % (file))
480 # Check the section & priority match those given in the .changes (non-fatal)
481 if control.Find("Section") and files[file]["section"] != "" and files[file]["section"] != control.Find("Section"):
482 reject("%s control file lists section as `%s', but changes file has `%s'." % (file, control.Find("Section", ""), files[file]["section"]), "Warning: ")
483 if control.Find("Priority") and files[file]["priority"] != "" and files[file]["priority"] != control.Find("Priority"):
484 reject("%s control file lists priority as `%s', but changes file has `%s'." % (file, control.Find("Priority", ""), files[file]["priority"]),"Warning: ")
486 files[file]["package"] = package
487 files[file]["architecture"] = architecture
488 files[file]["version"] = version
489 files[file]["maintainer"] = control.Find("Maintainer", "")
490 if file.endswith(".udeb"):
491 files[file]["dbtype"] = "udeb"
492 elif file.endswith(".deb"):
493 files[file]["dbtype"] = "deb"
495 reject("%s is neither a .deb or a .udeb." % (file))
496 files[file]["source"] = control.Find("Source", files[file]["package"])
497 # Get the source version
498 source = files[file]["source"]
500 if source.find("(") != -1:
501 m = daklib.utils.re_extract_src_version.match(source)
503 source_version = m.group(2)
504 if not source_version:
505 source_version = files[file]["version"]
506 files[file]["source package"] = source
507 files[file]["source version"] = source_version
509 # Ensure the filename matches the contents of the .deb
510 m = daklib.utils.re_isadeb.match(file)
512 file_package = m.group(1)
513 if files[file]["package"] != file_package:
514 reject("%s: package part of filename (%s) does not match package name in the %s (%s)." % (file, file_package, files[file]["dbtype"], files[file]["package"]))
515 epochless_version = daklib.utils.re_no_epoch.sub('', control.Find("Version"))
517 file_version = m.group(2)
518 if epochless_version != file_version:
519 reject("%s: version part of filename (%s) does not match package version in the %s (%s)." % (file, file_version, files[file]["dbtype"], epochless_version))
521 file_architecture = m.group(3)
522 if files[file]["architecture"] != file_architecture:
523 reject("%s: architecture part of filename (%s) does not match package architecture in the %s (%s)." % (file, file_architecture, files[file]["dbtype"], files[file]["architecture"]))
525 # Check for existent source
526 source_version = files[file]["source version"]
527 source_package = files[file]["source package"]
528 if changes["architecture"].has_key("source"):
529 if source_version != changes["version"]:
530 reject("source version (%s) for %s doesn't match changes version %s." % (source_version, file, changes["version"]))
532 # Check in the SQL database
533 if not Upload.source_exists(source_package, source_version, changes["distribution"].keys()):
534 # Check in one of the other directories
535 source_epochless_version = daklib.utils.re_no_epoch.sub('', source_version)
536 dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
537 if os.path.exists(Cnf["Dir::Queue::Byhand"] + '/' + dsc_filename):
538 files[file]["byhand"] = 1
539 elif os.path.exists(Cnf["Dir::Queue::New"] + '/' + dsc_filename):
540 files[file]["new"] = 1
543 for myq in ["Accepted", "Embargoed", "Unembargoed", "ProposedUpdates"]:
544 if Cnf.has_key("Dir::Queue::%s" % (myq)):
545 if os.path.exists(Cnf["Dir::Queue::"+myq] + '/' + dsc_filename):
548 if not dsc_file_exists:
549 reject("no source found for %s %s (%s)." % (source_package, source_version, file))
550 # Check the version and for file overwrites
551 reject(Upload.check_binary_against_db(file),"")
553 check_deb_ar(file, control)
555 # Checks for a source package...
557 m = daklib.utils.re_issource.match(file)
560 files[file]["package"] = m.group(1)
561 files[file]["version"] = m.group(2)
562 files[file]["type"] = m.group(3)
564 # Ensure the source package name matches the Source filed in the .changes
565 if changes["source"] != files[file]["package"]:
566 reject("%s: changes file doesn't say %s for Source" % (file, files[file]["package"]))
568 # Ensure the source version matches the version in the .changes file
569 if files[file]["type"] == "orig.tar.gz":
570 changes_version = changes["chopversion2"]
572 changes_version = changes["chopversion"]
573 if changes_version != files[file]["version"]:
574 reject("%s: should be %s according to changes file." % (file, changes_version))
576 # Ensure the .changes lists source in the Architecture field
577 if not changes["architecture"].has_key("source"):
578 reject("%s: changes file doesn't list `source' in Architecture field." % (file))
580 # Check the signature of a .dsc file
581 if files[file]["type"] == "dsc":
582 dsc["fingerprint"] = daklib.utils.check_signature(file, reject)
584 files[file]["architecture"] = "source"
586 # Not a binary or source package? Assume byhand...
588 files[file]["byhand"] = 1
589 files[file]["type"] = "byhand"
591 # Per-suite file checks
592 files[file]["oldfiles"] = {}
593 for suite in changes["distribution"].keys():
595 if files[file].has_key("byhand"):
598 # Handle component mappings
599 for map in Cnf.ValueList("ComponentMappings"):
600 (source, dest) = map.split()
601 if files[file]["component"] == source:
602 files[file]["original component"] = source
603 files[file]["component"] = dest
605 # Ensure the component is valid for the target suite
606 if Cnf.has_key("Suite:%s::Components" % (suite)) and \
607 files[file]["component"] not in Cnf.ValueList("Suite::%s::Components" % (suite)):
608 reject("unknown component `%s' for suite `%s'." % (files[file]["component"], suite))
611 # Validate the component
612 component = files[file]["component"]
613 component_id = daklib.database.get_component_id(component)
614 if component_id == -1:
615 reject("file '%s' has unknown component '%s'." % (file, component))
618 # See if the package is NEW
619 if not Upload.in_override_p(files[file]["package"], files[file]["component"], suite, files[file].get("dbtype",""), file):
620 files[file]["new"] = 1
622 # Validate the priority
623 if files[file]["priority"].find('/') != -1:
624 reject("file '%s' has invalid priority '%s' [contains '/']." % (file, files[file]["priority"]))
626 # Determine the location
627 location = Cnf["Dir::Pool"]
628 location_id = daklib.database.get_location_id (location, component, archive)
629 if location_id == -1:
630 reject("[INTERNAL ERROR] couldn't determine location (Component: %s, Archive: %s)" % (component, archive))
631 files[file]["location id"] = location_id
633 # Check the md5sum & size against existing files (if any)
634 files[file]["pool name"] = daklib.utils.poolify (changes["source"], files[file]["component"])
635 files_id = daklib.database.get_files_id(files[file]["pool name"] + file, files[file]["size"], files[file]["md5sum"], files[file]["location id"])
637 reject("INTERNAL ERROR, get_files_id() returned multiple matches for %s." % (file))
639 reject("md5sum and/or size mismatch on existing copy of %s." % (file))
640 files[file]["files id"] = files_id
642 # Check for packages that have moved from one component to another
643 q = Upload.projectB.query("""
644 SELECT c.name FROM binaries b, bin_associations ba, suite s, location l,
645 component c, architecture a, files f
646 WHERE b.package = '%s' AND s.suite_name = '%s'
647 AND (a.arch_string = '%s' OR a.arch_string = 'all')
648 AND ba.bin = b.id AND ba.suite = s.id AND b.architecture = a.id
649 AND f.location = l.id AND l.component = c.id AND b.file = f.id"""
650 % (files[file]["package"], suite,
651 files[file]["architecture"]))
654 files[file]["othercomponents"] = ql[0][0]
656 # If the .changes file says it has source, it must have source.
657 if changes["architecture"].has_key("source"):
659 reject("no source found and Architecture line in changes mention source.")
661 if not has_binaries and Cnf.FindB("Dinstall::Reject::NoSourceOnly"):
662 reject("source only uploads are not supported.")
664 ###############################################################################
669 # Ensure there is source to check
670 if not changes["architecture"].has_key("source"):
675 for file in files.keys():
676 if files[file]["type"] == "dsc":
678 reject("can not process a .changes file with multiple .dsc's.")
683 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
685 reject("source uploads must contain a dsc file")
688 # Parse the .dsc file
690 dsc.update(daklib.utils.parse_changes(dsc_filename, signing_rules=1))
691 except daklib.utils.cant_open_exc:
692 # if not -n copy_to_holding() will have done this for us...
693 if Options["No-Action"]:
694 reject("%s: can't read file." % (dsc_filename))
695 except daklib.utils.changes_parse_error_exc, line:
696 reject("%s: parse error, can't grok: %s." % (dsc_filename, line))
697 except daklib.utils.invalid_dsc_format_exc, line:
698 reject("%s: syntax error on line %s." % (dsc_filename, line))
699 # Build up the file list of files mentioned by the .dsc
701 dsc_files.update(daklib.utils.build_file_list(dsc, is_a_dsc=1))
702 except daklib.utils.no_files_exc:
703 reject("%s: no Files: field." % (dsc_filename))
705 except daklib.utils.changes_parse_error_exc, line:
706 reject("%s: parse error, can't grok: %s." % (dsc_filename, line))
709 # Enforce mandatory fields
710 for i in ("format", "source", "version", "binary", "maintainer", "architecture", "files"):
711 if not dsc.has_key(i):
712 reject("%s: missing mandatory field `%s'." % (dsc_filename, i))
715 # Validate the source and version fields
716 if not re_valid_pkg_name.match(dsc["source"]):
717 reject("%s: invalid source name '%s'." % (dsc_filename, dsc["source"]))
718 if not re_valid_version.match(dsc["version"]):
719 reject("%s: invalid version number '%s'." % (dsc_filename, dsc["version"]))
721 # Bumping the version number of the .dsc breaks extraction by stable's
722 # dpkg-source. So let's not do that...
723 if dsc["format"] != "1.0":
724 reject("%s: incompatible 'Format' version produced by a broken version of dpkg-dev 1.9.1{3,4}." % (dsc_filename))
726 # Validate the Maintainer field
728 daklib.utils.fix_maintainer (dsc["maintainer"])
729 except daklib.utils.ParseMaintError, msg:
730 reject("%s: Maintainer field ('%s') failed to parse: %s" \
731 % (dsc_filename, dsc["maintainer"], msg))
733 # Validate the build-depends field(s)
734 for field_name in [ "build-depends", "build-depends-indep" ]:
735 field = dsc.get(field_name)
737 # Check for broken dpkg-dev lossage...
738 if field.startswith("ARRAY"):
739 reject("%s: invalid %s field produced by a broken version of dpkg-dev (1.10.11)" % (dsc_filename, field_name.title()))
741 # Have apt try to parse them...
743 apt_pkg.ParseSrcDepends(field)
745 reject("%s: invalid %s field (can not be parsed by apt)." % (dsc_filename, field_name.title()))
748 # Ensure the version number in the .dsc matches the version number in the .changes
749 epochless_dsc_version = daklib.utils.re_no_epoch.sub('', dsc["version"])
750 changes_version = files[dsc_filename]["version"]
751 if epochless_dsc_version != files[dsc_filename]["version"]:
752 reject("version ('%s') in .dsc does not match version ('%s') in .changes." % (epochless_dsc_version, changes_version))
754 # Ensure there is a .tar.gz in the .dsc file
756 for f in dsc_files.keys():
757 m = daklib.utils.re_issource.match(f)
759 reject("%s: %s in Files field not recognised as source." % (dsc_filename, f))
761 if type == "orig.tar.gz" or type == "tar.gz":
764 reject("%s: no .tar.gz or .orig.tar.gz in 'Files' field." % (dsc_filename))
766 # Ensure source is newer than existing source in target suites
767 reject(Upload.check_source_against_db(dsc_filename),"")
769 (reject_msg, is_in_incoming) = Upload.check_dsc_against_db(dsc_filename)
770 reject(reject_msg, "")
772 if not Options["No-Action"]:
773 copy_to_holding(is_in_incoming)
774 orig_tar_gz = os.path.basename(is_in_incoming)
775 files[orig_tar_gz] = {}
776 files[orig_tar_gz]["size"] = os.stat(orig_tar_gz)[stat.ST_SIZE]
777 files[orig_tar_gz]["md5sum"] = dsc_files[orig_tar_gz]["md5sum"]
778 files[orig_tar_gz]["section"] = files[dsc_filename]["section"]
779 files[orig_tar_gz]["priority"] = files[dsc_filename]["priority"]
780 files[orig_tar_gz]["component"] = files[dsc_filename]["component"]
781 files[orig_tar_gz]["type"] = "orig.tar.gz"
786 ################################################################################
788 def get_changelog_versions(source_dir):
789 """Extracts a the source package and (optionally) grabs the
790 version history out of debian/changelog for the BTS."""
792 # Find the .dsc (again)
794 for file in files.keys():
795 if files[file]["type"] == "dsc":
798 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
802 # Create a symlink mirror of the source files in our temporary directory
803 for f in files.keys():
804 m = daklib.utils.re_issource.match(f)
806 src = os.path.join(source_dir, f)
807 # If a file is missing for whatever reason, give up.
808 if not os.path.exists(src):
811 if type == "orig.tar.gz" and pkg.orig_tar_gz:
813 dest = os.path.join(os.getcwd(), f)
814 os.symlink(src, dest)
816 # If the orig.tar.gz is not a part of the upload, create a symlink to the
819 dest = os.path.join(os.getcwd(), os.path.basename(pkg.orig_tar_gz))
820 os.symlink(pkg.orig_tar_gz, dest)
823 cmd = "dpkg-source -sn -x %s" % (dsc_filename)
824 (result, output) = commands.getstatusoutput(cmd)
826 reject("'dpkg-source -x' failed for %s [return code: %s]." % (dsc_filename, result))
827 reject(daklib.utils.prefix_multi_line_string(output, " [dpkg-source output:] "), "")
830 if not Cnf.Find("Dir::Queue::BTSVersionTrack"):
833 # Get the upstream version
834 upstr_version = daklib.utils.re_no_epoch.sub('', dsc["version"])
835 if re_strip_revision.search(upstr_version):
836 upstr_version = re_strip_revision.sub('', upstr_version)
838 # Ensure the changelog file exists
839 changelog_filename = "%s-%s/debian/changelog" % (dsc["source"], upstr_version)
840 if not os.path.exists(changelog_filename):
841 reject("%s: debian/changelog not found in extracted source." % (dsc_filename))
844 # Parse the changelog
845 dsc["bts changelog"] = ""
846 changelog_file = daklib.utils.open_file(changelog_filename)
847 for line in changelog_file.readlines():
848 m = re_changelog_versions.match(line)
850 dsc["bts changelog"] += line
851 changelog_file.close()
853 # Check we found at least one revision in the changelog
854 if not dsc["bts changelog"]:
855 reject("%s: changelog format not recognised (empty version tree)." % (dsc_filename))
857 ########################################
861 # a) there's no source
862 # or b) reprocess is 2 - we will do this check next time when orig.tar.gz is in 'files'
863 # or c) the orig.tar.gz is MIA
864 if not changes["architecture"].has_key("source") or reprocess == 2 \
865 or pkg.orig_tar_gz == -1:
868 # Create a temporary directory to extract the source into
869 if Options["No-Action"]:
870 tmpdir = tempfile.mktemp()
872 # We're in queue/holding and can create a random directory.
873 tmpdir = "%s" % (os.getpid())
876 # Move into the temporary directory
880 # Get the changelog version history
881 get_changelog_versions(cwd)
883 # Move back and cleanup the temporary tree
886 shutil.rmtree(tmpdir)
888 if errno.errorcode[e.errno] != 'EACCES':
889 daklib.utils.fubar("%s: couldn't remove tmp dir for source tree." % (dsc["source"]))
891 reject("%s: source tree could not be cleanly removed." % (dsc["source"]))
892 # We probably have u-r or u-w directories so chmod everything
894 cmd = "chmod -R u+rwx %s" % (tmpdir)
895 result = os.system(cmd)
897 daklib.utils.fubar("'%s' failed with result %s." % (cmd, result))
898 shutil.rmtree(tmpdir)
900 daklib.utils.fubar("%s: couldn't remove tmp dir for source tree." % (dsc["source"]))
902 ################################################################################
904 # FIXME: should be a debian specific check called from a hook
906 def check_urgency ():
907 if changes["architecture"].has_key("source"):
908 if not changes.has_key("urgency"):
909 changes["urgency"] = Cnf["Urgency::Default"]
910 if changes["urgency"] not in Cnf.ValueList("Urgency::Valid"):
911 reject("%s is not a valid urgency; it will be treated as %s by testing." % (changes["urgency"], Cnf["Urgency::Default"]), "Warning: ")
912 changes["urgency"] = Cnf["Urgency::Default"]
913 changes["urgency"] = changes["urgency"].lower()
915 ################################################################################
917 def check_md5sums ():
918 for file in files.keys():
920 file_handle = daklib.utils.open_file(file)
921 except daklib.utils.cant_open_exc:
925 if apt_pkg.md5sum(file_handle) != files[file]["md5sum"]:
926 reject("%s: md5sum check failed." % (file))
929 actual_size = os.stat(file)[stat.ST_SIZE]
930 size = int(files[file]["size"])
931 if size != actual_size:
932 reject("%s: actual file size (%s) does not match size (%s) in .changes"
933 % (file, actual_size, size))
935 for file in dsc_files.keys():
937 file_handle = daklib.utils.open_file(file)
938 except daklib.utils.cant_open_exc:
942 if apt_pkg.md5sum(file_handle) != dsc_files[file]["md5sum"]:
943 reject("%s: md5sum check failed." % (file))
946 actual_size = os.stat(file)[stat.ST_SIZE]
947 size = int(dsc_files[file]["size"])
948 if size != actual_size:
949 reject("%s: actual file size (%s) does not match size (%s) in .dsc"
950 % (file, actual_size, size))
952 ################################################################################
954 # Sanity check the time stamps of files inside debs.
955 # [Files in the near future cause ugly warnings and extreme time
956 # travel can cause errors on extraction]
958 def check_timestamps():
960 def __init__(self, future_cutoff, past_cutoff):
962 self.future_cutoff = future_cutoff
963 self.past_cutoff = past_cutoff
966 self.future_files = {}
967 self.ancient_files = {}
969 def callback(self, Kind,Name,Link,Mode,UID,GID,Size,MTime,Major,Minor):
970 if MTime > self.future_cutoff:
971 self.future_files[Name] = MTime
972 if MTime < self.past_cutoff:
973 self.ancient_files[Name] = MTime
976 future_cutoff = time.time() + int(Cnf["Dinstall::FutureTimeTravelGrace"])
977 past_cutoff = time.mktime(time.strptime(Cnf["Dinstall::PastCutoffYear"],"%Y"))
978 tar = Tar(future_cutoff, past_cutoff)
979 for filename in files.keys():
980 if files[filename]["type"] == "deb":
983 deb_file = daklib.utils.open_file(filename)
984 apt_inst.debExtract(deb_file,tar.callback,"control.tar.gz")
987 apt_inst.debExtract(deb_file,tar.callback,"data.tar.gz")
988 except SystemError, e:
989 # If we can't find a data.tar.gz, look for data.tar.bz2 instead.
990 if not re.match(r"Cannot f[ui]nd chunk data.tar.gz$", str(e)):
993 apt_inst.debExtract(deb_file,tar.callback,"data.tar.bz2")
996 future_files = tar.future_files.keys()
998 num_future_files = len(future_files)
999 future_file = future_files[0]
1000 future_date = tar.future_files[future_file]
1001 reject("%s: has %s file(s) with a time stamp too far into the future (e.g. %s [%s])."
1002 % (filename, num_future_files, future_file,
1003 time.ctime(future_date)))
1005 ancient_files = tar.ancient_files.keys()
1007 num_ancient_files = len(ancient_files)
1008 ancient_file = ancient_files[0]
1009 ancient_date = tar.ancient_files[ancient_file]
1010 reject("%s: has %s file(s) with a time stamp too ancient (e.g. %s [%s])."
1011 % (filename, num_ancient_files, ancient_file,
1012 time.ctime(ancient_date)))
1014 reject("%s: deb contents timestamp check failed [%s: %s]" % (filename, sys.exc_type, sys.exc_value))
1016 ################################################################################
1017 ################################################################################
1019 # If any file of an upload has a recent mtime then chances are good
1020 # the file is still being uploaded.
1022 def upload_too_new():
1024 # Move back to the original directory to get accurate time stamps
1026 os.chdir(pkg.directory)
1027 file_list = pkg.files.keys()
1028 file_list.extend(pkg.dsc_files.keys())
1029 file_list.append(pkg.changes_file)
1030 for file in file_list:
1032 last_modified = time.time()-os.path.getmtime(file)
1033 if last_modified < int(Cnf["Dinstall::SkipTime"]):
1041 ################################################################################
1044 # changes["distribution"] may not exist in corner cases
1045 # (e.g. unreadable changes files)
1046 if not changes.has_key("distribution") or not isinstance(changes["distribution"], DictType):
1047 changes["distribution"] = {}
1049 (summary, short_summary) = Upload.build_summaries()
1051 # q-unapproved hax0ring
1053 "New": { "is": is_new, "process": acknowledge_new },
1054 "Byhand" : { "is": is_byhand, "process": do_byhand },
1055 "StableUpdate" : { "is": is_stableupdate, "process": do_stableupdate },
1056 "Unembargo" : { "is": is_unembargo, "process": queue_unembargo },
1057 "Embargo" : { "is": is_embargo, "process": queue_embargo },
1059 queues = [ "New", "Byhand" ]
1060 if Cnf.FindB("Dinstall::SecurityQueueHandling"):
1061 queues += [ "Unembargo", "Embargo" ]
1063 queues += [ "StableUpdate" ]
1065 (prompt, answer) = ("", "XXX")
1066 if Options["No-Action"] or Options["Automatic"]:
1071 if reject_message.find("Rejected") != -1:
1072 if upload_too_new():
1073 print "SKIP (too new)\n" + reject_message,
1074 prompt = "[S]kip, Quit ?"
1076 print "REJECT\n" + reject_message,
1077 prompt = "[R]eject, Skip, Quit ?"
1078 if Options["Automatic"]:
1083 if queue_info[q]["is"]():
1087 print "%s for %s\n%s%s" % (
1088 queue.upper(), ", ".join(changes["distribution"].keys()),
1089 reject_message, summary),
1090 queuekey = queue[0].upper()
1091 if queuekey in "RQSA":
1093 prompt = "[D]ivert, Skip, Quit ?"
1095 prompt = "[%s]%s, Skip, Quit ?" % (queuekey, queue[1:].lower())
1096 if Options["Automatic"]:
1099 print "ACCEPT\n" + reject_message + summary,
1100 prompt = "[A]ccept, Skip, Quit ?"
1101 if Options["Automatic"]:
1104 while prompt.find(answer) == -1:
1105 answer = daklib.utils.our_raw_input(prompt)
1106 m = daklib.queue.re_default_answer.match(prompt)
1109 answer = answer[:1].upper()
1112 os.chdir (pkg.directory)
1113 Upload.do_reject(0, reject_message)
1115 accept(summary, short_summary)
1116 remove_from_unchecked()
1117 elif answer == queuekey:
1118 queue_info[queue]["process"](summary)
1119 remove_from_unchecked()
1123 def remove_from_unchecked():
1124 os.chdir (pkg.directory)
1125 for file in files.keys():
1127 os.unlink(pkg.changes_file)
1129 ################################################################################
1131 def accept (summary, short_summary):
1132 Upload.accept(summary, short_summary)
1133 Upload.check_override()
1135 ################################################################################
1137 def move_to_dir (dest, perms=0660, changesperms=0664):
1138 daklib.utils.move (pkg.changes_file, dest, perms=changesperms)
1139 file_keys = files.keys()
1140 for file in file_keys:
1141 daklib.utils.move (file, dest, perms=perms)
1143 ################################################################################
1145 def is_unembargo ():
1146 q = Upload.projectB.query(
1147 "SELECT package FROM disembargo WHERE package = '%s' AND version = '%s'" %
1148 (changes["source"], changes["version"]))
1153 oldcwd = os.getcwd()
1154 os.chdir(Cnf["Dir::Queue::Disembargo"])
1155 disdir = os.getcwd()
1158 if pkg.directory == disdir:
1159 if changes["architecture"].has_key("source"):
1160 if Options["No-Action"]: return 1
1162 Upload.projectB.query(
1163 "INSERT INTO disembargo (package, version) VALUES ('%s', '%s')" %
1164 (changes["source"], changes["version"]))
1169 def queue_unembargo (summary):
1170 print "Moving to UNEMBARGOED holding area."
1171 Logger.log(["Moving to unembargoed", pkg.changes_file])
1173 Upload.dump_vars(Cnf["Dir::Queue::Unembargoed"])
1174 move_to_dir(Cnf["Dir::Queue::Unembargoed"])
1175 Upload.queue_build("unembargoed", Cnf["Dir::Queue::Unembargoed"])
1177 # Check for override disparities
1178 Upload.Subst["__SUMMARY__"] = summary
1179 Upload.check_override()
1181 ################################################################################
1186 def queue_embargo (summary):
1187 print "Moving to EMBARGOED holding area."
1188 Logger.log(["Moving to embargoed", pkg.changes_file])
1190 Upload.dump_vars(Cnf["Dir::Queue::Embargoed"])
1191 move_to_dir(Cnf["Dir::Queue::Embargoed"])
1192 Upload.queue_build("embargoed", Cnf["Dir::Queue::Embargoed"])
1194 # Check for override disparities
1195 Upload.Subst["__SUMMARY__"] = summary
1196 Upload.check_override()
1198 ################################################################################
1200 def is_stableupdate ():
1201 if changes["distribution"].has_key("proposed-updates"):
1205 def do_stableupdate (summary):
1206 print "Moving to PROPOSED-UPDATES holding area."
1207 Logger.log(["Moving to proposed-updates", pkg.changes_file]);
1209 Upload.dump_vars(Cnf["Dir::Queue::ProposedUpdates"]);
1210 move_to_dir(Cnf["Dir::Queue::ProposedUpdates"])
1212 # Check for override disparities
1213 Upload.Subst["__SUMMARY__"] = summary;
1214 Upload.check_override();
1216 ################################################################################
1219 for file in files.keys():
1220 if files[file].has_key("byhand"):
1224 def do_byhand (summary):
1225 print "Moving to BYHAND holding area."
1226 Logger.log(["Moving to byhand", pkg.changes_file])
1228 Upload.dump_vars(Cnf["Dir::Queue::Byhand"])
1229 move_to_dir(Cnf["Dir::Queue::Byhand"])
1231 # Check for override disparities
1232 Upload.Subst["__SUMMARY__"] = summary
1233 Upload.check_override()
1235 ################################################################################
1238 for file in files.keys():
1239 if files[file].has_key("new"):
1243 def acknowledge_new (summary):
1244 Subst = Upload.Subst
1246 print "Moving to NEW holding area."
1247 Logger.log(["Moving to new", pkg.changes_file])
1249 Upload.dump_vars(Cnf["Dir::Queue::New"])
1250 move_to_dir(Cnf["Dir::Queue::New"])
1252 if not Options["No-Mail"]:
1253 print "Sending new ack."
1254 Subst["__SUMMARY__"] = summary
1255 new_ack_message = daklib.utils.TemplateSubst(Subst,Cnf["Dir::Templates"]+"/process-unchecked.new")
1256 daklib.utils.send_mail(new_ack_message)
1258 ################################################################################
1260 # reprocess is necessary for the case of foo_1.2-1 and foo_1.2-2 in
1261 # Incoming. -1 will reference the .orig.tar.gz, but -2 will not.
1262 # Upload.check_dsc_against_db() can find the .orig.tar.gz but it will
1263 # not have processed it during it's checks of -2. If -1 has been
1264 # deleted or otherwise not checked by 'dak process-unchecked', the
1265 # .orig.tar.gz will not have been checked at all. To get round this,
1266 # we force the .orig.tar.gz into the .changes structure and reprocess
1267 # the .changes file.
1269 def process_it (changes_file):
1270 global reprocess, reject_message
1272 # Reset some globals
1275 # Some defaults in case we can't fully process the .changes file
1276 changes["maintainer2047"] = Cnf["Dinstall::MyEmailAddress"]
1277 changes["changedby2047"] = Cnf["Dinstall::MyEmailAddress"]
1280 # Absolutize the filename to avoid the requirement of being in the
1281 # same directory as the .changes file.
1282 pkg.changes_file = os.path.abspath(changes_file)
1284 # Remember where we are so we can come back after cd-ing into the
1285 # holding directory.
1286 pkg.directory = os.getcwd()
1289 # If this is the Real Thing(tm), copy things into a private
1290 # holding directory first to avoid replacable file races.
1291 if not Options["No-Action"]:
1292 os.chdir(Cnf["Dir::Queue::Holding"])
1293 copy_to_holding(pkg.changes_file)
1294 # Relativize the filename so we use the copy in holding
1295 # rather than the original...
1296 pkg.changes_file = os.path.basename(pkg.changes_file)
1297 changes["fingerprint"] = daklib.utils.check_signature(pkg.changes_file, reject)
1298 if changes["fingerprint"]:
1299 valid_changes_p = check_changes()
1304 check_distributions()
1306 valid_dsc_p = check_dsc()
1312 Upload.update_subst(reject_message)
1318 traceback.print_exc(file=sys.stderr)
1321 # Restore previous WD
1322 os.chdir(pkg.directory)
1324 ###############################################################################
1327 global Cnf, Options, Logger
1329 changes_files = init()
1331 # -n/--dry-run invalidates some other options which would involve things happening
1332 if Options["No-Action"]:
1333 Options["Automatic"] = ""
1335 # Ensure all the arguments we were given are .changes files
1336 for file in changes_files:
1337 if not file.endswith(".changes"):
1338 daklib.utils.warn("Ignoring '%s' because it's not a .changes file." % (file))
1339 changes_files.remove(file)
1341 if changes_files == []:
1342 daklib.utils.fubar("Need at least one .changes file as an argument.")
1344 # Check that we aren't going to clash with the daily cron job
1346 if not Options["No-Action"] and os.path.exists("%s/daily.lock" % (Cnf["Dir::Lock"])) and not Options["No-Lock"]:
1347 daklib.utils.fubar("Archive maintenance in progress. Try again later.")
1349 # Obtain lock if not in no-action mode and initialize the log
1351 if not Options["No-Action"]:
1352 lock_fd = os.open(Cnf["Dinstall::LockFile"], os.O_RDWR | os.O_CREAT)
1354 fcntl.lockf(lock_fd, fcntl.LOCK_EX | fcntl.LOCK_NB)
1356 if errno.errorcode[e.errno] == 'EACCES' or errno.errorcode[e.errno] == 'EAGAIN':
1357 daklib.utils.fubar("Couldn't obtain lock; assuming another 'dak process-unchecked' is already running.")
1360 Logger = Upload.Logger = daklib.logging.Logger(Cnf, "process-unchecked")
1362 # debian-{devel-,}-changes@lists.debian.org toggles writes access based on this header
1363 bcc = "X-DAK: dak process-unchecked\nX-Katie: $Revision: 1.65 $"
1364 if Cnf.has_key("Dinstall::Bcc"):
1365 Upload.Subst["__BCC__"] = bcc + "\nBcc: %s" % (Cnf["Dinstall::Bcc"])
1367 Upload.Subst["__BCC__"] = bcc
1370 # Sort the .changes files so that we process sourceful ones first
1371 changes_files.sort(daklib.utils.changes_compare)
1373 # Process the changes files
1374 for changes_file in changes_files:
1375 print "\n" + changes_file
1377 process_it (changes_file)
1379 if not Options["No-Action"]:
1382 accept_count = Upload.accept_count
1383 accept_bytes = Upload.accept_bytes
1386 if accept_count > 1:
1388 print "Accepted %d package %s, %s." % (accept_count, sets, daklib.utils.size_type(int(accept_bytes)))
1389 Logger.log(["total",accept_count,accept_bytes])
1391 if not Options["No-Action"]:
1394 ################################################################################
1396 if __name__ == '__main__':