]> git.donarmstrong.com Git - lilypond.git/commitdiff
Send ping logs to /dev/stderr instead of /dev/tty.
authorPatrick McCarty <pnorcks@gmail.com>
Mon, 25 Oct 2010 07:32:01 +0000 (00:32 -0700)
committerPatrick McCarty <pnorcks@gmail.com>
Mon, 25 Oct 2010 07:56:30 +0000 (00:56 -0700)
(This fixes issue #1028)

If `-dlog-file' was not specified along with `-dseparate-log-files',
certain log messages (the "ping" log messages) were sent to /dev/tty.

However, this was causing problems for machines building LilyPond that
could not write to /dev/tty (no controlling tty).

The solution is to write to /dev/stderr instead, which is
common-practice for logging.

See the Debian bug report for details:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=572290

scm/lily.scm

index 68813a49d854b7e1ccc23a55e80ae7cd92106942..0a7e4d0d13135efe204005907cb1017ff503237d 100644 (file)
@@ -801,7 +801,7 @@ PIDs or the number of the process."
          (if separate-logs
              (open-file (if (string-or-symbol? (ly:get-option 'log-file))
                             (format "~a.log" (ly:get-option 'log-file))
-                            "/dev/tty") "a") #f))
+                            "/dev/stderr") "a") #f))
         (do-measurements (ly:get-option 'dump-profile))
         (handler (lambda (key failed-file)
                    (set! failed (append (list failed-file) failed)))))