]> git.donarmstrong.com Git - lilypond.git/commitdiff
Rewrite call_pure_function
authorDavid Kastrup <dak@gnu.org>
Fri, 25 Sep 2015 14:29:14 +0000 (16:29 +0200)
committerDavid Kastrup <dak@gnu.org>
Fri, 2 Oct 2015 07:45:28 +0000 (09:45 +0200)
lily/grob-property.cc

index 260b6700c47d0ab0b45d14b362bfef645a0659ca..5842662757b4650bba19c7fd5f68f5fd8f0dbe97 100644 (file)
@@ -314,24 +314,34 @@ Grob::internal_has_interface (SCM k)
 }
 
 SCM
-call_pure_function (SCM unpure, SCM args, int start, int end)
+call_pure_function (SCM value, SCM args, int start, int end)
 {
-  if (Unpure_pure_container *upc = unsmob<Unpure_pure_container> (unpure))
+  if (Unpure_pure_container *upc = unsmob<Unpure_pure_container> (value))
     {
-      SCM pure = upc->pure_part ();
+      if (upc->is_unchanging ())
+        {
+          // Don't bother forming an Unpure_pure_call here.
+          value = upc->unpure_part ();
+
+          if (ly_is_procedure (value))
+            return scm_apply_0 (value, args);
+          return value;
+        }
+
+      value = upc->pure_part ();
 
-      if (ly_is_procedure (pure))
-        return scm_apply_0 (pure,
-                            scm_append (scm_list_2 (scm_list_3 (scm_car (args),
-                                                                scm_from_int (start),
-                                                                scm_from_int (end)),
-                                                    scm_cdr (args))));
+      if (ly_is_procedure (value))
+        return scm_apply_3 (value,
+                            scm_car (args),
+                            scm_from_int (start),
+                            scm_from_int (end),
+                            scm_cdr (args));
 
-      return pure;
+      return value;
     }
 
-  if (!ly_is_procedure (unpure))
-    return unpure;
+  if (!ly_is_procedure (value))
+    return value;
 
   return SCM_BOOL_F;
 }