Issue 3945: fix (De)crescendo with unspecified starting volume in MIDI

diff --git a/input/regression/midi/dynamic-initial.ly b/input/regression/midi/dynamic-initial.ly
new file mode 100644 (file)
index 0000000..fca7c8a
--- /dev/null
+++ b/input/regression/midi/dynamic-initial.ly
@@ -0,0 +1,15 @@
+\version "2.19.44"
+
+\header {
+  texidoc="The MIDI performer uses a default initial dynamic"
+}
+
+\score {
+   { c\< c\f }
+   \midi {}
+}
+
+\score {
+   { c c\< c\f }
+   \midi {}
+}

diff --git a/input/regression/typography-demo.ly b/input/regression/typography-demo.ly
index c915c7fe52663c261f887c70b481cd2270ea53b0..836088123b03568e301c537489e0fb4e32a76388 100644 (file)
--- a/input/regression/typography-demo.ly
+++ b/input/regression/typography-demo.ly
@@ -9,7 +9,6 @@ heavily mutilated Edition Peters Morgenlied by Schubert"
 }
 
 \version "2.19.21"
-#(ly:expect-warning (_ "(De)crescendo with unspecified starting volume in MIDI."))
 
 ignoreMelisma =        \set ignoreMelismata = ##t
 ignoreMelismaOff = \unset ignoreMelismata 

diff --git a/lily/dynamic-performer.cc b/lily/dynamic-performer.cc
index 46a8a446d35af8c3a32e949c34f59ed962e520c1..b24b7a6305a996878c37bd7c352ae9c8ddcfdf89 100644 (file)
--- a/lily/dynamic-performer.cc
+++ b/lily/dynamic-performer.cc
@@ -120,16 +120,6 @@ Dynamic_performer::process_music ()
       announce_element (Audio_element_info (span_dynamic_, span_events_[START]));
 
       span_dynamic_->grow_dir_ = grow_dir_[START];
-
-      if (!last_volume_initialized_ && !script_event_)
-        {
-          // No explicit dynamic script events have occurred yet, but there is
-          // nevertheless a dynamic spanner.  Initialize last_volume_ to a
-          // value within the available range.
-          span_events_[START]->origin ()->warning (_ ("(De)crescendo with unspecified starting volume in MIDI."));
-          last_volume_ = equalize_volume (0.5);
-          last_volume_initialized_ = true;
-        }
     }
 
   if (script_event_