]> git.donarmstrong.com Git - debbugs.git/commitdiff
fix bug where boring versions were included while collapsing
authorDon Armstrong <don@volo>
Sat, 10 Mar 2007 10:19:28 +0000 (02:19 -0800)
committerDon Armstrong <don@volo>
Sat, 10 Mar 2007 10:19:28 +0000 (02:19 -0800)
cgi/version.cgi

index f0765f9a151ac61df1e9d9d0c9150b3b08adc16d..0470140061b5d44a7867868f802369b7a8e8d0e3 100755 (executable)
@@ -144,7 +144,10 @@ if ($cgi_var{collapse}) {
                                               or $all_states{$key} eq 'absent');
          next if $cgi_var{ignore_boring} and not version_relevant($version,$key,\@interesting_versions);
          if (defined $version->{parent}{$key}) {
-              push @{$reversed_nodes{$version->{parent}{$key}}}, $key;
+              next if $cgi_var{ignore_boring} and (not defined $all_states{$version->{parent}{$key}}
+                                                   or $all_states{$version->{parent}{$key}} eq 'absent');
+              next if $cgi_var{ignore_boring} and not version_relevant($version,$version->{parent}{$key},\@interesting_versions);
+              push @{$reversed_nodes{$version->{parent}{$key}}},$key;
          }
          else {
               $reversed_nodes{$key} ||=[];
@@ -233,6 +236,7 @@ if ($cgi_var{collapse}) {
      my %used_node;
      foreach my $group (values %group_nodes) {
          next if $used_node{$group->{name}};
+         next if not defined $group->{parent};
          $used_node{$group->{name}} = 1;
          $dot .= qq("$group->{name}").'->'.q(").
               (exists $collapsed_nodes{$group->{parent}}?