]> git.donarmstrong.com Git - debbugs.git/commitdiff
note that a bug is done in the transcript; bail out earlier for merged bugs
authorDon Armstrong <don@donarmstrong.com>
Mon, 27 Feb 2012 23:54:18 +0000 (15:54 -0800)
committerDon Armstrong <don@donarmstrong.com>
Mon, 27 Feb 2012 23:54:18 +0000 (15:54 -0800)
Debbugs/Control.pm

index e5a1dd24b2d0ce8e05d2dbec026574dba02d3b96..f5ed9be320bd58547b468b452421f313397f3fa1 100644 (file)
@@ -921,6 +921,15 @@ sub set_done {
        my %submitter_notified;
        my $requester_notified = 0;
        my $orig_report_set = 0;
+       for my $data (@data) {
+           if (exists $data->{done} and
+               defined $data->{done} and
+               length $data->{done}) {
+               print {$transcript} "Bug $data->{bug_num} is already marked as done; not doing anything.\n";
+               __end_control(%info);
+               return;
+           }
+       }
        for my $data (@data) {
            my $old_data = dclone($data);
            my $hash = get_hashname($data->{bug_num});
@@ -939,13 +948,6 @@ sub set_done {
                $orig_report_set = 1;
            }
 
-           if (exists $data->{done} and
-               defined $data->{done} and
-               length $data->{done}) {
-               print {$transcript} "Bug $data->{bug_num} is already marked as done; not doing anything.\n";
-               __end_control(%info);
-               return;
-           }
            $action = "Marked $config{bug} as done";
 
            # set done to the requester
@@ -962,6 +964,7 @@ sub set_done {
                                )
                if not exists $param{append_log} or $param{append_log};
            writebug($data->{bug_num},$data);
+           print {$transcript} "$action\n";
            # get the original report
            if ($param{notify_submitter}) {
                my $submitter_message;