* Add english_join command to Debbugs::Common

diff --git a/Debbugs/Common.pm b/Debbugs/Common.pm
index f4a3f0cea33e70d78603d12c3bc2a62bbecc601e..e269ffc84fa69b8f2fe6462cfe24b0ffac98b95c 100644 (file)
--- a/Debbugs/Common.pm
+++ b/Debbugs/Common.pm
@@ -43,7 +43,7 @@ BEGIN{
                                qw(getmaintainers_reverse),
                                qw(getpseudodesc),
                               ],
-                    misc   => [qw(make_list globify_scalar)],
+                    misc   => [qw(make_list globify_scalar english_join)],
                     date   => [qw(secs_to_english)],
                     quit   => [qw(quit)],
                     lock   => [qw(filelock unfilelock lockpid)],
@@ -478,6 +478,27 @@ sub make_list {
 }
 
 
+=head2 english_join
+
+     print english_join(', ',' and ',@list);
+
+Joins list properly to make an english phrase.
+
+
+
+=cut
+
+sub english_join {
+     my ($normal,$last,@list) = @_;
+     if (@list <= 1) {
+         return @list?$list[0]:();
+     }
+     my $ret = $last . pop(@list);
+     $ret = join($normal,@list) . $ret;
+     return $ret;
+}
+
+
 =head2 globify_scalar
 
      my $handle = globify_scalar(\$foo);