fix corner case where Debbugs::Versions would return positive or negative numbers

diff --git a/Debbugs/Versions/Dpkg.pm b/Debbugs/Versions/Dpkg.pm
index 9745cbb4b28ab1886b982d041050173d3b8715bf..af955f287b1d2fb3202af7d61d28dedee0cbe76e 100644 (file)
--- a/Debbugs/Versions/Dpkg.pm
+++ b/Debbugs/Versions/Dpkg.pm
@@ -124,7 +124,8 @@ sub verrevcmp($$)
          }
          return 1 if defined $vc and $vc =~ /^\d$/;
          return -1 if defined $rc and $rc =~ /^\d$/;
-         return $first_diff if $first_diff;
+         return (($first_diff  > 0) ? 1 : -1) if $first_diff;
+         # return $first_diff if $first_diff;
      }
      return 0;
 }

diff --git a/t/02_version_dpkg.t b/t/02_version_dpkg.t
index 9e8e0b032b8b7147a73b62755df3c9183344e00a..e61345577e6eca9206b4ed054782614cdacac0ee 100644 (file)
--- a/t/02_version_dpkg.t
+++ b/t/02_version_dpkg.t
@@ -29,6 +29,17 @@ my @versions = ({a      => '1.0-1',
                 result => 0,
                 relation => 'eq',
                },
+               # q(1.1-20080727-1),q(1.1-20080316-1)
+               {a      => '1.1-20080727-1',
+                b      => '1.1-20080316-1',
+                result => 1,
+                relation => 'gt',
+               },
+               {a      => '1.1-20080316-1',
+                b      => '1.1-20080727-1',
+                result => -1,
+                relation => 'lt',
+               },
               );
 
 plan tests => @versions * 2 + 1;